Skip to contentSkip to conversation

arm64: dts: Remove inconsistent use of 'arm, armv8' compatible string

PATCH RESEND Superseded Fabrizio Castro 4 participants 8 messages Sep 2, 2019 – Sep 5, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 arm64: dts: Remove inconsistent use of 'arm, armv8' compatible string

From: Rob Herring <[email protected]>

commit 31af04cd60d3162a58213363fd740a2b0cf0a08e upstream.

The 'arm,armv8' compatible string is only for software models. It adds little value otherwise and is inconsistently used as a fallback on some platforms. Remove it from those platforms.

This fixes warnings generated by the DT schema.

---
I have put the CIP maintainers in CC, to try and troubleshoot where the mysterious spaces are coming from, please bear with me...

 arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/renesas/r8a774a1.dtsi +6 -6
index 1969649..a77de9e 100644
@@ -61,7 +61,7 @@
 		#size-cells = <0>;
 
 		a57_0: cpu at 0 {
-			compatible = "arm,cortex-a57", "arm,armv8";
+			compatible = "arm,cortex-a57";
 			reg = <0x0>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA57_CPU0>;
@@ -71,7 +71,7 @@
 		};
 
 		a57_1: cpu at 1 {
-			compatible = "arm,cortex-a57", "arm,armv8";
+			compatible = "arm,cortex-a57";
 			reg = <0x1>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA57_CPU1>;
@@ -81,7 +81,7 @@
 		};
 
 		a53_0: cpu at 100 {
-			compatible = "arm,cortex-a53", "arm,armv8";
+			compatible = "arm,cortex-a53";
 			reg = <0x100>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA53_CPU0>;
@@ -91,7 +91,7 @@
 		};
 
 		a53_1: cpu at 101 {
-			compatible = "arm,cortex-a53", "arm,armv8";
+			compatible = "arm,cortex-a53";
 			reg = <0x101>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA53_CPU1>;
@@ -101,7 +101,7 @@
 		};
 
 		a53_2: cpu at 102 {
-			compatible = "arm,cortex-a53", "arm,armv8";
+			compatible = "arm,cortex-a53";
 			reg = <0x102>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA53_CPU2>;
@@ -111,7 +111,7 @@
 		};
 
 		a53_3: cpu at 103 {
-			compatible = "arm,cortex-a53", "arm,armv8";
+			compatible = "arm,cortex-a53";
 			reg = <0x103>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA53_CPU3>;
Signature · 1 line
2.7.4
#1 lore raw

PATCH RESEND 1/1 arm64: dts: Remove inconsistent use of 'arm, armv8' compatible string

Hi Pavel,

I have put you in CC (and kept the ML as recipient this time around), did you receive the patch with or without the space?

Thanks,
Fab

Quoted 110 lines

From: Fabrizio Castro <[email protected]>
Sent: 02 September 2019 09:48
Subject: [PATCH resend] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string

From: Rob Herring <[email protected]>

commit 31af04cd60d3162a58213363fd740a2b0cf0a08e upstream.

The 'arm,armv8' compatible string is only for software models. It adds little value otherwise and is inconsistently used as a fallback on some platforms. Remove it from those platforms.

This fixes warnings generated by the DT schema.

---
I have put the CIP maintainers in CC, to try and troubleshoot where the mysterious spaces are coming from, please bear with me...

 arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/renesas/r8a774a1.dtsi +6 -7
index 1969649..a77de9e 100644
@@ -61,7 +61,7 @@
 		#size-cells = <0>;
 
 		a57_0: cpu at 0 {
-			compatible = "arm,cortex-a57", "arm,armv8";
+			compatible = "arm,cortex-a57";
 			reg = <0x0>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA57_CPU0>;
@@ -71,7 +71,7 @@
 		};
 
 		a57_1: cpu at 1 {
-			compatible = "arm,cortex-a57", "arm,armv8";
+			compatible = "arm,cortex-a57";
 			reg = <0x1>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA57_CPU1>;
@@ -81,7 +81,7 @@
 		};
 
 		a53_0: cpu at 100 {
-			compatible = "arm,cortex-a53", "arm,armv8";
+			compatible = "arm,cortex-a53";
 			reg = <0x100>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA53_CPU0>;
@@ -91,7 +91,7 @@
 		};
 
 		a53_1: cpu at 101 {
-			compatible = "arm,cortex-a53", "arm,armv8";
+			compatible = "arm,cortex-a53";
 			reg = <0x101>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA53_CPU1>;
@@ -101,7 +101,7 @@
 		};
 
 		a53_2: cpu at 102 {
-			compatible = "arm,cortex-a53", "arm,armv8";
+			compatible = "arm,cortex-a53";
 			reg = <0x102>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA53_CPU2>;
@@ -111,7 +111,7 @@
 		};
 
 		a53_3: cpu at 103 {
-			compatible = "arm,cortex-a53", "arm,armv8";
+			compatible = "arm,cortex-a53";
 			reg = <0x103>;
 			device_type = "cpu";
 			power-domains = <&sysc R8A774A1_PD_CA53_CPU3>;
--

2.7.4

#2 lore raw

PATCH RESEND 1/1 arm64: dts: Remove inconsistent use of 'arm, armv8' compatible string

Quoted 4 lines · Fabrizio Castro

Hi Pavel,

I have put you in CC (and kept the ML as recipient this time around), did you receive the patch with or without the space?

I got just one copy of email, and it does not have [cip-dev] marking, so I assume it is the direct one.

No extra space.

Best regards,
Pavel

Signature · 9 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20190902/ea389035/attachment.sig>
#3 lore raw

PATCH RESEND 1/1 arm64: dts: Remove inconsistent use of 'arm, armv8' compatible string

Hi Pavel,

Thank you for the feedback!

Quoted 7 lines

From: Pavel Machek <[email protected]>
Sent: 02 September 2019 10:01
Subject: Re: [PATCH resend] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string

Quoted 2 lines · Fabrizio Castro

Hi Pavel,

Quoted 7 lines
Quoted 2 lines

I have put you in CC (and kept the ML as recipient this time around), did you receive the patch with or without the space?

I got just one copy of email, and it does not have [cip-dev] marking, so I assume it is the direct one.

No extra space.

Then it's down to the mailing list, somehow, this same email reached the ML, with a space...
https://lists.cip-project.org/pipermail/cip-dev/2019-September/003158.html
https://patchwork.kernel.org/patch/11126171/

Who is the person responsible for looking after the ML?

Thanks,
Fab

Quoted 6 lines

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

#4 lore raw

PATCH RESEND 1/1 arm64: dts: Remove inconsistent use of 'arm, armv8' compatible string

Hi Fabrizio,

Thanks for your test.

Quoted 28 lines

-----Original Message-----
From: Fabrizio Castro [mailto:fabrizio.castro at bp.renesas.com]
Sent: Monday, September 2, 2019 6:05 PM
To: Pavel Machek <[email protected]>
Cc: Chris Paterson <[email protected]>; Biju Das <[email protected]>; iwamatsu nobuhiro(?? ?? ??????? ?) <[email protected]>; cip-dev at lists.cip-project.org
Subject: RE: [PATCH resend] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string

Hi Pavel,

Thank you for the feedback!

Quoted 14 lines

From: Pavel Machek <[email protected]>
Sent: 02 September 2019 10:01
Subject: Re: [PATCH resend] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string

Quoted 4 lines · Fabrizio Castro

Hi Pavel,

I have put you in CC (and kept the ML as recipient this time around), did you receive the patch with or without the space?

I got just one copy of email, and it does not have [cip-dev] marking, so I assume it is the direct one.

Quoted 8 lines
Quoted 1 line

No extra space.

Then it's down to the mailing list, somehow, this same email reached the ML, with a space...
https://lists.cip-project.org/pipermail/cip-dev/2019-September/00315
8.html
https://patchwork.kernel.org/patch/11126171/

Hmmm. There may be a problem in Mailman.

Quoted 2 lines

Who is the person responsible for looking after the ML?

Maybe Kobayashi-san. I just talked to him about this. Please wait a minute.

Quoted 2 lines

Thanks,
Fab

Best regards,
Nobuhiro

#5 lore raw

PATCH RESEND 1/1 arm64: dts: Remove inconsistent use of 'arm, armv8' compatible string

Quoted 34 lines · On 03.09.19 06:45, nobuhiro1.iwamatsu at toshiba.co.jp wrote:

Hi Fabrizio,

Thanks for your test.

Quoted 30 lines

-----Original Message-----
From: Fabrizio Castro [mailto:fabrizio.castro at bp.renesas.com]
Sent: Monday, September 2, 2019 6:05 PM
To: Pavel Machek <[email protected]>
Cc: Chris Paterson <[email protected]>; Biju Das <[email protected]>; iwamatsu nobuhiro(?? ?? ??????? ?) <[email protected]>; cip-dev at lists.cip-project.org
Subject: RE: [PATCH resend] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string

Hi Pavel,

Thank you for the feedback!

Quoted 15 lines

From: Pavel Machek <[email protected]>
Sent: 02 September 2019 10:01
Subject: Re: [PATCH resend] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string

Quoted 4 lines · Fabrizio Castro

Hi Pavel,

I have put you in CC (and kept the ML as recipient this time around), did you receive the patch with or without the space?

I got just one copy of email, and it does not have [cip-dev] marking, so I assume it is the direct one.

No extra space.

Quoted 9 lines
Quoted 6 lines

Then it's down to the mailing list, somehow, this same email reached the ML, with a space...
https://lists.cip-project.org/pipermail/cip-dev/2019-September/00315
8.html
https://patchwork.kernel.org/patch/11126171/

Hmmm. There may be a problem in Mailman.

Comparing the original patch (https://lore.kernel.org/linux-amlogic/20190109202934.29304-1-robh at kernel.org/raw) to ours:

X-Mailman-Version: 2.1.21 (looks fine)
X-Mailman-Version: 2.1.12 (our potentially broken version)

It looks like 2.1.21 is starting the wrapped around subject line only with a single space while our version gained a tab. The latter is likely the core if the issue. I would not expect this difference to be a configuration option of mailman, rather an issue in the older version

HTH,
Jan

Quoted 16 lines
Quoted 2 lines

Who is the person responsible for looking after the ML?

Maybe Kobayashi-san. I just talked to him about this. Please wait a minute.

Quoted 2 lines

Thanks,
Fab

Best regards,
Nobuhiro
_______________________________________________
cip-dev mailing list
cip-dev at lists.cip-project.org
https://lists.cip-project.org/mailman/listinfo/cip-dev

Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
#6 lore raw

PATCH RESEND 1/1 arm64: dts: Remove inconsistent use of 'arm, armv8' compatible string

https://patchwork.kernel.org/patch/10754905/

Quoted 62 lines

-----Original Message-----
From: Jan Kiszka [mailto:jan.kiszka at siemens.com]
Sent: Tuesday, September 3, 2019 10:56 PM
To: iwamatsu nobuhiro(?? ?? ????????) <[email protected]>; fabrizio.castro at bp.renesas.com; pavel at denx.de
Cc: cip-dev at lists.cip-project.org; biju.das at bp.renesas.com
Subject: Re: [cip-dev] [PATCH resend] arm64: dts: Remove inconsistent use of 'arm, armv8' compatible string

Quoted 10 lines · On 03.09.19 06:45, nobuhiro1.iwamatsu at toshiba.co.jp wrote:

Hi Fabrizio,

Thanks for your test.

Quoted 6 lines

-----Original Message-----
From: Fabrizio Castro [mailto:fabrizio.castro at bp.renesas.com]
Sent: Monday, September 2, 2019 6:05 PM
To: Pavel Machek <[email protected]>
Cc: Chris Paterson <[email protected]>; Biju Das <[email protected]>; iwamatsu nobuhiro(?? ?? ?????

??

Quoted 1 line
Quoted 1 line

?) <[email protected]>;

cip-dev at lists.cip-project.org

Quoted 18 lines
Quoted 18 lines

Subject: RE: [PATCH resend] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string

Hi Pavel,

Thank you for the feedback!

Quoted 11 lines

From: Pavel Machek <[email protected]>
Sent: 02 September 2019 10:01
Subject: Re: [PATCH resend] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string

Quoted 4 lines · Fabrizio Castro

Hi Pavel,

I have put you in CC (and kept the ML as recipient this time around), did you receive the patch with or without the space?

Quoted 8 lines
Quoted 8 lines
Quoted 4 lines

I got just one copy of email, and it does not have [cip-dev] marking, so I assume it is the direct one.

No extra space.

Then it's down to the mailing list, somehow, this same email reached the ML, with a space...

https://lists.cip-project.org/pipermail/cip-dev/2019-September/00315

Quoted 6 lines
Quoted 3 lines

8.html
https://patchwork.kernel.org/patch/11126171/

Hmmm. There may be a problem in Mailman.

Comparing the original patch
(https://lore.kernel.org/linux-amlogic/20190109202934.29304-1-robh at k ernel.org/raw) to ours:

Quoted 8 lines

X-Mailman-Version: 2.1.21 (looks fine)
X-Mailman-Version: 2.1.12 (our potentially broken version)

It looks like 2.1.21 is starting the wrapped around subject line only with a single space while our version gained a tab. The latter is likely the core if the issue. I would not expect this difference to be a configuration option of mailman, rather an issue in the older version

Thank you for information.

And the original patch thread is interesting.
Each subject has space issues. Please see "Thread overview" at the bottom of the page.
https://lore.kernel.org/linux-amlogic/2053cd60-479a-4219-2415-ebb6a860a8e7 at kernel.org/t/

Quoted 3 lines

HTH,
Jan

Best regards,
Nobuhiro

#7 lore raw

PATCH RESEND 1/1 arm64: dts: Remove inconsistent use of 'arm, armv8' compatible string

Quoted 73 lines · On 05.09.19 03:16, nobuhiro1.iwamatsu at toshiba.co.jp wrote:

https://patchwork.kernel.org/patch/10754905/

Quoted 62 lines

-----Original Message-----
From: Jan Kiszka [mailto:jan.kiszka at siemens.com]
Sent: Tuesday, September 3, 2019 10:56 PM
To: iwamatsu nobuhiro(?? ?? ????????) <[email protected]>; fabrizio.castro at bp.renesas.com; pavel at denx.de
Cc: cip-dev at lists.cip-project.org; biju.das at bp.renesas.com
Subject: Re: [cip-dev] [PATCH resend] arm64: dts: Remove inconsistent use of 'arm, armv8' compatible string

Quoted 10 lines · On 03.09.19 06:45, nobuhiro1.iwamatsu at toshiba.co.jp wrote:

Hi Fabrizio,

Thanks for your test.

Quoted 6 lines

-----Original Message-----
From: Fabrizio Castro [mailto:fabrizio.castro at bp.renesas.com]
Sent: Monday, September 2, 2019 6:05 PM
To: Pavel Machek <[email protected]>
Cc: Chris Paterson <[email protected]>; Biju Das <[email protected]>; iwamatsu nobuhiro(?? ?? ?????

??

Quoted 1 line
Quoted 1 line

?) <[email protected]>;

cip-dev at lists.cip-project.org

Quoted 18 lines
Quoted 18 lines

Subject: RE: [PATCH resend] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string

Hi Pavel,

Thank you for the feedback!

Quoted 11 lines

From: Pavel Machek <[email protected]>
Sent: 02 September 2019 10:01
Subject: Re: [PATCH resend] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string

Quoted 4 lines · Fabrizio Castro

Hi Pavel,

I have put you in CC (and kept the ML as recipient this time around), did you receive the patch with or without the space?

Quoted 8 lines
Quoted 8 lines
Quoted 4 lines

I got just one copy of email, and it does not have [cip-dev] marking, so I assume it is the direct one.

No extra space.

Then it's down to the mailing list, somehow, this same email reached the ML, with a space...

https://lists.cip-project.org/pipermail/cip-dev/2019-September/00315

Quoted 6 lines
Quoted 3 lines

8.html
https://patchwork.kernel.org/patch/11126171/

Hmmm. There may be a problem in Mailman.

Comparing the original patch
(https://lore.kernel.org/linux-amlogic/20190109202934.29304-1-robh at k ernel.org/raw) to ours:

Quoted 8 lines

X-Mailman-Version: 2.1.21 (looks fine)
X-Mailman-Version: 2.1.12 (our potentially broken version)

It looks like 2.1.21 is starting the wrapped around subject line only with a single space while our version gained a tab. The latter is likely the core if the issue. I would not expect this difference to be a configuration option of mailman, rather an issue in the older version

Quoted 6 lines

Thank you for information.

And the original patch thread is interesting.
Each subject has space issues. Please see "Thread overview" at the bottom of the page.
https://lore.kernel.org/linux-amlogic/2053cd60-479a-4219-2415-ebb6a860a8e7 at kernel.org/t/

Interesting. There seem to be more mail processing tools involved that decided to wrap at the comma, although there was no space following after it.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux