Skip to contentSkip to conversation

Makefile: fix newline escaping for CONFIG_DEFAULT_ENV_FILE

PATCH New Rasmus Villemoes 2 participants 2 messages Aug 28, 2019 – Sep 2, 2019 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: fix newline escaping for CONFIG_DEFAULT_ENV_FILE

I wanted this to be compatible with mkenvimage, including the ability to embed newlines in variables by escaping them. But I failed to check that it works more than once.

Fixes f3d8f7dd73a (Allow providing default environment from file)
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index aedc2ea4d9..8ae59ef3f0 100644
@@ -1633,7 +1633,7 @@ define filechk_defaultenv.h
 	(grep -v '^#' | \
 	 grep -v '^$$' | \
 	 tr '\n' '\0' | \
-	 sed -e 's/\\\x0/\n/' | \
+	 sed -e 's/\\\x0/\n/g' | \
 	 xxd -i ; echo ", 0x00" ; )
 endef
 
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 Makefile: fix newline escaping for CONFIG_DEFAULT_ENV_FILE

Quoted 6 lines · Rasmus Villemoes

I wanted this to be compatible with mkenvimage, including the ability to embed newlines in variables by escaping them. But I failed to check that it works more than once.

Fixes f3d8f7dd73a (Allow providing default environment from file)

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190902/9ccc3e34/attachment.sig>