Skip to contentSkip to conversation

cifs: add new debugging macro cifs_server_dbg

bug report Dan Carpenter 1 participant 1 message Sep 3, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hello Ronnie Sahlberg,

This is a semi-automatic email about new static checker warnings.

The patch 2808c6639104: "cifs: add new debugging macro cifs_server_dbg" from Aug 28, 2019, leads to the following Smatch complaint:

fs/cifs/smb2pdu.c:3067 query_info()
warn: variable dereferenced before check 'ses' (see line 3061)

fs/cifs/smb2pdu.c
3060 struct cifs_ses *ses = tcon->ses;

  3061		struct TCP_Server_Info *server = ses->server;
                                                 ^^^^^^^^^^^

New dereference.

3062 int flags = 0;
3063 bool allocated = false;
3064
3065 cifs_dbg(FYI, "Query Info\n");
3066
3067 if (!ses || !(server))

                    ^^^^

The old code checked for NULL.

3068 return -EIO;
3069

regards,
dan carpenter