drm/vkms: Use alpha value to blend values.
PATCH 1/1 drm/vkms: Use alpha value to blend values.
Use alpha value to blend source value and destination value Instead of just overwrite with source value.
--- drivers/gpu/drm/vkms/vkms_composer.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
drivers/gpu/drm/vkms/vkms_composer.c +11 -2
@@ -75,6 +75,9 @@ static void blend(void *vaddr_dst, void *vaddr_src,int y_limit = y_src + h_dst;int x_limit = x_src + w_dst; +u8 *src, *dst; +u32 alpha, inv_alpha; +for (i = y_src, i_dst = y_dst; i < y_limit; ++i) {for (j = x_src, j_dst = x_dst; j < x_limit; ++j) { offset_dst = dest_composer->offset
@@ -84,8 +87,14 @@ static void blend(void *vaddr_dst, void *vaddr_src, + (i * src_composer->pitch) + (j * src_composer->cpp); -memcpy (vaddr_dst + offset_dst, - vaddr_src + offset_src,sizeof (u32)); + src = vaddr_src + offset_src; + dst = vaddr_dst + offset_dst; + alpha = src[3 ] +1 ; + inv_alpha =256 - src[3 ]; + dst[0 ] = (alpha * src[0 ] + inv_alpha * dst[0 ]) >>8 ; + dst[1 ] = (alpha * src[1 ] + inv_alpha * dst[1 ]) >>8 ; + dst[2 ] = (alpha * src[2 ] + inv_alpha * dst[2 ]) >>8 ; + dst[3 ] =0xff ; } i_dst++; }
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 13 lines · Sidong Yang
Use alpha value to blend source value and destination value Instead of just overwrite with source value.
Signed-off-by Sidong Yang <[email protected]>--- drivers/gpu/drm/vkms/vkms_composer.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)drivers/gpu/drm/vkms/vkms_composer.c +0
-0
drivers/gpu/drm/vkms/vkms_composer.c static void blend(void *vaddr_dst, void *vaddr_src, · line 79
Quoted 5 lines
drivers/gpu/drm/vkms/vkms_composer.c +2
-0@@ -75,6 +75,9 @@ static void blend(void *vaddr_dst, void *vaddr_src,int y_limit = y_src + h_dst;int x_limit = x_src + w_dst; +u8 *src, *dst; +u32 alpha, inv_alpha;
These could all live in a tighter scope.
Apart from that lgtm
Quoted 28 lines
drivers/gpu/drm/vkms/vkms_composer.c +9
-2+for (i = y_src, i_dst = y_dst; i < y_limit; ++i) {for (j = x_src, j_dst = x_dst; j < x_limit; ++j) { offset_dst = dest_composer->offset@@ -84,8 +87,14 @@ static void blend(void *vaddr_dst, void *vaddr_src, + (i * src_composer->pitch) + (j * src_composer->cpp); -memcpy (vaddr_dst + offset_dst, - vaddr_src + offset_src,sizeof (u32)); + src = vaddr_src + offset_src; + dst = vaddr_dst + offset_dst; + alpha = src[3 ] +1 ; + inv_alpha =256 - src[3 ]; + dst[0 ] = (alpha * src[0 ] + inv_alpha * dst[0 ]) >>8 ; + dst[1 ] = (alpha * src[1 ] + inv_alpha * dst[1 ]) >>8 ; + dst[2 ] = (alpha * src[2 ] + inv_alpha * dst[2 ]) >>8 ; + dst[3 ] =0xff ; } i_dst++; }Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 17 lines · Ville Syrjälä
Quoted 16 lines · Sidong Yang
Use alpha value to blend source value and destination value Instead of just overwrite with source value.
Signed-off-by Sidong Yang <[email protected]>--- drivers/gpu/drm/vkms/vkms_composer.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)drivers/gpu/drm/vkms/vkms_composer.c +0
-0@@ -75,6 +75,9 @@ static void blend(void *vaddr_dst, void *vaddr_src,int y_limit = y_src + h_dst;int x_limit = x_src + w_dst;
Quoted 4 lines
drivers/gpu/drm/vkms/vkms_composer.c static void blend(void *vaddr_dst, void *vaddr_src, · line 79
Quoted 2 lines
drivers/gpu/drm/vkms/vkms_composer.c +2
-0+u8 *src, *dst; +u32 alpha, inv_alpha;These could all live in a tighter scope.
Hi, Ville.
Thank you for reviewing my patch.
I think that's good idea and I'll do that in next version. I found some patch in mailing list that is similar with this patch. So should I drop this patch and find other thing?
Sidong.
Quoted 28 lines
Apart from that lgtm
Reviewed-by Ville Syrjälä <[email protected]>Quoted 24 lines
drivers/gpu/drm/vkms/vkms_composer.c +9
-2+for (i = y_src, i_dst = y_dst; i < y_limit; ++i) {for (j = x_src, j_dst = x_dst; j < x_limit; ++j) { offset_dst = dest_composer->offset@@ -84,8 +87,14 @@ static void blend(void *vaddr_dst, void *vaddr_src, + (i * src_composer->pitch) + (j * src_composer->cpp); -memcpy (vaddr_dst + offset_dst, - vaddr_src + offset_src,sizeof (u32)); + src = vaddr_src + offset_src; + dst = vaddr_dst + offset_dst; + alpha = src[3 ] +1 ; + inv_alpha =256 - src[3 ]; + dst[0 ] = (alpha * src[0 ] + inv_alpha * dst[0 ]) >>8 ; + dst[1 ] = (alpha * src[1 ] + inv_alpha * dst[1 ]) >>8 ; + dst[2 ] = (alpha * src[2 ] + inv_alpha * dst[2 ]) >>8 ; + dst[3 ] =0xff ; } i_dst++; }Signature · 1 line
2.20.1
Quoted 8 lines
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-develSignature · 2 lines
Ville Syrjälä Intel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 23 lines · Sidong Yang
Quoted 17 lines · Ville Syrjälä
Quoted 16 lines · Sidong Yang
Use alpha value to blend source value and destination value Instead of just overwrite with source value.
Signed-off-by Sidong Yang <[email protected]>--- drivers/gpu/drm/vkms/vkms_composer.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)drivers/gpu/drm/vkms/vkms_composer.c +0
-0@@ -75,6 +75,9 @@ static void blend(void *vaddr_dst, void *vaddr_src,int y_limit = y_src + h_dst;int x_limit = x_src + w_dst;Quoted 4 lines
drivers/gpu/drm/vkms/vkms_composer.c static void blend(void *vaddr_dst, void *vaddr_src, · line 79
Quoted 2 lines
drivers/gpu/drm/vkms/vkms_composer.c +2
-0+u8 *src, *dst; +u32 alpha, inv_alpha;These could all live in a tighter scope.
Quoted 6 lines
Hi, Ville.
Thank you for reviewing my patch.
I think that's good idea and I'll do that in next version. I found some patch in mailing list that is similar with this patch. So should I drop this patch and find other thing?
Probably best if you discuss that with whoever sent that other patch.
Quoted 39 lines
Sidong.
Quoted 36 lines
Apart from that lgtm
Reviewed-by Ville Syrjälä <[email protected]>Quoted 28 lines
drivers/gpu/drm/vkms/vkms_composer.c +9
-2+for (i = y_src, i_dst = y_dst; i < y_limit; ++i) {for (j = x_src, j_dst = x_dst; j < x_limit; ++j) { offset_dst = dest_composer->offset@@ -84,8 +87,14 @@ static void blend(void *vaddr_dst, void *vaddr_src, + (i * src_composer->pitch) + (j * src_composer->cpp); -memcpy (vaddr_dst + offset_dst, - vaddr_src + offset_src,sizeof (u32)); + src = vaddr_src + offset_src; + dst = vaddr_dst + offset_dst; + alpha = src[3 ] +1 ; + inv_alpha =256 - src[3 ]; + dst[0 ] = (alpha * src[0 ] + inv_alpha * dst[0 ]) >>8 ; + dst[1 ] = (alpha * src[1 ] + inv_alpha * dst[1 ]) >>8 ; + dst[2 ] = (alpha * src[2 ] + inv_alpha * dst[2 ]) >>8 ; + dst[3 ] =0xff ; } i_dst++; }Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-develSignature · 2 lines
Ville Syrjälä Intel
Signature · 2 lines
Ville Syrjälä Intel