crypto/virtio: alloc private data by NUMA affinity
Subsystems (3)
PATCH 1/1 crypto/virtio: alloc private data by NUMA affinity
It's better to allocate device private data on the same NUMA node with device, rather than with the main thread. This helps avoid cross-NUMA access for worker thread.
--- drivers/crypto/virtio/virtio_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/virtio/virtio_cryptodev.c +1 -1
@@ -1441,7 +1441,7 @@ crypto_virtio_pci_probe( {struct rte_cryptodev_pmd_init_params init_params = { .name ="" , - .socket_id =rte_socket_id (), + .socket_id = pci_dev->device.numa_node, .private_data_size =sizeof (struct virtio_crypto_hw ) };char name[RTE_CRYPTODEV_NAME_MAX_LEN ];
Signature · 1 line
2.15.1
Hi Jay,
Could you please review this change.
Thanks,
Akhil
Quoted 26 lines
It's better to allocate device private data on the same NUMA node with device, rather than with the main thread. This helps avoid cross-NUMA access for worker thread.
Signed-off-by Xiao Wang <[email protected]>--- drivers/crypto/virtio/virtio_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/crypto/virtio/virtio_cryptodev.c +1
-2@@ -1441,7 +1441,7 @@ crypto_virtio_pci_probe( {struct rte_cryptodev_pmd_init_params init_params = { .name ="" , - .socket_id =rte_socket_id (), + .socket_id = pci_dev->device.numa_node, .private_data_size =sizeof (struct virtio_crypto_hw ) };char name[RTE_CRYPTODEV_NAME_MAX_LEN ]; --2.15.1
Quoted 10 lines
-----Original Message-----
From: Akhil Goyal [mailto:[email protected]]
Sent: Friday, October 4, 2019 8:00 PM
To: Zhoujian (jay) <[email protected]>
Cc: [email protected]; Xiao Wang <[email protected]>
Subject: RE: [dpdk-dev] [PATCH]crypto/virtio: alloc private data by NUMA affinity
Quoted 6 lines
Hi Jay,
Could you please review this change.
Thanks,
Akhil
Hi Akhil,
Sure, sorry for the late response.
Thanks,
Jay
Quoted 26 lines
Quoted 26 lines
It's better to allocate device private data on the same NUMA node with device, rather than with the main thread. This helps avoid cross-NUMA access for worker thread.
Signed-off-by Xiao Wang <[email protected]>--- drivers/crypto/virtio/virtio_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/crypto/virtio/virtio_cryptodev.c +1
-2@@ -1441,7 +1441,7 @@ crypto_virtio_pci_probe( {struct rte_cryptodev_pmd_init_params init_params = { .name ="" , - .socket_id =rte_socket_id (), + .socket_id = pci_dev->device.numa_node, .private_data_size =sizeof (struct virtio_crypto_hw ) };char name[RTE_CRYPTODEV_NAME_MAX_LEN ]; --2.15.1
Quoted 9 lines
-----Original Message-----
From: Xiao Wang [mailto:[email protected]]
Sent: Wednesday, September 4, 2019 9:22 PM
To: Zhoujian (jay) <[email protected]>
Cc: [email protected]; Xiao Wang <[email protected]>
Subject: [PATCH]crypto/virtio: alloc private data by NUMA affinity
Quoted 5 lines
It's better to allocate device private data on the same NUMA node with device, rather than with the main thread. This helps avoid cross-NUMA access for worker thread.
Signed-off-by Xiao Wang <[email protected]>
Quoted 19 lines
--- drivers/crypto/virtio/virtio_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/crypto/virtio/virtio_cryptodev.c +1
-2@@ -1441,7 +1441,7 @@ crypto_virtio_pci_probe( {struct rte_cryptodev_pmd_init_params init_params = { .name ="" , - .socket_id =rte_socket_id (), + .socket_id = pci_dev->device.numa_node, .private_data_size =sizeof (struct virtio_crypto_hw ) };char name[RTE_CRYPTODEV_NAME_MAX_LEN ]; --2.15.1
Akhil Goyal
AppliedQuoted 11 lines
Quoted 8 lines
It's better to allocate device private data on the same NUMA node with device, rather than with the main thread. This helps avoid cross-NUMA access for worker thread.
Signed-off-by Xiao Wang <[email protected]>Reviewed-by Jay Zhou <[email protected]>
Applied to dpdk-next-crypto
Thanks.