drm/amdkfd: introduce the kfd support for Renoir
Subsystems (3)
cover drm/amdkfd: introduce the kfd support for Renoir
Hi all,
These patch set provides the kfd support for ROCm stack on Renoir APU.
Thanks,
Ray
Huang Rui (10):
drm/amdkfd: add renoir cache info for CRAT drm/amdkfd: add renoir kfd device info
drm/amdkfd: enable kfd device queue manager v9 for renoir drm/amdkfd: add renoir typs for the workaround of iommu v2 drm/amdkfd: init kfd apertures v9 for renoir drm/amdkfd: init kernel queue for renoir drm/amdkfd: add package manager for renoir drm/amdkfd: add renoir kfd topology
drm/amdgpu: disable gfxoff while use no H/W scheduling policy drm/amdkfd: enable renoir while device probes
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 ++++ drivers/gpu/drm/amd/amdkfd/kfd_device.c | 19 +++++++++++++++++++ drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_events.c | 3 ++- drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 + 11 files changed, 33 insertions(+), 2 deletions(-)
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/10 drm/amdkfd: add renoir cache info for CRAT
Renoir's cache info should be the same with raven and carrizo's.
--- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/amd/amdkfd/kfd_crat.c +4 -0
@@ -138,6 +138,7 @@ static struct kfd_gpu_cache_info carrizo_cache_info[] = {/* TODO - check & update Vega10 cache details */ #define vega10_cache_info carrizo_cache_info#define raven_cache_info carrizo_cache_info +#define renoir_cache_info carrizo_cache_info/* TODO - check & update Navi10 cache details */ #define navi10_cache_info carrizo_cache_info
@@ -668,6 +669,9 @@ static int kfd_fill_gpu_cache_info(struct kfd_dev *kdev,case CHIP_RAVEN : pcache_info = raven_cache_info; num_of_cache_types =ARRAY_SIZE (raven_cache_info); +case CHIP_RENOIR : + pcache_info = renoir_cache_info; + num_of_cache_types =ARRAY_SIZE (renoir_cache_info);case CHIP_NAVI10 : pcache_info = navi10_cache_info; num_of_cache_types =ARRAY_SIZE (navi10_cache_info);
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH 01/10] drm/amdkfd: add renoir cache info for CRAT
Quoted 20 lines · Ray
Renoir's cache info should be the same with raven and carrizo's.
Signed-off-by Huang Rui <[email protected]>--- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/amd/amdkfd/kfd_crat.c +1
-0@@ -138,6 +138,7 @@ static struct kfd_gpu_cache_info carrizo_cache_info[] = {/* TODO - check & update Vega10 cache details */ #define vega10_cache_info carrizo_cache_info#define raven_cache_info carrizo_cache_info +#define renoir_cache_info carrizo_cache_info/* TODO - check & update Navi10 cache details */ #define navi10_cache_info carrizo_cache_info
drivers/gpu/drm/amd/amdkfd/kfd_crat.c static int kfd_fill_gpu_cache_info(struct kfd_dev *kdev, · line 674
Quoted 6 lines
drivers/gpu/drm/amd/amdkfd/kfd_crat.c +3
-0@@ -668,6 +669,9 @@ static int kfd_fill_gpu_cache_info(struct kfd_dev *kdev,case CHIP_RAVEN : pcache_info = raven_cache_info; num_of_cache_types =ARRAY_SIZE (raven_cache_info); +case CHIP_RENOIR : + pcache_info = renoir_cache_info; + num_of_cache_types =ARRAY_SIZE (renoir_cache_info);
I just noticed, there are break; statements missing here. Which branch are your changes based on? At least the surrounding code looks OK on amd-staging-drm-next, but seems to be missing a break statement at least in the Raven case here.
Regards,
Felix
drivers/gpu/drm/amd/amdkfd/kfd_crat.c static int kfd_fill_gpu_cache_info(struct kfd_dev *kdev, · line 677
Quoted 3 lines
drivers/gpu/drm/amd/amdkfd/kfd_crat.c +0
-0case CHIP_NAVI10 : pcache_info = navi10_cache_info; num_of_cache_types =ARRAY_SIZE (navi10_cache_info);
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 6fe2ad6f-24fb-db4b-7b75-3149f0c0257a-5C7GfCeVMHo@public.gmane.org
Re: [PATCH 01/10] drm/amdkfd: add renoir cache info for CRAT
Quoted 20 lines · Felix
Quoted 19 lines · Ray
Renoir's cache info should be the same with raven and carrizo's.
Signed-off-by Huang Rui <[email protected]>--- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/amd/amdkfd/kfd_crat.c +1
-0@@ -138,6 +138,7 @@ static struct kfd_gpu_cache_info carrizo_cache_info[] = {/* TODO - check & update Vega10 cache details */ #define vega10_cache_info carrizo_cache_info#define raven_cache_info carrizo_cache_info +#define renoir_cache_info carrizo_cache_info/* TODO - check & update Navi10 cache details */ #define navi10_cache_info carrizo_cache_info
Quoted 13 lines
drivers/gpu/drm/amd/amdkfd/kfd_crat.c static int kfd_fill_gpu_cache_info(struct kfd_dev *kdev, · line 674
Quoted 7 lines
drivers/gpu/drm/amd/amdkfd/kfd_crat.c +3
-0@@ -668,6 +669,9 @@ static int kfd_fill_gpu_cache_info(struct kfd_dev *kdev,case CHIP_RAVEN : pcache_info = raven_cache_info; num_of_cache_types =ARRAY_SIZE (raven_cache_info); +case CHIP_RENOIR : + pcache_info = renoir_cache_info; + num_of_cache_types =ARRAY_SIZE (renoir_cache_info);I just noticed, there are break; statements missing here. Which branch are your changes based on? At least the surrounding code looks OK on amd-staging-drm-next, but seems to be missing a break statement at least in the Raven case here.
Thanks to catch this. I will re-send v2 patch later.
Thanks,
Ray
Quoted 7 lines
Regards,
FelixQuoted 3 lines
drivers/gpu/drm/amd/amdkfd/kfd_crat.c +0
-0case CHIP_NAVI10 : pcache_info = navi10_cache_info; num_of_cache_types =ARRAY_SIZE (navi10_cache_info);
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 2/10 drm/amdkfd: add renoir kfd device info
In reply to a message not in the archiveThis patch inits renoir kfd device info, so we treat renoir as "dgpu" (bypass iommu v2). Will enable needs_iommu_device till renoir iommu is ready.
--- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
drivers/gpu/drm/amd/amdkfd/kfd_device.c +19 -0
@@ -317,6 +317,23 @@ static const struct kfd_device_info vega20_device_info = { .num_sdma_queues_per_engine = 8, }; +static const struct kfd_device_info renoir_device_info = { + .asic_family =CHIP_RENOIR , + .max_pasid_bits =16 , + .max_no_of_hqd =24 , + .doorbell_size =8 , + .ih_ring_entry_size =8 *sizeof (uint32_t ), + .event_interrupt_class = &event_interrupt_class_v9, + .num_of_watch_points =4 , + .mqd_size_aligned =MQD_SIZE_ALIGNED , + .supports_cwsr = true, + .needs_iommu_device = false, + .needs_pci_atomics = false, + .num_sdma_engines =1 , + .num_xgmi_sdma_engines =0 , + .num_sdma_queues_per_engine =2 , +}; +static const struct kfd_device_info navi10_device_info = { .asic_family =CHIP_NAVI10 , .max_pasid_bits =16 ,
@@ -452,6 +469,8 @@ static const struct kfd_deviceid supported_devices[] = { { 0x66a4, &vega20_device_info }, /* Vega20 */ { 0x66a7, &vega20_device_info }, /* Vega20 */ { 0x66af, &vega20_device_info }, /* Vega20 */ +/* Renoir */ + { 0x1636, &renoir_device_info }, /* Renoir *//* Navi10 */ { 0x7310, &navi10_device_info }, /* Navi10 */ { 0x7312, &navi10_device_info }, /* Navi10 */
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Kuehling, Felix
Reviewed-by Felix KuehlingRe: [PATCH 02/10] drm/amdkfd: add renoir kfd device info
Quoted 4 lines · Ray
This patch inits renoir kfd device info, so we treat renoir as "dgpu" (bypass iommu v2). Will enable
needs_iommu_devicetill renoir iommu is ready.Signed-off-by Huang Rui <[email protected]>
Looks good, but please coordinate with Yong who is changing the structure of the kfd device info table. See his patch "drm/amdkfd: Query kfd device info by CHIP id instead of pci device id" for details. Whoever goes in second will need to rebase and fix the conflict.
Quoted 33 lines
--- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)drivers/gpu/drm/amd/amdkfd/kfd_device.c +17
-0@@ -317,6 +317,23 @@ static const struct kfd_device_info vega20_device_info = { .num_sdma_queues_per_engine = 8, }; +static const struct kfd_device_info renoir_device_info = { + .asic_family =CHIP_RENOIR , + .max_pasid_bits =16 , + .max_no_of_hqd =24 , + .doorbell_size =8 , + .ih_ring_entry_size =8 *sizeof (uint32_t ), + .event_interrupt_class = &event_interrupt_class_v9, + .num_of_watch_points =4 , + .mqd_size_aligned =MQD_SIZE_ALIGNED , + .supports_cwsr = true, + .needs_iommu_device = false, + .needs_pci_atomics = false, + .num_sdma_engines =1 , + .num_xgmi_sdma_engines =0 , + .num_sdma_queues_per_engine =2 , +}; +static const struct kfd_device_info navi10_device_info = { .asic_family =CHIP_NAVI10 , .max_pasid_bits =16 ,
drivers/gpu/drm/amd/amdkfd/kfd_device.c static const struct kfd_deviceid supported_devices[] = { · line 476
Quoted 8 lines
drivers/gpu/drm/amd/amdkfd/kfd_device.c +2
-0@@ -452,6 +469,8 @@ static const struct kfd_deviceid supported_devices[] = { { 0x66a4, &vega20_device_info }, /* Vega20 */ { 0x66a7, &vega20_device_info }, /* Vega20 */ { 0x66af, &vega20_device_info }, /* Vega20 */ +/* Renoir */ + { 0x1636, &renoir_device_info }, /* Renoir *//* Navi10 */ { 0x7310, &navi10_device_info }, /* Navi10 */ { 0x7312, &navi10_device_info }, /* Navi10 */
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): d0c57dac-d5c6-de6c-be9f-d70cbe0f3d96-5C7GfCeVMHo@public.gmane.org
Re: [PATCH 02/10] drm/amdkfd: add renoir kfd device info
Quoted 10 lines · Felix
Quoted 4 lines · Ray
This patch inits renoir kfd device info, so we treat renoir as "dgpu" (bypass iommu v2). Will enable
needs_iommu_devicetill renoir iommu is ready.Signed-off-by Huang Rui <[email protected]>Looks good, but please coordinate with Yong who is changing the structure of the kfd device info table. See his patch "drm/amdkfd: Query kfd device info by CHIP id instead of pci device id" for details. Whoever goes in second will need to rebase and fix the conflict.
Talked with Yong, he has submitted the patch to drm-next. I will rebase the patch.
Thanks,
Ray
Quoted 37 lines
Reviewed-by Felix Kuehling <[email protected]>Quoted 33 lines
--- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)drivers/gpu/drm/amd/amdkfd/kfd_device.c +17
-0@@ -317,6 +317,23 @@ static const struct kfd_device_info vega20_device_info = { .num_sdma_queues_per_engine = 8, }; +static const struct kfd_device_info renoir_device_info = { + .asic_family =CHIP_RENOIR , + .max_pasid_bits =16 , + .max_no_of_hqd =24 , + .doorbell_size =8 , + .ih_ring_entry_size =8 *sizeof (uint32_t ), + .event_interrupt_class = &event_interrupt_class_v9, + .num_of_watch_points =4 , + .mqd_size_aligned =MQD_SIZE_ALIGNED , + .supports_cwsr = true, + .needs_iommu_device = false, + .needs_pci_atomics = false, + .num_sdma_engines =1 , + .num_xgmi_sdma_engines =0 , + .num_sdma_queues_per_engine =2 , +}; +static const struct kfd_device_info navi10_device_info = { .asic_family =CHIP_NAVI10 , .max_pasid_bits =16 ,@@ -452,6 +469,8 @@ static const struct kfd_deviceid supported_devices[] = {
Quoted 8 lines
drivers/gpu/drm/amd/amdkfd/kfd_device.c static const struct kfd_deviceid supported_devices[] = { · line 476
Quoted 8 lines
drivers/gpu/drm/amd/amdkfd/kfd_device.c +2
-0{ 0x66a4, &vega20_device_info }, /* Vega20 */ { 0x66a7, &vega20_device_info }, /* Vega20 */ { 0x66af, &vega20_device_info }, /* Vega20 */ +/* Renoir */ + { 0x1636, &renoir_device_info }, /* Renoir *//* Navi10 */ { 0x7310, &navi10_device_info }, /* Navi10 */ { 0x7312, &navi10_device_info }, /* Navi10 */
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 3/10 drm/amdkfd: enable kfd device queue manager v9 for renoir
In reply to a message not in the archiveRenoir is GFX9, so enable v9 devcie queue manager.
--- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c +1 -0
@@ -1848,6 +1848,7 @@ struct device_queue_manager *device_queue_manager_init(struct kfd_dev *dev)case CHIP_VEGA12 :case CHIP_VEGA20 :case CHIP_RAVEN : +case CHIP_RENOIR :device_queue_manager_init_v9 (&dqm->asic_ops);break ;case CHIP_NAVI10 :
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 4/10 drm/amdkfd: add renoir typs for the workaround of iommu v2
In reply to a message not in the archiveRenoir is the same with Raven, will enable iommu event in future.
--- drivers/gpu/drm/amd/amdkfd/kfd_events.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_events.c +2 -1
@@ -987,7 +987,8 @@ void kfd_signal_iommu_event(struct kfd_dev *dev, unsigned int pasid,* before IOMMU is able to finish processing all the excessive PPRs * triggered due to HW flaws. */ -if (dev->device_info->asic_family !=CHIP_RAVEN ) { +if (dev->device_info->asic_family !=CHIP_RAVEN || + dev->device_info->asic_family !=CHIP_RENOIR ) {mutex_lock (&p->event_mutex);/* Lookup events by type and signal them */
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 5/10 drm/amdkfd: init kfd apertures v9 for renoir
In reply to a message not in the archiveRenoir is GMC v9, so init v9 kfd apertures.
--- drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c +1 -0
@@ -410,6 +410,7 @@ int kfd_init_apertures(struct kfd_process *process)case CHIP_VEGA12 :case CHIP_VEGA20 :case CHIP_RAVEN : +case CHIP_RENOIR :case CHIP_NAVI10 :kfd_init_apertures_v9 (pdd, id);break ;
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 6/10 drm/amdkfd: init kernel queue for renoir
In reply to a message not in the archiveRenoir is GFX v9, so init v9 kernel queue.
--- drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c +1 -0
@@ -364,6 +364,7 @@ struct kernel_queue *kernel_queue_init(struct kfd_dev *dev,case CHIP_VEGA12 :case CHIP_VEGA20 :case CHIP_RAVEN : +case CHIP_RENOIR :kernel_queue_init_v9 (&kq->ops_asic_specific);break ;case CHIP_NAVI10 :
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 7/10 drm/amdkfd: add package manager for renoir
In reply to a message not in the archiveRenoir use GFX v9, so adds v9 package manager.
--- drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c +1 -0
@@ -235,6 +235,7 @@ int pm_init(struct packet_manager *pm, struct device_queue_manager *dqm)case CHIP_VEGA12 :case CHIP_VEGA20 :case CHIP_RAVEN : +case CHIP_RENOIR : pm->pmf = &kfd_v9_pm_funcs;break ;case CHIP_NAVI10 :
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 8/10 drm/amdkfd: add renoir kfd topology
In reply to a message not in the archiveThis patch adds renoir kfd topology which is the same with Raven.
--- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/kfd_topology.c +1 -0
@@ -1417,6 +1417,7 @@ int kfd_topology_add_device(struct kfd_dev *gpu)case CHIP_VEGA12 :case CHIP_VEGA20 :case CHIP_RAVEN : +case CHIP_RENOIR :case CHIP_NAVI10 : dev->node_props.capability |= ((HSA_CAP_DOORBELL_TYPE_2_0 << HSA_CAP_DOORBELL_TYPE_TOTALBITS_SHIFT) &
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 9/10 drm/amdgpu: disable gfxoff while use no H/W scheduling policy
In reply to a message not in the archiveWhile gfxoff is enabled, the mmVM_XXX registers will be 0xfffffff while the GFX is in "off" state. KFD queue creattion doesn't use ring based method, so it will trigger a VM fault.
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu.h +1 -0
@@ -167,6 +167,7 @@ extern int amdgpu_async_gfx_ring;extern int amdgpu_mcbp;extern int amdgpu_discovery;extern int amdgpu_mes; +extern int sched_policy;#ifdef CONFIG_DRM_AMDGPU_SI extern int amdgpu_si_support;
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
@@ -1576,7 +1576,7 @@ static int amdgpu_device_ip_early_init(struct amdgpu_device *adev) } adev->pm.pp_feature = amdgpu_pp_feature_mask; -if (amdgpu_sriov_vf (adev)) +if (amdgpu_sriov_vf (adev) || sched_policy ==KFD_SCHED_POLICY_NO_HWS ) adev->pm.pp_feature &= ~PP_GFXOFF_MASK ;for (i =0 ; i < adev->num_ip_blocks; i++) {
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 10/10 drm/amdkfd: enable renoir while device probes
In reply to a message not in the archiveThis patch is to add asic flag to enable device probe during kfd init.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c +1 -0
@@ -90,6 +90,7 @@ void amdgpu_amdkfd_device_probe(struct amdgpu_device *adev)case CHIP_VEGA12 :case CHIP_VEGA20 :case CHIP_RAVEN : +case CHIP_RENOIR :#if LINUX_VERSION_CODE <KERNEL_VERSION (4 ,16 ,0 ) && defined(BUILD_AS_DKMS )if (adev->asic_type ==CHIP_RAVEN ) {dev_dbg (adev->dev,"DKMS installed kfd does not support Raven for kernel < 4.16\n" );
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Kuehling, Felix
Reviewed-by Felix KuehlingPatches 2-10 are
See my comments on patches 1 and 2 in separate emails. In patch 1 it looks like you're based on an outdated version of the branch or a different branch altogether. Please check that your series is based on the latest amd-staging-drm-next.
Regards,
Felix
Quoted 19 lines · Ray
Hi all,
These patch set provides the kfd support for ROCm stack on Renoir APU.
Thanks,
RayHuang Rui (10):
drm/amdkfd: add renoir cache info for CRAT drm/amdkfd: add renoir kfd device info
drm/amdkfd: enable kfd device queue manager v9 for renoir drm/amdkfd: add renoir typs for the workaround of iommu v2 drm/amdkfd: init kfd apertures v9 for renoir drm/amdkfd: init kernel queue for renoir drm/amdkfd: add package manager for renoir drm/amdkfd: add renoir kfd topology
drm/amdgpu: disable gfxoff while use no H/W scheduling policy drm/amdkfd: enable renoir while device probes
Quoted 13 lines
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 ++++ drivers/gpu/drm/amd/amdkfd/kfd_device.c | 19 +++++++++++++++++++ drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_events.c | 3 ++- drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 + 11 files changed, 33 insertions(+), 2 deletions(-)
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 9808c5da-a5da-0fb1-fe1e-257baa5de8f9-5C7GfCeVMHo@public.gmane.org
Quoted 9 lines · Felix
Patches 2-10 are
Reviewed-by Felix Kuehling <[email protected]>See my comments on patches 1 and 2 in separate emails. In patch 1 it looks like you're based on an outdated version of the branch or a different branch altogether. Please check that your series is based on the latest amd-staging-drm-next.
I will rebase them to drm-next before submit.
Thanks,
Ray
Quoted 36 lines
Regards,
FelixQuoted 32 lines · Ray
Hi all,
These patch set provides the kfd support for ROCm stack on Renoir APU.
Thanks,
RayHuang Rui (10):
drm/amdkfd: add renoir cache info for CRAT drm/amdkfd: add renoir kfd device info
drm/amdkfd: enable kfd device queue manager v9 for renoir drm/amdkfd: add renoir typs for the workaround of iommu v2 drm/amdkfd: init kfd apertures v9 for renoir drm/amdkfd: init kernel queue for renoir drm/amdkfd: add package manager for renoir drm/amdkfd: add renoir kfd topology
drm/amdgpu: disable gfxoff while use no H/W scheduling policy drm/amdkfd: enable renoir while device probesdrivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 ++++ drivers/gpu/drm/amd/amdkfd/kfd_device.c | 19 +++++++++++++++++++ drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_events.c | 3 ++- drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 + 11 files changed, 33 insertions(+), 2 deletions(-)
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx