Skip to contentSkip to conversation

scsi: lpfc: Convert existing %pf users to %ps

PATCH Applied Sakari Ailus 4 participants 5 messages Sep 4, 2019 – Sep 9, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: lpfc: Convert existing %pf users to %ps

Convert the remaining %pf users to %ps to prepare for the removal of the old %pf conversion specifier support.

Fixes 323506644972 ("scsi: lpfc: Migrate to %px and %pf in kernel print calls")
---
 drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ++--
 drivers/scsi/lpfc/lpfc_sli.c     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/lpfc/lpfc_hbadisc.c +2 -2
index e7463d561f305..749286acdc173 100644
@@ -6051,7 +6051,7 @@ __lpfc_find_node(struct lpfc_vport *vport, node_filter filter, void *param)
 	list_for_each_entry(ndlp, &vport->fc_nodes, nlp_listp) {
 		if (filter(ndlp, param)) {
 			lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE,
-					 "3185 FIND node filter %pf DID "
+					 "3185 FIND node filter %ps DID "
 					 "ndlp x%px did x%x flg x%x st x%x "
 					 "xri x%x type x%x rpi x%x\n",
 					 filter, ndlp, ndlp->nlp_DID,
@@ -6062,7 +6062,7 @@ __lpfc_find_node(struct lpfc_vport *vport, node_filter filter, void *param)
 		}
 	}
 	lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE,
-			 "3186 FIND node filter %pf NOT FOUND.\n", filter);
+			 "3186 FIND node filter %ps NOT FOUND.\n", filter);
 	return NULL;
 }
 
drivers/scsi/lpfc/lpfc_sli.c +1 -1
index bb5705267c395..2ff0879a95126 100644
@@ -2712,7 +2712,7 @@ lpfc_sli_handle_mb_event(struct lpfc_hba *phba)
 
 		/* Mailbox cmd <cmd> Cmpl <cmpl> */
 		lpfc_printf_log(phba, KERN_INFO, LOG_MBOX | LOG_SLI,
-				"(%d):0307 Mailbox cmd x%x (x%x/x%x) Cmpl %pf "
+				"(%d):0307 Mailbox cmd x%x (x%x/x%x) Cmpl %ps "
 				"Data: x%x x%x x%x x%x x%x x%x x%x x%x x%x "
 				"x%x x%x x%x\n",
 				pmb->vport ? pmb->vport->vpi : 0,
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Sakari Ailus

Convert the remaining %pf users to %ps to prepare for the removal of the old %pf conversion specifier support.

FWIW,

Quoted 45 lines
Fixes 323506644972 ("scsi: lpfc: Migrate to %px and %pf in kernel print calls")
---
 drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ++--
 drivers/scsi/lpfc/lpfc_sli.c     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/lpfc/lpfc_hbadisc.c +2 -2
index e7463d561f305..749286acdc173 100644
@@ -6051,7 +6051,7 @@ __lpfc_find_node(struct lpfc_vport *vport, node_filter filter, void *param)
 	list_for_each_entry(ndlp, &vport->fc_nodes, nlp_listp) {
 		if (filter(ndlp, param)) {
 			lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE,
-					 "3185 FIND node filter %pf DID "
+					 "3185 FIND node filter %ps DID "
 					 "ndlp x%px did x%x flg x%x st x%x "
 					 "xri x%x type x%x rpi x%x\n",
 					 filter, ndlp, ndlp->nlp_DID,
@@ -6062,7 +6062,7 @@ __lpfc_find_node(struct lpfc_vport *vport, node_filter filter, void *param)
 		}
 	}
 	lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE,
-			 "3186 FIND node filter %pf NOT FOUND.\n", filter);
+			 "3186 FIND node filter %ps NOT FOUND.\n", filter);
 	return NULL;
 }
 
drivers/scsi/lpfc/lpfc_sli.c +1 -1
index bb5705267c395..2ff0879a95126 100644
@@ -2712,7 +2712,7 @@ lpfc_sli_handle_mb_event(struct lpfc_hba *phba)
 
 		/* Mailbox cmd <cmd> Cmpl <cmpl> */
 		lpfc_printf_log(phba, KERN_INFO, LOG_MBOX | LOG_SLI,
-				"(%d):0307 Mailbox cmd x%x (x%x/x%x) Cmpl %pf "
+				"(%d):0307 Mailbox cmd x%x (x%x/x%x) Cmpl %ps "
 				"Data: x%x x%x x%x x%x x%x x%x x%x x%x x%x "
 				"x%x x%x x%x\n",
 				pmb->vport ? pmb->vport->vpi : 0,
Signature · 1 line
2.20.1
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
In reply to Sakari Ailus
Quoted 11 lines · Sakari Ailus

Convert the remaining %pf users to %ps to prepare for the removal of the old %pf conversion specifier support.

Fixes 323506644972 ("scsi: lpfc: Migrate to %px and %pf in kernel print calls")
---
  drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ++--
  drivers/scsi/lpfc/lpfc_sli.c     | 2 +-
  2 files changed, 3 insertions(+), 3 deletions(-)

Reviewed by: James Smart <[email protected]>

-- james

#3 lore raw
In reply to Sakari Ailus

Sakari,

Quoted 2 lines

Convert the remaining %pf users to %ps to prepare for the removal of the old %pf conversion specifier support.

Applied to 5.4/scsi-queue, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#4 lore raw
Quoted 7 lines · Martin K. Petersen

Sakari,

Quoted 2 lines

Convert the remaining %pf users to %ps to prepare for the removal of the old %pf conversion specifier support.

Applied to 5.4/scsi-queue, thanks!

Thanks, Martin!

Signature · 2 lines
Sakari Ailus
[email protected]