ARM: dts: realtek: Add support for Realtek RTD16XX evaluation board
PATCH 1/1 ARM: dts: realtek: Add support for Realtek RTD16XX evaluation board
From: "james.tai" <[email protected]>
This patch adds a generic devicetree board file and a dtsi for Realtek RTD16XX platform.
--- arch/arm/boot/dts/Makefile | 2 + arch/arm/boot/dts/rtd1619-mjolnir.dts | 34 +++++++++ arch/arm/boot/dts/rtd16xx.dtsi | 101 ++++++++++++++++++++++++++ 3 files changed, 137 insertions(+) create mode 100644 arch/arm/boot/dts/rtd1619-mjolnir.dts create mode 100644 arch/arm/boot/dts/rtd16xx.dtsi
arch/arm/boot/dts/Makefile +2 -0
@@ -1286,3 +1286,5 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-opp-zaius.dtb \ aspeed-bmc-portwell-neptune.dtb \ aspeed-bmc-quanta-q71l.dtb +dtb-$(CONFIG_ARCH_RTD16XX) += \ + rtd1619-mjolnir.dtb
arch/arm/boot/dts/rtd1619-mjolnir.dts new file +34 -0
@@ -0,0 +1,34 @@ +// SPDX-License-Identifier: GPL-2.0-only + +/* + * Copyright (c) 2019 Realtek Semiconductor Corp. + */ + +/dts-v1/; + +#include "rtd16xx.dtsi" + +/ { + model= "Realtek Mjolnir Evaluation Board"; + model_hex= <0x00000653>; + + chosen { + bootargs = "console=ttyS0,115200 earlycon"; + }; + + memory@0 { + device_type = "memory"; + reg = <0x0 0x0 0x0 0x80000000>; + }; + + uart0: serial0@98007800 { + compatible = "snps,dw-apb-uart"; + reg = <0x0 0x98007800 0x0 0x400>, + <0x0 0x98007000 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + interrupts = <0 68 4>; + clock-frequency = <27000000>; + status = "okay"; + }; +};
arch/arm/boot/dts/rtd16xx.dtsi new file +101 -0
101 lines not on this page · raw message
Signature · 1 line
2.17.1
Arnd Bergmann
maintainerarch/arm/boot/dts/rtd1619-mjolnir.dts line 13
Quoted 4 lines · On Thu, Sep 5, 2019 at 10:10 AM <[email protected]> wrote:
arch/arm/boot/dts/rtd1619-mjolnir.dts new file +4
-0+ +/ { + model= "Realtek Mjolnir Evaluation Board"; + model_hex= <0x00000653>;
The 'mode_hex' property is rather unusual, please drop that for now.
Quoted 9 lines
arch/arm/boot/dts/rtd1619-mjolnir.dts new file +9
-0+ chosen { + bootargs = "console=ttyS0,115200 earlycon"; + }; + + memory@0 { + device_type = "memory"; + reg = <0x0 0x0 0x0 0x80000000>; + }; +
arch/arm/boot/dts/rtd1619-mjolnir.dts line 33
Quoted 10 lines
arch/arm/boot/dts/rtd1619-mjolnir.dts new file +10
-0+ uart0: serial0@98007800 { + compatible = "snps,dw-apb-uart"; + reg = <0x0 0x98007800 0x0 0x400>, + <0x0 0x98007000 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>; + interrupts = <0 68 4>; + clock-frequency = <27000000>; + status = "okay"; + };
This looks like an on-chip uart. Please move that into rtd16xx.dtsi instead, and just mark it as 'status="disabled"' there if there are multiple uarts (and add the other ones as well), then enable it for the board here.
There should also be an 'aliases'. You normally also want to add
aliases {
serial0 = &uart0;
};chosen {
stdout-path= "serial0:115200n8"
};in the board file to make earlycon work right.
Arnd
Quoted 11 lines
Subject: Re: [PATCH] ARM: dts: realtek: Add support for Realtek RTD16XX evaluation board
arch/arm/boot/dts/rtd1619-mjolnir.dts line 13
Quoted 4 lines · On Thu, Sep 5, 2019 at 10:10 AM <[email protected]> wrote:
arch/arm/boot/dts/rtd1619-mjolnir.dts new file +4
-0+ +/ { + model= "Realtek Mjolnir Evaluation Board"; + model_hex= <0x00000653>;The '
mode_hex' property is rather unusual, please drop that for now.
I will remove the 'mode_hex' property in new version patch.
Quoted 16 lines
Quoted 16 lines
arch/arm/boot/dts/rtd1619-mjolnir.dts new file +15
-0+ chosen { + bootargs = "console=ttyS0,115200 earlycon"; + }; + + memory@0 { + device_type = "memory"; + reg = <0x0 0x0 0x0 0x80000000>; + }; + + uart0: serial0@98007800 { + compatible = "snps,dw-apb-uart"; + reg = <0x0 0x98007800 0x0 0x400>, + <0x0 0x98007000 0x0 0x100>; + reg-shift = <2>; + reg-io-width = <4>;
Quoted 8 lines
arch/arm/boot/dts/rtd1619-mjolnir.dts line 33
Quoted 4 lines
arch/arm/boot/dts/rtd1619-mjolnir.dts new file +4
-0+ interrupts = <0 68 4>; + clock-frequency = <27000000>; + status = "okay"; + };This looks like an on-chip uart. Please move that into
rtd16xx.dtsiinstead, and just mark it as 'status="disabled"' there if there are multiple uarts (and add the other ones as well), then enable it for the board here.
Yes. It is on-chip uart.
I will move uart0 into 'rtd16xx.dtsi' and mark it as 'status="disabled" '.
Quoted 1 line
There should also be an 'aliases'. You normally also want to add
I will add aliases in new version patch.
Quoted 9 lines
aliases { serial0 = &uart0; };chosen { stdout-path= "serial0:115200n8" };in the board file to make earlycon work right.
OK, I understand.
Quoted 3 lines
Arnd
------Please consider the environment before printing this e-mail.