Skip to contentSkip to conversation

i2c: muxes: pca9541: use BIT() macro

PATCH Superseded Saiyam Doshi 2 participants 4 messages Sep 5, 2019

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: muxes: pca9541: use BIT() macro

Use bit mask macro BIT() for definition where appropriate.

---
 drivers/i2c/muxes/i2c-mux-pca9541.c | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)
drivers/i2c/muxes/i2c-mux-pca9541.c +14 -14
index 9e75d6b9140b..bd4cf8341a06 100644
@@ -43,20 +43,20 @@
 #define PCA9541_CONTROL		0x01
 #define PCA9541_ISTAT		0x02
 
-#define PCA9541_CTL_MYBUS	(1 << 0)
-#define PCA9541_CTL_NMYBUS	(1 << 1)
-#define PCA9541_CTL_BUSON	(1 << 2)
-#define PCA9541_CTL_NBUSON	(1 << 3)
-#define PCA9541_CTL_BUSINIT	(1 << 4)
-#define PCA9541_CTL_TESTON	(1 << 6)
-#define PCA9541_CTL_NTESTON	(1 << 7)
-
-#define PCA9541_ISTAT_INTIN	(1 << 0)
-#define PCA9541_ISTAT_BUSINIT	(1 << 1)
-#define PCA9541_ISTAT_BUSOK	(1 << 2)
-#define PCA9541_ISTAT_BUSLOST	(1 << 3)
-#define PCA9541_ISTAT_MYTEST	(1 << 6)
-#define PCA9541_ISTAT_NMYTEST	(1 << 7)
+#define PCA9541_CTL_MYBUS	BIT(0)
+#define PCA9541_CTL_NMYBUS	BIT(1)
+#define PCA9541_CTL_BUSON	BIT(2)
+#define PCA9541_CTL_NBUSON	BIT(3)
+#define PCA9541_CTL_BUSINIT	BIT(4)
+#define PCA9541_CTL_TESTON	BIT(6)
+#define PCA9541_CTL_NTESTON	BIT(7)
+
+#define PCA9541_ISTAT_INTIN	BIT(0)
+#define PCA9541_ISTAT_BUSINIT	BIT(1)
+#define PCA9541_ISTAT_BUSOK	BIT(2)
+#define PCA9541_ISTAT_BUSLOST	BIT(3)
+#define PCA9541_ISTAT_MYTEST	BIT(6)
+#define PCA9541_ISTAT_NMYTEST	BIT(7)
 
 #define BUSON		(PCA9541_CTL_BUSON | PCA9541_CTL_NBUSON)
 #define MYBUS		(PCA9541_CTL_MYBUS | PCA9541_CTL_NMYBUS)
Signature · 1 line
2.20.1
#1 lore raw
Quoted 3 lines · Saiyam Doshi

Use bit mask macro BIT() for definition where appropriate.

linux/bitops.h should be included when using BIT().

Guenter

Quoted 44 lines
---
  drivers/i2c/muxes/i2c-mux-pca9541.c | 28 ++++++++++++++--------------
  1 file changed, 14 insertions(+), 14 deletions(-)
drivers/i2c/muxes/i2c-mux-pca9541.c +14 -14
index 9e75d6b9140b..bd4cf8341a06 100644
@@ -43,20 +43,20 @@
  #define PCA9541_CONTROL		0x01
  #define PCA9541_ISTAT		0x02
 
-#define PCA9541_CTL_MYBUS	(1 << 0)
-#define PCA9541_CTL_NMYBUS	(1 << 1)
-#define PCA9541_CTL_BUSON	(1 << 2)
-#define PCA9541_CTL_NBUSON	(1 << 3)
-#define PCA9541_CTL_BUSINIT	(1 << 4)
-#define PCA9541_CTL_TESTON	(1 << 6)
-#define PCA9541_CTL_NTESTON	(1 << 7)
-
-#define PCA9541_ISTAT_INTIN	(1 << 0)
-#define PCA9541_ISTAT_BUSINIT	(1 << 1)
-#define PCA9541_ISTAT_BUSOK	(1 << 2)
-#define PCA9541_ISTAT_BUSLOST	(1 << 3)
-#define PCA9541_ISTAT_MYTEST	(1 << 6)
-#define PCA9541_ISTAT_NMYTEST	(1 << 7)
+#define PCA9541_CTL_MYBUS	BIT(0)
+#define PCA9541_CTL_NMYBUS	BIT(1)
+#define PCA9541_CTL_BUSON	BIT(2)
+#define PCA9541_CTL_NBUSON	BIT(3)
+#define PCA9541_CTL_BUSINIT	BIT(4)
+#define PCA9541_CTL_TESTON	BIT(6)
+#define PCA9541_CTL_NTESTON	BIT(7)
+
+#define PCA9541_ISTAT_INTIN	BIT(0)
+#define PCA9541_ISTAT_BUSINIT	BIT(1)
+#define PCA9541_ISTAT_BUSOK	BIT(2)
+#define PCA9541_ISTAT_BUSLOST	BIT(3)
+#define PCA9541_ISTAT_MYTEST	BIT(6)
+#define PCA9541_ISTAT_NMYTEST	BIT(7)
 
  #define BUSON		(PCA9541_CTL_BUSON | PCA9541_CTL_NBUSON)
  #define MYBUS		(PCA9541_CTL_MYBUS | PCA9541_CTL_NMYBUS)
#2 lore raw
Quoted 1 line · Guenter Roeck

linux/bitops.h should be included when using BIT().

It's included from linux/i2c-mux.h and it compiled successfully. But if it's needed I'll update the patch and resend.

Just a question - What is the best practice in such case? Should the header included explicitly?

-Saiyam

#3 lore raw
Quoted 9 lines · Saiyam Doshi
Quoted 1 line · Guenter Roeck

linux/bitops.h should be included when using BIT().

It's included from linux/i2c-mux.h and it compiled successfully. But if it's needed I'll update the patch and resend.

Just a question - What is the best practice in such case? Should the header included explicitly?

process/submit-checklist.rst says, as very first point:

1) If you use a facility then #include the file that defines/declares that facility. Don't depend on other header files pulling in ones that you use.

Guenter