drm/amdgpu: Fix KFD-related kernel oops on Hawaii
Subsystems (2)
PATCH 1/1 drm/amdgpu: Fix KFD-related kernel oops on Hawaii
Hawaii needs to flush caches explicitly, submitting an IB in a user VMID from kernel mode. There is no s_fence in this case.
Fixes eb3961a57424 ("drm/amdgpu: remove fence context from the job")
Signed-off-by Felix Kuehling <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c +2 -1
@@ -141,7 +141,8 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs,/* ring tests don't use a job */ if (job) { vm = job->vm; - fence_ctx = job->base.s_fence->scheduled.context; + fence_ctx = job->base.s_fence ? + job->base.s_fence->scheduled.context :0 ; }else { vm =NULL ; fence_ctx =0 ;
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20190905232915.5537-1-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org
Christian König
Reviewed-byAm 06.09.19 um 01:29 schrieb Kuehling, Felix:
Quoted 5 lines
Hawaii needs to flush caches explicitly, submitting an IB in a user VMID from kernel mode. There is no
s_fencein this case.Fixes eb3961a57424 ("drm/amdgpu: remove fence context from the job")Signed-off-by Felix Kuehling <[email protected]>
Reviewed-by Christian König <[email protected]>
Quoted 9 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs, · line 148
Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c +2
-1@@ -141,7 +141,8 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs,/* ring tests don't use a job */ if (job) { vm = job->vm; - fence_ctx = job->base.s_fence->scheduled.context; + fence_ctx = job->base.s_fence ? + job->base.s_fence->scheduled.context :0 ; }else { vm =NULL ; fence_ctx =0 ;
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx