platform/x86: ISST: Allow additional TRL MSRs
Subsystems (2)
Srinivas Pandruvada
maintainerPATCH 1/2 platform/x86: ISST: Allow additional TRL MSRs
Additional Turbo Ratio Limit (TRL) MSRs are required to get bucket vs core count relationship. So add them to the list of allowed MSRs.
--- drivers/platform/x86/intel_speed_select_if/isst_if_common.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/platform/x86/intel_speed_select_if/isst_if_common.c +2 -0
@@ -29,6 +29,8 @@ static struct isst_if_cmd_cb punit_callbacks[ISST_IF_DEV_MAX];static int punit_msr_white_list[] = {MSR_TURBO_RATIO_LIMIT ,MSR_CONFIG_TDP_CONTROL , +MSR_TURBO_RATIO_LIMIT1 , +MSR_TURBO_RATIO_LIMIT2 , };struct isst_valid_cmd_ranges {
Signature · 1 line
2.17.2
Srinivas Pandruvada
maintainerPATCH 2/2 tools/power/x86/intel-speed-select: Display core count for bucket
Read the bucket and core count relationship via MSR and display when displaying turbo ratio limits.
--- .../power/x86/intel-speed-select/isst-core.c | 22 +++++++++++++++++++ .../x86/intel-speed-select/isst-display.c | 6 ++--- tools/power/x86/intel-speed-select/isst.h | 1 + 3 files changed, 26 insertions(+), 3 deletions(-)
tools/power/x86/intel-speed-select/isst-core.c +22 -0
@@ -188,6 +188,24 @@ int isst_get_get_trl(int cpu, int level, int avx_level, int *trl)return 0 ; } +int isst_get_trl_bucket_info (int cpu,unsigned long long *buckets_info) +{ +int ret; + +debug_printf ("cpu:%d bucket info via MSR\n" , cpu); + + *buckets_info =0 ; + + ret =isst_send_msr_command (cpu,0x1ae ,0 , buckets_info); +if (ret) +return ret; + +debug_printf ("cpu:%d bucket info via MSR successful 0x%llx\n" , cpu, + *buckets_info); + +return 0 ; +} +int isst_set_tdp_level_msr (int cpu,int tdp_level) {int ret;
@@ -563,6 +581,10 @@ int isst_get_process_ctdp(int cpu, int tdp_level, struct isst_pkg_ctdp *pkg_dev)if (ret)return ret; + ret =isst_get_trl_bucket_info (cpu, &ctdp_level->buckets_info); +if (ret) +return ret; + ret =isst_get_get_trl (cpu, i,0 , ctdp_level->trl_sse_active_cores);if (ret)
tools/power/x86/intel-speed-select/isst-display.c +3 -3
@@ -372,7 +372,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level,format_and_print (outf, base_level +5 , header,NULL );snprintf (header,sizeof (header),"core-count" ); -snprintf (value,sizeof (value),"%d" , j); +snprintf (value,sizeof (value),"%llu" , (ctdp_level->buckets_info >> (j *8 )) &0xff );format_and_print (outf, base_level +6 , header, value); snprintf(header, sizeof(header),
@@ -389,7 +389,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level,format_and_print (outf, base_level +5 , header,NULL );snprintf (header,sizeof (header),"core-count" ); -snprintf (value,sizeof (value),"%d" , j); +snprintf (value,sizeof (value),"%llu" , (ctdp_level->buckets_info >> (j *8 )) &0xff );format_and_print (outf, base_level +6 , header, value); snprintf(header, sizeof(header),
@@ -407,7 +407,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level,format_and_print (outf, base_level +5 , header,NULL );snprintf (header,sizeof (header),"core-count" ); -snprintf (value,sizeof (value),"%d" , j); +snprintf (value,sizeof (value),"%llu" , (ctdp_level->buckets_info >> (j *8 )) &0xff );format_and_print (outf, base_level +6 , header, value); snprintf(header, sizeof(header),
tools/power/x86/intel-speed-select/isst.h +1 -0
@@ -134,6 +134,7 @@ struct isst_pkg_ctdp_level_info {size_t core_cpumask_size;cpu_set_t *core_cpumask;int cpu_count; +unsigned long long buckets_info;int trl_sse_active_cores[ISST_TRL_MAX_ACTIVE_CORES ];int trl_avx_active_cores[ISST_TRL_MAX_ACTIVE_CORES ];int trl_avx_512_active_cores[ISST_TRL_MAX_ACTIVE_CORES ];
Signature · 1 line
2.17.2
Re: [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket
Quoted 17 lines · Srinivas Pandruvada
Read the bucket and core count relationship via MSR and display when displaying turbo ratio limits.
Signed-off-by Srinivas Pandruvada <[email protected]>--- .../power/x86/intel-speed-select/isst-core.c | 22 +++++++++++++++++++ .../x86/intel-speed-select/isst-display.c | 6 ++--- tools/power/x86/intel-speed-select/isst.h | 1 + 3 files changed, 26 insertions(+), 3 deletions(-)tools/power/x86/intel-speed-select/isst-core.c +0
-0@@ -188,6 +188,24 @@ int isst_get_get_trl(int cpu, int level, int avx_level, int *trl)return 0 ; }
tools/power/x86/intel-speed-select/isst-core.c int isst_get_get_trl(int cpu, int level, int avx_level, int *trl) · line 199
Quoted 10 lines
tools/power/x86/intel-speed-select/isst-core.c +9
-0+int isst_get_trl_bucket_info (int cpu,unsigned long long *buckets_info) +{ +int ret; + +debug_printf ("cpu:%d bucket info via MSR\n" , cpu); + + *buckets_info =0 ; + + ret =isst_send_msr_command (cpu,0x1ae ,0 , buckets_info);
^^^ you can get rid of the magic number 0x1ae by doing (sorry for the cut-and-paste)
tools/power/x86/intel-speed-select/Makefile +2 -0
@@ -15,6 +15,8 @@ endif MAKEFLAGS += -r override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include +override CFLAGS += -I../../../include +override CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"' ALL_TARGETS := intel-speed-select ALL_PROGRAMS := $(patsubst %,$(OUTPUT)%,$(ALL_TARGETS))
tools/power/x86/intel-speed-select/isst.h +1 -0
@@ -7,6 +7,7 @@#ifndef _ISST_H_#define _ISST_H_ +#include MSRHEADER #include <stdio.h> #include <unistd.h> #include <sys/types.h>
and replacing the MSR addresses with the names of the MSRs.
tools/power/x86/intel-speed-select/isst-core.c int isst_get_get_trl(int cpu, int level, int avx_level, int *trl) · line 202
Quoted 3 lines
tools/power/x86/intel-speed-select/isst-core.c +3
-0+if (ret) +return ret; +
As I've been looking at this code I have been wondering why didn't you just use the standard /dev/cpu/X/msr interface that other x86 power utilities (turbostat, x86_energy_perf_policy) use? Implementing msr_read() is trivial (warning untested and uncompiled code)
static void read_msr(int cpu, int offset, unsigned long long *msr)
{
ssize_t retval;
char pathname[32];
int fd;
sprintf(pathname, "/dev/cpu/%d/msr", cpu);
fd = open(pathname, O_RDONLY);
if (fd < 0)
err(-1, "%s open failed", pathname);
retval = pread(fd, msr, sizeof(*msr), offset);
if (retval != (sizeof *msr))
err(-1, "%s failed: cpu %d msr offset 0x%llx\n", __func__, cpu,
(unsigned long long)offset);
close(fd);
}and would result in a significant reduction in code in the driver and the tool IMO. write_msr() is equally trivial.
P.
Quoted 64 lines
tools/power/x86/intel-speed-select/isst-core.c +10
-0+debug_printf ("cpu:%d bucket info via MSR successful 0x%llx\n" , cpu, + *buckets_info); + +return 0 ; +} +int isst_set_tdp_level_msr (int cpu,int tdp_level) {int ret;@@ -563,6 +581,10 @@ int isst_get_process_ctdp(int cpu, int tdp_level, struct isst_pkg_ctdp *pkg_dev)if (ret)return ret; + ret =isst_get_trl_bucket_info (cpu, &ctdp_level->buckets_info); +if (ret) +return ret; + ret =isst_get_get_trl (cpu, i,0 , ctdp_level->trl_sse_active_cores);if (ret)tools/power/x86/intel-speed-select/isst-display.c +3
-3@@ -372,7 +372,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level,format_and_print (outf, base_level +5 , header,NULL );snprintf (header,sizeof (header),"core-count" ); -snprintf (value,sizeof (value),"%d" , j); +snprintf (value,sizeof (value),"%llu" , (ctdp_level->buckets_info >> (j *8 )) &0xff );format_and_print (outf, base_level +6 , header, value); snprintf(header, sizeof(header),@@ -389,7 +389,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level,format_and_print (outf, base_level +5 , header,NULL );snprintf (header,sizeof (header),"core-count" ); -snprintf (value,sizeof (value),"%d" , j); +snprintf (value,sizeof (value),"%llu" , (ctdp_level->buckets_info >> (j *8 )) &0xff );format_and_print (outf, base_level +6 , header, value); snprintf(header, sizeof(header),@@ -407,7 +407,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level,format_and_print (outf, base_level +5 , header,NULL );snprintf (header,sizeof (header),"core-count" ); -snprintf (value,sizeof (value),"%d" , j); +snprintf (value,sizeof (value),"%llu" , (ctdp_level->buckets_info >> (j *8 )) &0xff );format_and_print (outf, base_level +6 , header, value); snprintf(header, sizeof(header),tools/power/x86/intel-speed-select/isst.h +1
-0@@ -134,6 +134,7 @@ struct isst_pkg_ctdp_level_info {size_t core_cpumask_size;cpu_set_t *core_cpumask;int cpu_count; +unsigned long long buckets_info;int trl_sse_active_cores[ISST_TRL_MAX_ACTIVE_CORES ];int trl_avx_active_cores[ISST_TRL_MAX_ACTIVE_CORES ];int trl_avx_512_active_cores[ISST_TRL_MAX_ACTIVE_CORES ];
Re: [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket
Quoted 13 lines · Prarit Bhargava
Review
Quoted 4 lines · Srinivas Pandruvada
Read the bucket and core count relationship via MSR and display when displaying turbo ratio limits.
(quoted diff) +1
-0+ ret = isst_send_msr_command(cpu, 0x1ae, 0, buckets_info);^^^ you can get rid of the magic number
0x1aeby doing (sorry for the cut-and-paste)tools/power/x86/intel-speed-select/Makefile +0
-0
tools/power/x86/intel-speed-select/Makefile endif · line 20
Quoted 6 lines
tools/power/x86/intel-speed-select/Makefile +2
-0@@ -15,6 +15,8 @@ endif MAKEFLAGS += -r override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include +override CFLAGS += -I../../../include +override CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"'
I guess it can be done in more neat way.
Quoted 4 lines
As I've been looking at this code I have been wondering why didn't you just use the standard
/dev/cpu/X/msrinterface that other x86 power utilities (turbostat,x86_energy_perf_policy) use? Implementingmsr_read()is trivial (warning untested and uncompiled code)
Actually good point!
Signature · 2 lines
With Best Regards, Andy Shevchenko
Srinivas Pandruvada
maintainerRe: [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket
Quoted 17 lines · Andy Shevchenko
Quoted 16 lines · Prarit Bhargava
Review
Quoted 3 lines · Srinivas Pandruvada
Read the bucket and core count relationship via MSR and display when displaying turbo ratio limits.
(quoted diff) +1
-0+ ret = isst_send_msr_command(cpu, 0x1ae, 0, buckets_info);^^^ you can get rid of the magic number
0x1aeby doing (sorry for the cut-and-paste)tools/power/x86/intel-speed-select/Makefile +0
-0@@ -15,6 +15,8 @@ endif MAKEFLAGS += -r
Quoted 4 lines
tools/power/x86/intel-speed-select/Makefile endif
Quoted 4 lines
tools/power/x86/intel-speed-select/Makefile +2
-1override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include +override CFLAGS += -I../../../include +override CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"'
No, we can't use msr_index.
Quoted 10 lines
I guess it can be done in more neat way.
Quoted 7 lines
As I've been looking at this code I have been wondering why didn't you just use
the standard/dev/cpu/X/msrinterface that other x86 power utilities (turbostat,x86_energy_perf_policy) use? Implementingmsr_read()is trivial (warning
untested and uncompiled code)
No. We can't. The MSR interface is disabled on several distribution and platforms with secured boot. So some special MSRs are only allowed via this IOCTL interface.
Thanks,
Srinivas
Quoted 3 lines
Actually good point!
Srinivas Pandruvada
maintainerRe: [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket
Quoted 19 lines · Srinivas Pandruvada
Quoted 18 lines · Andy Shevchenko
Quoted 17 lines · Prarit Bhargava
Quoted 4 lines · Srinivas Pandruvada
Read the bucket and core count relationship via MSR and display when displaying turbo ratio limits.
(quoted diff) +1
-0+ ret = isst_send_msr_command(cpu, 0x1ae, 0,
buckets_info);^^^ you can get rid of the magic number
0x1aeby doing (sorry for the cut-and-paste)tools/power/x86/intel-speed-select/Makefile +0
-0@@ -15,6 +15,8 @@ endif MAKEFLAGS += -r
Quoted 6 lines
Quoted 4 lines
tools/power/x86/intel-speed-select/Makefile endif
Quoted 4 lines
tools/power/x86/intel-speed-select/Makefile +2
-1override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include +override CFLAGS += -I../../../include +override CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"'No, we can't use
msr_index.
This comment was meant for use of /dev/cpu/X/msr not msr_index. I didn't want to bring in dependency on msr-index.h for couple of 2 MSRs and the names in msr-index.h doesn't really reflect the actual processing, they are doing. For example MSR_TURBO_RATIO_LIMIT1 for 0x1ae. The definition of 0x1AE is different on cpu model 0x55 and beyond.
Quoted 26 lines
Quoted 12 lines
I guess it can be done in more neat way.
Quoted 8 lines
As I've been looking at this code I have been wondering why didn't
you just use
the standard/dev/cpu/X/msrinterface that other x86 power utilities (turbostat,x86_energy_perf_policy) use? Implementingmsr_read()is trivial (warning
untested and uncompiled code)No. We can't. The MSR interface is disabled on several distribution and
platforms with secured boot. So some special MSRs are only allowed via
this IOCTL interface.Thanks,
SrinivasQuoted 3 lines
Actually good point!
Re: [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket
Quoted 27 lines · Srinivas Pandruvada
Quoted 19 lines · Srinivas Pandruvada
Quoted 18 lines · Andy Shevchenko
Quoted 17 lines · Prarit Bhargava
Quoted 4 lines · Srinivas Pandruvada
Read the bucket and core count relationship via MSR and display when displaying turbo ratio limits.
+ ret = isst_send_msr_command(cpu,0x1ae, 0,buckets_info);^^^ you can get rid of the magic number
0x1aeby doing (sorry for the cut-and-paste)tools/power/x86/intel-speed-select/Makefile +0
-0@@ -15,6 +15,8 @@ endif MAKEFLAGS += -rQuoted 6 lines
Quoted 4 lines
tools/power/x86/intel-speed-select/Makefile endif
Quoted 4 lines
tools/power/x86/intel-speed-select/Makefile +2
-1override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include +override CFLAGS += -I../../../include +override CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"'No, we can't use
msr_index.
Quoted 8 lines
This comment was meant for use of
/dev/cpu/X/msrnotmsr_index. I didn't want to bring in dependency onmsr-index.hfor couple of 2 MSRs and the names inmsr-index.hdoesn't really reflect the actual processing, they are doing. For exampleMSR_TURBO_RATIO_LIMIT1for0x1ae. The definition of0x1AEis different on cpu model0x55and beyond.Quoted 1 line
It seems not applicable on top of tools patch series I had applied before.
Quoted 26 lines
Quoted 25 lines
Quoted 11 lines
I guess it can be done in more neat way.
Quoted 8 lines
As I've been looking at this code I have been wondering why didn't
you just use
the standard/dev/cpu/X/msrinterface that other x86 power utilities (turbostat,x86_energy_perf_policy) use? Implementingmsr_read()is trivial (warning
untested and uncompiled code)No. We can't. The MSR interface is disabled on several distribution and
platforms with secured boot. So some special MSRs are only allowed via
this IOCTL interface.Thanks,
SrinivasQuoted 3 lines
Actually good point!
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket
Quoted 38 lines · Andy Shevchenko
Quoted 27 lines · Srinivas Pandruvada
Quoted 19 lines · Srinivas Pandruvada
Quoted 18 lines · Andy Shevchenko
Quoted 17 lines · Prarit Bhargava
Quoted 4 lines · Srinivas Pandruvada
Read the bucket and core count relationship via MSR and display when displaying turbo ratio limits.
+ ret = isst_send_msr_command(cpu,0x1ae, 0,buckets_info);^^^ you can get rid of the magic number
0x1aeby doing (sorry for the cut-and-paste)tools/power/x86/intel-speed-select/Makefile +0
-0@@ -15,6 +15,8 @@ endif MAKEFLAGS += -rQuoted 6 lines
Quoted 4 lines
tools/power/x86/intel-speed-select/Makefile endif
Quoted 4 lines
tools/power/x86/intel-speed-select/Makefile +2
-1override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include +override CFLAGS += -I../../../include +override CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"'No, we can't use
msr_index.Quoted 8 lines
This comment was meant for use of
/dev/cpu/X/msrnotmsr_index. I didn't want to bring in dependency onmsr-index.hfor couple of 2 MSRs and the names inmsr-index.hdoesn't really reflect the actual processing, they are doing. For exampleMSR_TURBO_RATIO_LIMIT1for0x1ae. The definition of0x1AEis different on cpu model0x55and beyond.Quoted 1 line
Quoted 20 lines
It seems not applicable on top of tools patch series I had applied before.
Quoted 18 lines
Quoted 18 lines
Quoted 11 lines
I guess it can be done in more neat way.
Quoted 8 lines
As I've been looking at this code I have been wondering why didn't
you just use
the standard/dev/cpu/X/msrinterface that other x86 power utilities (turbostat,x86_energy_perf_policy) use? Implementingmsr_read()is trivial (warning
untested and uncompiled code)No. We can't. The MSR interface is disabled on several distribution and
platforms with secured boot. So some special MSRs are only allowed via
this IOCTL interface.
Which distros don't have /dev/cpu/X/msr ?
None of other Intel tools have this restriction (or requirement depending on your point of view). Why is intel-speed-select special that we have to jump through hoops?
P.
Quoted 10 lines
Quoted 8 lines
Quoted 7 lines
Thanks,
SrinivasQuoted 3 lines
Actually good point!
Srinivas Pandruvada
maintainerRe: [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket
Quoted 74 lines · Prarit Bhargava
Quoted 47 lines · Andy Shevchenko
Quoted 33 lines · Srinivas Pandruvada
Quoted 22 lines · Srinivas Pandruvada
Quoted 21 lines · Andy Shevchenko
Quoted 19 lines · Prarit Bhargava
Quoted 5 lines · Srinivas Pandruvada
Read the bucket and core count relationship via MSR and display
when displaying turbo ratio limits.
+ ret = isst_send_msr_command(cpu,0x1ae, 0,buckets_info);^^^ you can get rid of the magic number
0x1aeby doing (sorry for
the cut-and-paste)tools/power/x86/intel-speed-select/Makefile +0
-0@@ -15,6 +15,8 @@ endif MAKEFLAGS += -rQuoted 8 lines
Quoted 6 lines
Quoted 6 lines
tools/power/x86/intel-speed-select/Makefile +2
-2override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include +override CFLAGS += -I../../../include +override CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-
index.h"'No, we can't use
msr_index.Quoted 11 lines
This comment was meant for use of
/dev/cpu/X/msrnotmsr_index. I didn't want to bring in dependency onmsr-index.hfor couple of 2
MSRs and the names inmsr-index.hdoesn't really reflect the actual
processing, they are doing. For exampleMSR_TURBO_RATIO_LIMIT1for0x1ae. The definition of0x1AEis different on cpu model0x55and beyond.Quoted 1 line
Quoted 24 lines
It seems not applicable on top of tools patch series I had applied before.
Quoted 21 lines
Quoted 21 lines
Quoted 12 lines
I guess it can be done in more neat way.
Quoted 9 lines
As I've been looking at this code I have been wondering why didn't
you just use
the standard/dev/cpu/X/msrinterface that other x86 power utilities (turbostat,x86_energy_perf_policy) use? Implementingmsr_read()is trivial
(warning
untested and uncompiled code)No. We can't. The MSR interface is disabled on several distribution
and
platforms with secured boot. So some special MSRs are only allowed
via
this IOCTL interface.
Quoted 1 line
Which distros don't have
/dev/cpu/X/msr?
Google "UEFI Secure Boot"
The patch for kernel lock down was from RedHat, which restricted MSRs!
Quoted 6 lines
None of other Intel tools have this restriction (or requirement depending on
your point of view). Why is intel-speed-select special that we have to
jump through hoops?
Not sure why you call jumping hoops here. You are comparing debug tools with run time service from kernel for Intel speed select.
This is not about tool. This tool is giving example how user spaces can control SST features through a kernel interface which should work with any distribution including home grown distros. And this interface is not for testing like turbostat or similar. So if any orchestration software can send same message as this tool and able to control SST features whether there is MSR access is there or not.
Also you are missing feature for save/restore state after suspend/resume.
Quoted 12 lines
P.
Quoted 9 lines
Quoted 7 lines
Quoted 7 lines
Thanks,
SrinivasQuoted 3 lines
Actually good point!
Srinivas Pandruvada
maintainerRe: [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket
In reply to Andy ShevchenkoQuoted 43 lines · Andy Shevchenko
Quoted 32 lines · Srinivas Pandruvada
Quoted 22 lines · Srinivas Pandruvada
Quoted 21 lines · Andy Shevchenko
Quoted 19 lines · Prarit Bhargava
Quoted 5 lines · Srinivas Pandruvada
Read the bucket and core count relationship via MSR and display
when displaying turbo ratio limits.
+ ret = isst_send_msr_command(cpu,0x1ae, 0,buckets_info);^^^ you can get rid of the magic number
0x1aeby doing (sorry for
the cut-and-paste)tools/power/x86/intel-speed-select/Makefile +0
-0@@ -15,6 +15,8 @@ endif MAKEFLAGS += -rQuoted 7 lines
Quoted 5 lines
tools/power/x86/intel-speed-select/Makefile endif · line 19
Quoted 5 lines
tools/power/x86/intel-speed-select/Makefile +2
-2override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include +override CFLAGS += -I../../../include +override CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"'No, we can't use
msr_index.Quoted 8 lines
This comment was meant for use of
/dev/cpu/X/msrnotmsr_index. I didn't want to bring in dependency onmsr-index.hfor couple of 2 MSRs and the names inmsr-index.hdoesn't really reflect the actual processing, they are doing. For exampleMSR_TURBO_RATIO_LIMIT1for0x1ae. The definition of0x1AEis different on cpu model0x55and beyond.Quoted 1 line
Quoted 2 lines
It seems not applicable on top of tools patch series I had applied before.
I have rebased on the top of your review branch and resent.
Thanks,
Srinivas
Quoted 31 lines
Quoted 29 lines
Quoted 29 lines
Quoted 13 lines
I guess it can be done in more neat way.
Quoted 9 lines
As I've been looking at this code I have been wondering why didn't
you just use
the standard/dev/cpu/X/msrinterface that other x86 power utilities (turbostat,x86_energy_perf_policy) use? Implementingmsr_read()is trivial
(warning
untested and uncompiled code)No. We can't. The MSR interface is disabled on several distribution
and
platforms with secured boot. So some special MSRs are only allowed
via
this IOCTL interface.Thanks,
SrinivasQuoted 3 lines
Actually good point!
Re: [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket
Quoted 7 lines · Srinivas Pandruvada
Quoted 5 lines · Andy Shevchenko
On Fri, Sep 6, 2019 at 10:47 PM Srinivas Pandruvada <[email protected]> wrote:
It seems not applicable on top of tools patch series I had applied before.
I have rebased on the top of your review branch and resent.
Pushed to my review and testing queue, thanks!
Signature · 2 lines
With Best Regards, Andy Shevchenko