Skip to contentSkip to conversation

soundwire: add back ACPI dependency

PATCH In review Arnd Bergmann 2 participants 5 messages Sep 5, 2019 – Sep 6, 2019 SoundWire

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soundwire: add back ACPI dependency

Soundwire gained a warning for randconfig builds without CONFIG_ACPI during the linux-5.3-rc cycle:

drivers/soundwire/slave.c:16:12: error: unused function 'sdw_slave_add' [-Werror,-Wunused-function]

Add the CONFIG_ACPI dependency at the top level now.

Fixes 8676b3ca4673 ("soundwire: fix regmap dependencies and align with other serial links")
---
 drivers/soundwire/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/soundwire/Kconfig +1 -0
index f518273cfbe3..c73bfbaa2659 100644
@@ -5,6 +5,7 @@
 
 menuconfig SOUNDWIRE
 	tristate "SoundWire support"
+	depends on ACPI
 	help
 	  SoundWire is a 2-Pin interface with data and clock line ratified
 	  by the MIPI Alliance. SoundWire is used for transporting data
Signature · 1 line
2.20.0
maintainer
#1 lore raw
Quoted 6 lines · Arnd Bergmann

Soundwire gained a warning for randconfig builds without CONFIG_ACPI during the linux-5.3-rc cycle:

drivers/soundwire/slave.c:16:12: error: unused function 'sdw_slave_add' [-Werror,-Wunused-function]

Add the CONFIG_ACPI dependency at the top level now.

Did you run this yesterday or today. I have applied Srini's patches to add DT support for Soundwire couple of days back so we should not see this warning anymore

Quoted 20 lines
Fixes 8676b3ca4673 ("soundwire: fix regmap dependencies and align with other serial links")
---
 drivers/soundwire/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/soundwire/Kconfig +1 -0
index f518273cfbe3..c73bfbaa2659 100644
@@ -5,6 +5,7 @@
 
 menuconfig SOUNDWIRE
 	tristate "SoundWire support"
+	depends on ACPI
 	help
 	  SoundWire is a 2-Pin interface with data and clock line ratified
 	  by the MIPI Alliance. SoundWire is used for transporting data
Signature · 1 line
2.20.0
Signature · 1 line
~Vinod
#2 lore raw
Quoted 5 lines · Vinod Koul
Quoted 3 lines · Arnd Bergmann

Soundwire gained a warning for randconfig builds without CONFIG_ACPI during the linux-5.3-rc cycle:

Quoted 7 lines
Quoted 3 lines

drivers/soundwire/slave.c:16:12: error: unused function 'sdw_slave_add' [-Werror,-Wunused-function]

Add the CONFIG_ACPI dependency at the top level now.

Did you run this yesterday or today. I have applied Srini's patches to add DT support for Soundwire couple of days back so we should not see this warning anymore

This is on the latest linux-next, which is dated 20190904. As Stephen is not releasing any more linux-next kernels until later this month, I'm missing anything that came in afterwards.

Arnd

maintainer
#3 lore raw
Quoted 10 lines · Arnd Bergmann
Quoted 9 lines · Vinod Koul
Quoted 6 lines · Arnd Bergmann

Soundwire gained a warning for randconfig builds without CONFIG_ACPI during the linux-5.3-rc cycle:

drivers/soundwire/slave.c:16:12: error: unused function 'sdw_slave_add' [-Werror,-Wunused-function]

Add the CONFIG_ACPI dependency at the top level now.

Quoted 7 lines
Quoted 3 lines

Did you run this yesterday or today. I have applied Srini's patches to add DT support for Soundwire couple of days back so we should not see this warning anymore

This is on the latest linux-next, which is dated 20190904. As Stephen is not releasing any more linux-next kernels until later this month, I'm missing anything that came in afterwards.

That is interesting as next-20190904 has the DT changes :) Can you share the config you used to get this.

I have two instances of sdw_slave_add() in next-20190904:

drivers/soundwire/slave.c:              sdw_slave_add(bus, &id, acpi_fwnode_handle(adev));
drivers/soundwire/slave.c:              sdw_slave_add(bus, &id, of_fwnode_handle(node));

Thanks

Signature · 1 line
~Vinod
#4 lore raw
Quoted 19 lines · Vinod Koul
Quoted 10 lines · Arnd Bergmann
Quoted 9 lines · Vinod Koul
Quoted 6 lines · Arnd Bergmann

Soundwire gained a warning for randconfig builds without CONFIG_ACPI during the linux-5.3-rc cycle:

drivers/soundwire/slave.c:16:12: error: unused function 'sdw_slave_add' [-Werror,-Wunused-function]

Add the CONFIG_ACPI dependency at the top level now.

Quoted 7 lines
Quoted 3 lines

Did you run this yesterday or today. I have applied Srini's patches to add DT support for Soundwire couple of days back so we should not see this warning anymore

This is on the latest linux-next, which is dated 20190904. As Stephen is not releasing any more linux-next kernels until later this month, I'm missing anything that came in afterwards.

Quoted 7 lines

That is interesting as next-20190904 has the DT changes :) Can you share the config you used to get this.

I have two instances of sdw_slave_add() in next-20190904:

drivers/soundwire/slave.c:              sdw_slave_add(bus, &id, acpi_fwnode_handle(adev));
drivers/soundwire/slave.c:              sdw_slave_add(bus, &id, of_fwnode_handle(node));

Ok, I remember now: the warning I got was actually on mainline. It's fixed in linux-next, but from all I can tell, 5.3-rc7 is still broken.

Arnd