Skip to contentSkip to conversation

media: s3c-camif: make array 'registers' static const, makes object smaller

PATCH New Colin King 1 participant 1 message Sep 6, 2019

Subsystems (3)
lore
Share & tools
lore

Colin King

author
#0 lore raw

PATCH 1/1 media: s3c-camif: make array 'registers' static const, makes object smaller

From: Colin Ian King <[email protected]>

Don't populate the array 'registers' on the stack but instead make it static const. Makes the object code smaller by 45 bytes.

Before:
text data bss dec hex filename
17364 5000 0 22364 575c platform/s3c-camif/camif-regs.o

After:
text data bss dec hex filename
17255 5064 0 22319 572f platform/s3c-camif/camif-regs.o

(gcc version 9.2.1, amd64)

---
 drivers/media/platform/s3c-camif/camif-regs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/s3c-camif/camif-regs.c +1 -1
index 1a65532dc36d..e80204f5720c 100644
@@ -553,7 +553,7 @@ void camif_hw_disable_capture(struct camif_vp *vp)
 
 void camif_hw_dump_regs(struct camif_dev *camif, const char *label)
 {
-	struct {
+	static const struct {
 		u32 offset;
 		const char * const name;
 	} registers[] = {
Signature · 1 line
2.20.1