Skip to contentSkip to conversation

hostapd: remove support for Realtek drivers

PATCH New Alexander Mukhin 2 participants 4 messages Sep 6, 2019 – Sep 7, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 hostapd: remove support for Realtek drivers

After hostapd update to 2.9, the patch provided no longer works, although applies. Moreover, AP support for Realtek chips is broken anyway in kernels > 4.9.

---
 package/hostapd/Config.in    | 7 -------
 package/hostapd/hostapd.hash | 1 -
 package/hostapd/hostapd.mk   | 5 -----
 3 files changed, 13 deletions(-)
package/hostapd/Config.in +0 -7
index 37c1126859..8a7abbb901 100644
@@ -31,12 +31,6 @@ config BR2_PACKAGE_HOSTAPD_DRIVER_NL80211
 comment "nl80211 driver needs a toolchain w/ threads"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
-config BR2_PACKAGE_HOSTAPD_DRIVER_RTW
-	bool "Enable rtl871xdrv driver"
-	select BR2_PACKAGE_HOSTAPD_HAS_WIFI_DRIVERS
-	help
-	  Enable support for Realtek wireless chips.
-
 config BR2_PACKAGE_HOSTAPD_DRIVER_WIRED
 	bool "Enable wired driver"
 	help
@@ -47,7 +41,6 @@ config BR2_PACKAGE_HOSTAPD_DRIVER_NONE
 	default y
 	depends on !BR2_PACKAGE_HOSTAPD_DRIVER_HOSTAP
 	depends on !BR2_PACKAGE_HOSTAPD_DRIVER_NL80211
-	depends on !BR2_PACKAGE_HOSTAPD_DRIVER_RTW
 	depends on !BR2_PACKAGE_HOSTAPD_DRIVER_WIRED
 
 config BR2_PACKAGE_HOSTAPD_HAS_WIFI_DRIVERS
package/hostapd/hostapd.hash +0 -1
index 50225cf6d7..bf5016acc3 100644
@@ -1,4 +1,3 @@
 # Locally calculated
 sha256  881d7d6a90b2428479288d64233151448f8990ab4958e0ecaca7eeb3c9db2bd7  hostapd-2.9.tar.gz
-sha256  e204da659d0583c71af23cb9b55536fe99598ee26a44104344f456e4d17350c6  rtlxdrv.patch
 sha256  9da5dd0776da266b180b915e460ff75c6ff729aca1196ab396529510f24f3761  README
package/hostapd/hostapd.mk +0 -5
index f55e716a7c..fb6ac8fb2e 100644
@@ -39,11 +39,6 @@ ifeq ($(BR2_PACKAGE_HOSTAPD_DRIVER_NL80211),)
 HOSTAPD_CONFIG_DISABLE += CONFIG_DRIVER_NL80211
 endif
 
-ifeq ($(BR2_PACKAGE_HOSTAPD_DRIVER_RTW),y)
-HOSTAPD_PATCH += https://github.com/pritambaral/hostapd-rtl871xdrv/raw/master/rtlxdrv.patch
-HOSTAPD_CONFIG_SET += CONFIG_DRIVER_RTW
-endif
-
 ifeq ($(BR2_PACKAGE_HOSTAPD_DRIVER_WIRED),y)
 HOSTAPD_CONFIG_ENABLE += CONFIG_DRIVER_WIRED
 endif
Signature · 1 line
2.20.1
#1 lore raw

PATCH 2/2 Remove myself from hostapd developers

---
 DEVELOPERS | 3 ---
 1 file changed, 3 deletions(-)
DEVELOPERS +0 -3
index 4b4a74ab3f..0905237790 100644
@@ -106,9 +106,6 @@ F:	package/putty/
 N:	Alexander Lukichev <[email protected]>
 F:	package/openpgm/
 
-N:	Alexander Mukhin <[email protected]>
-F:	package/hostapd/
-
 N:	Alexander Sverdlin <[email protected]>
 F:	package/mini-snmpd/
 
Signature · 1 line
2.20.1
#2 lore raw

PATCH 2/2 Remove myself from hostapd developers

Quoted 4 lines · On Fri, 6 Sep 2019 13:21:01 +0300 Alexander Mukhin…
---
 DEVELOPERS | 3 ---
 1 file changed, 3 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/2 hostapd: remove support for Realtek drivers

In reply to Alexander Mukhin

Hello Alexander,

Quoted 5 lines · On Fri, 6 Sep 2019 13:21:00 +0300 Alexander Mukhin…

After hostapd update to 2.9, the patch provided no longer works, although applies. Moreover, AP support for Realtek chips is broken anyway in kernels > 4.9.

The commit title prefix should have been "package/hostapd", and also when removing an option, it must be added in Config.in.legacy. I fixed both issues and applied to master.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com