Skip to contentSkip to conversation

imx: support i.MX8QM ROM 7720 a1 board

PATCH Superseded Oliver Graute 3 participants 6 messages Sep 6, 2019 – Sep 11, 2019

Subsystems (3)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v4 cover imx: support i.MX8QM ROM 7720 a1 board

Hello list,

need some information howto avoid the imx-mkimage repo and create full boostream directly from u-boot with all the binary blobs.

Best regards,

Oliver

Oliver Graute (1):
imx: support i.MX8QM ROM 7720 a1 board

 arch/arm/dts/Makefile                         |   1 +
 arch/arm/dts/imx8qm-rom7720-a1.dts            | 373 ++++++++++++++++++
 arch/arm/mach-imx/imx8/Kconfig                |   7 +
 board/advantech/imx8qm_rom7720_a1/Kconfig     |  14 +
 board/advantech/imx8qm_rom7720_a1/MAINTAINERS |   6 +
 board/advantech/imx8qm_rom7720_a1/Makefile    |  11 +
 board/advantech/imx8qm_rom7720_a1/README      |  70 ++++
 .../imx8qm_rom7720_a1/imx8qm_rom7720_a1.c     | 141 +++++++
 .../advantech/imx8qm_rom7720_a1/imximage.cfg  |  21 +
 board/advantech/imx8qm_rom7720_a1/spl.c       | 223 +++++++++++
 configs/imx8qm_rom7720_a1_4G_defconfig        |  83 ++++
 include/configs/imx8qm_rom7720.h              | 176 +++++++++
 12 files changed, 1126 insertions(+)
 create mode 100644 arch/arm/dts/imx8qm-rom7720-a1.dts
 create mode 100644 board/advantech/imx8qm_rom7720_a1/Kconfig
 create mode 100644 board/advantech/imx8qm_rom7720_a1/MAINTAINERS
 create mode 100644 board/advantech/imx8qm_rom7720_a1/Makefile
 create mode 100644 board/advantech/imx8qm_rom7720_a1/README
 create mode 100644 board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c
 create mode 100644 board/advantech/imx8qm_rom7720_a1/imximage.cfg
 create mode 100644 board/advantech/imx8qm_rom7720_a1/spl.c
 create mode 100644 configs/imx8qm_rom7720_a1_4G_defconfig
 create mode 100644 include/configs/imx8qm_rom7720.h
Signature · 1 line
2.17.1
#1 lore raw

PATCH v4 1/1 imx: support i.MX8QM ROM 7720 a1 board

Add i.MX8QM ROM 7720a1 board support

Boot log as below:
U-Boot 2019.10-rc3-00217-g1b7f3d7865 (Sep 06 2019 - 08:03:23 +0200)

CPU: NXP i.MX8QM RevB A53 at 1200 MHz

Model: Advantech iMX8QM Qseven series
Board: ROM-7720-A1 4GB
Build: SCFW 65afe5f6
Boot:  SD2
DRAM:  3.9 GiB
MMC:   FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2
Loading Environment from MMC... OK
In:    serial at 5a060000
Out:   serial at 5a060000
Err:   serial at 5a060000
Net:   eth0: ethernet at 5b040000Could not get PHY for FEC1: addr 1

, eth-1: ethernet at 5b050000
Hit any key to stop autoboot: 0

Cc Stefano Babic <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Simon Glass <[email protected]>
Cc uboot-imx <[email protected]>

---

These changes are based on this vendor tree:
https://github.com/ADVANTECH-Corp/uboot-imx6.git

I adapted the files and compared them with code from similar imx8qm-mek board

Changes for v4:
- changed SYS_VENDOR to advantech
- use sc_pm_setup_uart
- removed CONFIG_OF_BOARD_SETUP
- dropped board_gpio_init
- enabled CONFIG_SPL_DM_MMC
- dropped USDHC defines
- dropped CONFIG_AHAB_BOOT

Changes for v3:
- removed duplicate build_info
- removed CONFIG_FSL_ESDHC

Changes for v2:
- cleanup of u-boot environment
- set power mode SC_R_DC_0 for full boot of linux kernel
- enabled usdhc2
- enabled FEC defines
- updated README.md
- enabled readwrite for nfs rootfs
- removed include of environment header

 arch/arm/dts/Makefile                         |   1 +
 arch/arm/dts/imx8qm-rom7720-a1.dts            | 373 ++++++++++++++++++
 arch/arm/mach-imx/imx8/Kconfig                |   7 +
 board/advantech/imx8qm_rom7720_a1/Kconfig     |  14 +
 board/advantech/imx8qm_rom7720_a1/MAINTAINERS |   6 +
 board/advantech/imx8qm_rom7720_a1/Makefile    |  11 +
 board/advantech/imx8qm_rom7720_a1/README      |  70 ++++
 .../imx8qm_rom7720_a1/imx8qm_rom7720_a1.c     | 141 +++++++
 .../advantech/imx8qm_rom7720_a1/imximage.cfg  |  21 +
 board/advantech/imx8qm_rom7720_a1/spl.c       | 223 +++++++++++
 configs/imx8qm_rom7720_a1_4G_defconfig        |  83 ++++
 include/configs/imx8qm_rom7720.h              | 176 +++++++++
 12 files changed, 1126 insertions(+)
 create mode 100644 arch/arm/dts/imx8qm-rom7720-a1.dts
 create mode 100644 board/advantech/imx8qm_rom7720_a1/Kconfig
 create mode 100644 board/advantech/imx8qm_rom7720_a1/MAINTAINERS
 create mode 100644 board/advantech/imx8qm_rom7720_a1/Makefile
 create mode 100644 board/advantech/imx8qm_rom7720_a1/README
 create mode 100644 board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c
 create mode 100644 board/advantech/imx8qm_rom7720_a1/imximage.cfg
 create mode 100644 board/advantech/imx8qm_rom7720_a1/spl.c
 create mode 100644 configs/imx8qm_rom7720_a1_4G_defconfig
 create mode 100644 include/configs/imx8qm_rom7720.h
arch/arm/dts/Makefile +1 -0
index aac1b83d49..aa139afd57 100644
@@ -625,6 +625,7 @@ dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb
 dtb-$(CONFIG_ARCH_IMX8) += \
 	fsl-imx8qm-apalis.dtb \
 	fsl-imx8qm-mek.dtb \
+	imx8qm-rom7720-a1.dtb \
 	fsl-imx8qxp-colibri.dtb \
 	fsl-imx8qxp-mek.dtb
 
arch/arm/dts/imx8qm-rom7720-a1.dts new file +373 -0

373 lines not on this page · raw message

arch/arm/mach-imx/imx8/Kconfig +7 -0
index bbe323d5ca..eb2eacdfbd 100644
@@ -42,6 +42,12 @@ config TARGET_IMX8QM_MEK
 	select BOARD_LATE_INIT
 	select IMX8QM
 
+config TARGET_IMX8QM_ROM7720_A1
+	bool "Support i.MX8QM ROM-7720-A1"
+	select BOARD_LATE_INIT
+	select SUPPORT_SPL
+	select IMX8QM
+
 config TARGET_IMX8QXP_MEK
 	bool "Support i.MX8QXP MEK board"
 	select BOARD_LATE_INIT
@@ -51,6 +57,7 @@ endchoice
 
 source "board/freescale/imx8qm_mek/Kconfig"
 source "board/freescale/imx8qxp_mek/Kconfig"
+source "board/advantech/imx8qm_rom7720_a1/Kconfig"
 source "board/toradex/apalis-imx8/Kconfig"
 source "board/toradex/colibri-imx8x/Kconfig"
 
board/advantech/imx8qm_rom7720_a1/Kconfig new file +14 -0
new file mode 100644
index 0000000000..cf3869ed92
@@ -0,0 +1,14 @@
+if TARGET_IMX8QM_ROM7720_A1
+
+config SYS_BOARD
+	default "imx8qm_rom7720_a1"
+
+config SYS_VENDOR
+	default "advantech"
+
+config SYS_CONFIG_NAME
+	default "imx8qm_rom7720"
+
+source "board/freescale/common/Kconfig"
+
+endif
board/advantech/imx8qm_rom7720_a1/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000000..b142ee02e6
@@ -0,0 +1,6 @@
+i.MX8QM ROM 7720 a1 BOARD
+M:	Oliver Graute <[email protected]>
+S:	Maintained
+F:	board/advantech/imx8qm_rom7720_a1/
+F:	include/configs/imx8qm_rom7720.h
+F:	configs/imx8qm_rom7720_a1_4G_defconfig
board/advantech/imx8qm_rom7720_a1/Makefile new file +11 -0
new file mode 100644
index 0000000000..51c5de251c
@@ -0,0 +1,11 @@
+#
+# Copyright 2017 NXP
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+obj-y += imx8qm_rom7720_a1.o
+
+ifdef CONFIG_SPL_BUILD
+obj-y += spl.o
+endif
board/advantech/imx8qm_rom7720_a1/README new file +70 -0

70 lines not on this page · raw message

board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c new file +141 -0

141 lines not on this page · raw message

board/advantech/imx8qm_rom7720_a1/imximage.cfg new file +21 -0
new file mode 100644
index 0000000000..e324c7ca37
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier:	GPL-2.0+ */
+/*
+ * Copyright 2018 NXP
+ */
+
+#define __ASSEMBLY__
+
+/* Boot from SD, sector size 0x400 */
+BOOT_FROM SD 0x400
+/* SoC type IMX8QM */
+SOC_TYPE IMX8QM
+/* Append seco container image */
+APPEND mx8qm-ahab-container.img
+/* Create the 2nd container */
+CONTAINER
+/* Add scfw image with exec attribute */
+IMAGE SCU mx8qm-val-scfw-tcm.bin
+/* Add ATF image with exec attribute */
+IMAGE A35 bl31.bin 0x80000000
+/* Add U-Boot image with load attribute */
+DATA A35 u-boot-dtb.bin 0x80020000
board/advantech/imx8qm_rom7720_a1/spl.c new file +223 -0

223 lines not on this page · raw message

configs/imx8qm_rom7720_a1_4G_defconfig new file +83 -0

83 lines not on this page · raw message

include/configs/imx8qm_rom7720.h new file +176 -0

176 lines not on this page · raw message

Signature · 1 line
2.17.1
#2 lore raw

v4 cover imx: support i.MX8QM ROM 7720 a1 board

In reply to Oliver Graute

Hi Oliver,

Quoted 4 lines

Hello list,

need some information howto avoid the imx-mkimage repo and create full boostream directly from u-boot with all the binary blobs.

You may want to look into binman tool (./tools/binman), which is supposed to pack all binary data together and produce one image.

Also - you may be interested in fitImage, which allows packing kernel, dtb(s), initramfs, and some binary blobs together.

I've also added Peng to CC, so he may help you as well as he also provided recently some patches to add i.MX8 support to U-Boot.

Quoted 28 lines

Best regards,

Oliver

Oliver Graute (1):
imx: support i.MX8QM ROM 7720 a1 board

 arch/arm/dts/Makefile                         |   1 +
 arch/arm/dts/imx8qm-rom7720-a1.dts            | 373
++++++++++++++++++ arch/arm/mach-imx/imx8/Kconfig                |
7 + board/advantech/imx8qm_rom7720_a1/Kconfig     |  14 +
 board/advantech/imx8qm_rom7720_a1/MAINTAINERS |   6 +
 board/advantech/imx8qm_rom7720_a1/Makefile    |  11 +
 board/advantech/imx8qm_rom7720_a1/README      |  70 ++++
 .../imx8qm_rom7720_a1/imx8qm_rom7720_a1.c     | 141 +++++++
 .../advantech/imx8qm_rom7720_a1/imximage.cfg  |  21 +
 board/advantech/imx8qm_rom7720_a1/spl.c       | 223 +++++++++++
 configs/imx8qm_rom7720_a1_4G_defconfig        |  83 ++++
 include/configs/imx8qm_rom7720.h              | 176 +++++++++
 12 files changed, 1126 insertions(+)
 create mode 100644 arch/arm/dts/imx8qm-rom7720-a1.dts
 create mode 100644 board/advantech/imx8qm_rom7720_a1/Kconfig
 create mode 100644 board/advantech/imx8qm_rom7720_a1/MAINTAINERS
 create mode 100644 board/advantech/imx8qm_rom7720_a1/Makefile
 create mode 100644 board/advantech/imx8qm_rom7720_a1/README
 create mode 100644
Quoted 6 lines

board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c create mode 100644 board/advantech/imx8qm_rom7720_a1/imximage.cfg create mode 100644 board/advantech/imx8qm_rom7720_a1/spl.c create mode 100644 configs/imx8qm_rom7720_a1_4G_defconfig create mode 100644 include/configs/imx8qm_rom7720.h

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190906/bd06cd98/attachment.sig>

#3 lore raw

v4 cover imx: support i.MX8QM ROM 7720 a1 board

In reply to Oliver Graute
Quoted 6 lines

Subject: [PATCH v4 0/1] imx: support i.MX8QM ROM 7720 a1 board

Hello list,

need some information howto avoid the imx-mkimage repo and create full boostream directly from u-boot with all the binary blobs.

Try the diff, and see whether it helps.

arch/arm/mach-imx/Makefile +0 -2
index 08ee52edbf..4d0f0970df 100644
@@ -159,10 +159,8 @@ MKIMAGEFLAGS_flash.bin = -n spl/u-boot-spl.cfgout -T $(IMAGE_TYPE) -e 0x100000
 flash.bin: MKIMAGEOUTPUT = flash.log
 
 flash.bin: spl/u-boot-spl.bin u-boot.itb FORCE
-ifeq ($(SPL_DEPFILE_EXISTS),0)
        $(call if_changed,mkimage)
 endif
-endif
 
 else
 MKIMAGEFLAGS_SPL = -n $(filter-out $(PLUGIN).bin $< $(PHONY),$^) \

Regards,
Peng.

Quoted 38 lines

Best regards,

Oliver

Oliver Graute (1):
imx: support i.MX8QM ROM 7720 a1 board

 arch/arm/dts/Makefile                         |   1 +
 arch/arm/dts/imx8qm-rom7720-a1.dts            | 373
++++++++++++++++++
 arch/arm/mach-imx/imx8/Kconfig                |   7 +
 board/advantech/imx8qm_rom7720_a1/Kconfig     |  14 +
 board/advantech/imx8qm_rom7720_a1/MAINTAINERS |   6 +
 board/advantech/imx8qm_rom7720_a1/Makefile    |  11 +
 board/advantech/imx8qm_rom7720_a1/README      |  70 ++++
 .../imx8qm_rom7720_a1/imx8qm_rom7720_a1.c     | 141 +++++++
 .../advantech/imx8qm_rom7720_a1/imximage.cfg  |  21 +
 board/advantech/imx8qm_rom7720_a1/spl.c       | 223 +++++++++++
 configs/imx8qm_rom7720_a1_4G_defconfig        |  83 ++++
 include/configs/imx8qm_rom7720.h              | 176 +++++++++
 12 files changed, 1126 insertions(+)
 create mode 100644 arch/arm/dts/imx8qm-rom7720-a1.dts
 create mode 100644 board/advantech/imx8qm_rom7720_a1/Kconfig
 create mode 100644
board/advantech/imx8qm_rom7720_a1/MAINTAINERS
 create mode 100644 board/advantech/imx8qm_rom7720_a1/Makefile
 create mode 100644 board/advantech/imx8qm_rom7720_a1/README
 create mode 100644
board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c
 create mode 100644 board/advantech/imx8qm_rom7720_a1/imximage.cfg
 create mode 100644 board/advantech/imx8qm_rom7720_a1/spl.c
 create mode 100644 configs/imx8qm_rom7720_a1_4G_defconfig
 create mode 100644 include/configs/imx8qm_rom7720.h

--
2.17.1

#4 lore raw

v4 cover imx: support i.MX8QM ROM 7720 a1 board

Quoted 13 lines · Peng Fan
Quoted 6 lines

Subject: [PATCH v4 0/1] imx: support i.MX8QM ROM 7720 a1 board

Hello list,

need some information howto avoid the imx-mkimage repo and create full boostream directly from u-boot with all the binary blobs.

Try the diff, and see whether it helps.

arch/arm/mach-imx/Makefile +0 -0
index 08ee52edbf..4d0f0970df 100644

arch/arm/mach-imx/Makefile MKIMAGEFLAGS_flash.bin = -n spl/u-boot-spl.cfgout -T $(IMAGE_TYPE) -e 0x100000 · line 166

Quoted 10 lines
arch/arm/mach-imx/Makefile +0 -2
@@ -159,10 +159,8 @@ MKIMAGEFLAGS_flash.bin = -n spl/u-boot-spl.cfgout -T $(IMAGE_TYPE) -e 0x100000
 flash.bin: MKIMAGEOUTPUT = flash.log
 
 flash.bin: spl/u-boot-spl.bin u-boot.itb FORCE
-ifeq ($(SPL_DEPFILE_EXISTS),0)
        $(call if_changed,mkimage)
 endif
-endif
 
 else
 MKIMAGEFLAGS_SPL = -n $(filter-out $(PLUGIN).bin $< $(PHONY),$^) \

You are right, with that proposal and some minor fixes in my patch I can build an full bootstream with all the needed binary blobs. So I can drop imx-mkimage now.

Thank you,

Oliver

#5 lore raw

v4 cover imx: support i.MX8QM ROM 7720 a1 board

Quoted 26 lines

Subject: Re: [PATCH v4 0/1] imx: support i.MX8QM ROM 7720 a1 board

arch/arm/mach-imx/Makefile MKIMAGEFLAGS_flash.bin = -n

Quoted 13 lines · Peng Fan
Quoted 6 lines

Subject: [PATCH v4 0/1] imx: support i.MX8QM ROM 7720 a1 board

Hello list,

need some information howto avoid the imx-mkimage repo and create full boostream directly from u-boot with all the binary blobs.

Try the diff, and see whether it helps.

arch/arm/mach-imx/Makefile +0 -0
index 08ee52edbf..4d0f0970df 100644
@@ -159,10 +159,8 @@ MKIMAGEFLAGS_flash.bin = -n

spl/u-boot-spl.cfgout

Quoted 9 lines
arch/arm/mach-imx/Makefile +0 -2
-T $(IMAGE_TYPE) -e 0x100000
 flash.bin: MKIMAGEOUTPUT = flash.log
 
 flash.bin: spl/u-boot-spl.bin u-boot.itb FORCE -ifeq
 ($(SPL_DEPFILE_EXISTS),0)
        $(call if_changed,mkimage)
 endif
-endif
 
Quoted 6 lines
Quoted 2 lines
arch/arm/mach-imx/Makefile +0 -0
 else

MKIMAGEFLAGS_SPL = -n $(filter-out $(PLUGIN).bin $< $(PHONY),$^) \

You are right, with that proposal and some minor fixes in my patch I can build an full bootstream with all the needed binary blobs. So I can drop imx-mkimage now.

Great. This is a bug in the dependency file check.

-Peng

Quoted 4 lines

Thank you,

Oliver