Skip to contentSkip to conversation

ARM: don't export unused return_address()

PATCH In review Arnd Bergmann 4 participants 13 messages Sep 6, 2019 – Nov 20, 2019 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: don't export unused return_address()

Without the frame pointer enabled, return_address() is an inline function and does not need to be exported, as shown by this warning:

WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL

Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.

---
 arch/arm/kernel/return_address.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/kernel/return_address.c +2 -1
index b0d2f1fe891d..fb0fc1910102 100644
@@ -53,6 +53,7 @@ void *return_address(unsigned int level)
 		return NULL;
 }
 
+EXPORT_SYMBOL_GPL(return_address);
+
 #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
-EXPORT_SYMBOL_GPL(return_address);
Signature · 1 line
2.20.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Arnd Bergmann

Without the frame pointer enabled, return_address() is an inline function and does not need to be exported, as shown by this warning:

WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL

Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.

Signature · 2 lines
Best Regards
Masahiro Yamada
Tested-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann

Hi Arnd,

Quoted 8 lines · Arnd Bergmann

Without the frame pointer enabled, return_address() is an inline function and does not need to be exported, as shown by this warning:

WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL

Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.

Thanks for your patch!

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 55

Quoted 6 lines
arch/arm/kernel/return_address.c +0 -0
@@ -53,6 +53,7 @@ void *return_address(unsigned int level)
                return NULL;
 }
 

Checkpatch doesn't like the empty line above:

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 58

Quoted 5 lines
arch/arm/kernel/return_address.c +2 -1
+EXPORT_SYMBOL_GPL(return_address);
+
 #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
-EXPORT_SYMBOL_GPL(return_address);

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#3 lore raw
Quoted 36 lines · Geert Uytterhoeven

Hi Arnd,

Quoted 8 lines · Arnd Bergmann

Without the frame pointer enabled, return_address() is an inline function and does not need to be exported, as shown by this warning:

WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL

Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.

Thanks for your patch!

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 55

Quoted 6 lines
arch/arm/kernel/return_address.c +0 -0
@@ -53,6 +53,7 @@ void *return_address(unsigned int level)
                return NULL;
 }
 

Checkpatch doesn't like the empty line above:

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 58

Quoted 5 lines
arch/arm/kernel/return_address.c +2 -1
+EXPORT_SYMBOL_GPL(return_address);
+
 #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
-EXPORT_SYMBOL_GPL(return_address);

Gr{oetje,eeting}s,

Quoted 8 lines

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

What has happened to this patch?

I still see this warning.

Signature · 2 lines
Best Regards
Masahiro Yamada
#4 lore raw
Quoted 48 lines · Masahiro Yamada
Quoted 36 lines · Geert Uytterhoeven

Hi Arnd,

Quoted 8 lines · Arnd Bergmann

Without the frame pointer enabled, return_address() is an inline function and does not need to be exported, as shown by this warning:

WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL

Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.

Thanks for your patch!

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 55

Quoted 6 lines
arch/arm/kernel/return_address.c +0 -0
@@ -53,6 +53,7 @@ void *return_address(unsigned int level)
                return NULL;
 }
 

Checkpatch doesn't like the empty line above:

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 58

Quoted 5 lines
arch/arm/kernel/return_address.c +2 -1
+EXPORT_SYMBOL_GPL(return_address);
+
 #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
-EXPORT_SYMBOL_GPL(return_address);

Gr{oetje,eeting}s,

Quoted 8 lines

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Quoted 3 lines

What has happened to this patch?

I still see this warning.

Simple - it got merged, it caused build regressions, it got dropped. A new version is pending me doing another round of patch merging.

Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
#5 lore raw

Hi Russell,

Quoted 31 lines · Russell King - ARM Linux admin
Quoted 30 lines · Masahiro Yamada
Quoted 29 lines · Geert Uytterhoeven
Quoted 8 lines · Arnd Bergmann

Without the frame pointer enabled, return_address() is an inline function and does not need to be exported, as shown by this warning:

WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL

Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.

Thanks for your patch!

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 55

Quoted 6 lines
arch/arm/kernel/return_address.c +0 -0
@@ -53,6 +53,7 @@ void *return_address(unsigned int level)
                return NULL;
 }
 

Checkpatch doesn't like the empty line above:

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

Quoted 4 lines
arch/arm/kernel/return_address.c +2 -0
+EXPORT_SYMBOL_GPL(return_address);
+
 #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 58

Quoted 1 line
arch/arm/kernel/return_address.c +0 -1
-EXPORT_SYMBOL_GPL(return_address);

What has happened to this patch?

I still see this warning.

Simple - it got merged, it caused build regressions, it got dropped. A new version is pending me doing another round of patch merging.

I believe that was not Arnd's patch, but Ben Dooks' alternative solution[*]?

[*] Commit 0b0617e5a610fe12 ("ARM: 8918/1: only build return_address() if
needed"), which I discovered in next-20191031 when checking if Arnd's patch was applied....

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#6 lore raw
Quoted 39 lines · Geert Uytterhoeven

Hi Russell,

Quoted 35 lines · Russell King - ARM Linux admin
Quoted 34 lines · Masahiro Yamada
Quoted 23 lines · Geert Uytterhoeven
Quoted 8 lines · Arnd Bergmann

Without the frame pointer enabled, return_address() is an inline function and does not need to be exported, as shown by this warning:

WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL

Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.

Thanks for your patch!

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 55

Quoted 6 lines
arch/arm/kernel/return_address.c +0 -0
@@ -53,6 +53,7 @@ void *return_address(unsigned int level)
                return NULL;
 }
 

Checkpatch doesn't like the empty line above:

Quoted 7 lines

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 58

Quoted 5 lines
arch/arm/kernel/return_address.c +2 -1
+EXPORT_SYMBOL_GPL(return_address);
+
 #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
-EXPORT_SYMBOL_GPL(return_address);

What has happened to this patch?

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

I still see this warning.

Simple - it got merged, it caused build regressions, it got dropped. A new version is pending me doing another round of patch merging.

I believe that was not Arnd's patch, but Ben Dooks' alternative solution[*]?

I don't keep track of who did what, sorry.

Quoted 4 lines

[*] Commit 0b0617e5a610fe12 ("ARM: 8918/1: only build return_address() if
needed"), which I discovered in next-20191031 when checking if Arnd's patch was applied....

Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
#7 lore raw

Hi Arnd,

Quoted 41 lines · Russell King - ARM Linux admin
Quoted 39 lines · Geert Uytterhoeven

Hi Russell,

Quoted 35 lines · Russell King - ARM Linux admin
Quoted 34 lines · Masahiro Yamada
Quoted 23 lines · Geert Uytterhoeven
Quoted 8 lines · Arnd Bergmann

Without the frame pointer enabled, return_address() is an inline function and does not need to be exported, as shown by this warning:

WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL

Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.

Thanks for your patch!

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 55

Quoted 6 lines
arch/arm/kernel/return_address.c +0 -0
@@ -53,6 +53,7 @@ void *return_address(unsigned int level)
                return NULL;
 }
 

Checkpatch doesn't like the empty line above:

Quoted 7 lines

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 58

Quoted 5 lines
arch/arm/kernel/return_address.c +2 -1
+EXPORT_SYMBOL_GPL(return_address);
+
 #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
-EXPORT_SYMBOL_GPL(return_address);

What has happened to this patch?

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

I still see this warning.

Simple - it got merged, it caused build regressions, it got dropped. A new version is pending me doing another round of patch merging.

I believe that was not Arnd's patch, but Ben Dooks' alternative solution[*]?

I don't keep track of who did what, sorry.

Arnd,

I believe this patch is the correct fix. Could you please put it into Russell's patch tracker? ([email protected])

Quoted 8 lines
Quoted 4 lines

[*] Commit 0b0617e5a610fe12 ("ARM: 8918/1: only build return_address() if
needed"), which I discovered in next-20191031 when checking if Arnd's patch was applied....

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up

Signature · 2 lines
Best Regards
Masahiro Yamada
#8 lore raw
Quoted 54 lines · Masahiro Yamada

Hi Arnd,

Quoted 48 lines · Russell King - ARM Linux admin
Quoted 45 lines · Geert Uytterhoeven

Hi Russell,

Quoted 31 lines · Russell King - ARM Linux admin
Quoted 30 lines · Masahiro Yamada
Quoted 29 lines · Geert Uytterhoeven
Quoted 8 lines · Arnd Bergmann

Without the frame pointer enabled, return_address() is an inline function and does not need to be exported, as shown by this warning:

WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL

Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.

Thanks for your patch!

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 55

Quoted 6 lines
arch/arm/kernel/return_address.c +0 -0
@@ -53,6 +53,7 @@ void *return_address(unsigned int level)
                return NULL;
 }
 

Checkpatch doesn't like the empty line above:

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

Quoted 4 lines
arch/arm/kernel/return_address.c +2 -0
+EXPORT_SYMBOL_GPL(return_address);
+
 #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 58

Quoted 1 line
arch/arm/kernel/return_address.c +0 -1
-EXPORT_SYMBOL_GPL(return_address);

What has happened to this patch?

I still see this warning.

Simple - it got merged, it caused build regressions, it got dropped. A new version is pending me doing another round of patch merging.

I believe that was not Arnd's patch, but Ben Dooks' alternative solution[*]?

Quoted 8 lines
Quoted 1 line

I don't keep track of who did what, sorry.

Arnd,

I believe this patch is the correct fix. Could you please put it into Russell's patch tracker? ([email protected])

Is there something wrong with:

fb033c95c94c ARM: 8918/2: only build return_address() if needed

I haven't seen any build issues with that.

Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
#9 lore raw

Hi Russell,

Quoted 65 lines · Russell King - ARM Linux admin
Quoted 54 lines · Masahiro Yamada

Hi Arnd,

Quoted 48 lines · Russell King - ARM Linux admin
Quoted 45 lines · Geert Uytterhoeven

Hi Russell,

Quoted 31 lines · Russell King - ARM Linux admin
Quoted 30 lines · Masahiro Yamada
Quoted 29 lines · Geert Uytterhoeven
Quoted 8 lines · Arnd Bergmann

Without the frame pointer enabled, return_address() is an inline function and does not need to be exported, as shown by this warning:

WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL

Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.

Thanks for your patch!

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 55

Quoted 6 lines
arch/arm/kernel/return_address.c +0 -0
@@ -53,6 +53,7 @@ void *return_address(unsigned int level)
                return NULL;
 }
 

Checkpatch doesn't like the empty line above:

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

Quoted 4 lines
arch/arm/kernel/return_address.c +2 -0
+EXPORT_SYMBOL_GPL(return_address);
+
 #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 58

Quoted 1 line
arch/arm/kernel/return_address.c +0 -1
-EXPORT_SYMBOL_GPL(return_address);

What has happened to this patch?

I still see this warning.

Simple - it got merged, it caused build regressions, it got dropped. A new version is pending me doing another round of patch merging.

I believe that was not Arnd's patch, but Ben Dooks' alternative solution[*]?

Quoted 8 lines
Quoted 1 line

I don't keep track of who did what, sorry.

Arnd,

I believe this patch is the correct fix. Could you please put it into Russell's patch tracker? ([email protected])

Quoted 5 lines

Is there something wrong with:

fb033c95c94c ARM: 8918/2: only build return_address() if needed

I haven't seen any build issues with that.

Sorry, I had not checked Ben's patch because you said "Simple - it got merged, it caused build regressions, it got dropped."

Yup, I've checked it right now,
and it looks good to me.

But, I do not see that commit in the latest linux-next (next-20191120).

Could you really apply it if you have not.

Thanks!

--
Best Regards
Masahiro Yamada

#10 lore raw
Quoted 72 lines · Masahiro Yamada

Hi Russell,

Quoted 67 lines · Russell King - ARM Linux admin
Quoted 54 lines · Masahiro Yamada

Hi Arnd,

Quoted 48 lines · Russell King - ARM Linux admin
Quoted 45 lines · Geert Uytterhoeven

Hi Russell,

Quoted 31 lines · Russell King - ARM Linux admin
Quoted 30 lines · Masahiro Yamada
Quoted 29 lines · Geert Uytterhoeven
Quoted 8 lines · Arnd Bergmann

Without the frame pointer enabled, return_address() is an inline function and does not need to be exported, as shown by this warning:

WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL

Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.

Thanks for your patch!

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 55

Quoted 6 lines
arch/arm/kernel/return_address.c +0 -0
@@ -53,6 +53,7 @@ void *return_address(unsigned int level)
                return NULL;
 }
 

Checkpatch doesn't like the empty line above:

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

Quoted 4 lines
arch/arm/kernel/return_address.c +2 -0
+EXPORT_SYMBOL_GPL(return_address);
+
 #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 58

Quoted 1 line
arch/arm/kernel/return_address.c +0 -1
-EXPORT_SYMBOL_GPL(return_address);

What has happened to this patch?

I still see this warning.

Simple - it got merged, it caused build regressions, it got dropped. A new version is pending me doing another round of patch merging.

I believe that was not Arnd's patch, but Ben Dooks' alternative solution[*]?

Quoted 8 lines
Quoted 1 line

I don't keep track of who did what, sorry.

Arnd,

I believe this patch is the correct fix. Could you please put it into Russell's patch tracker? ([email protected])

Is there something wrong with:

Quoted 7 lines
Quoted 3 lines

fb033c95c94c ARM: 8918/2: only build return_address() if needed

I haven't seen any build issues with that.

Sorry, I had not checked Ben's patch because you said "Simple - it got merged, it caused build regressions, it got dropped."

That was 8918/1. Ben fixed his patch, and submitted an updated version.

Quoted 7 lines

Yup, I've checked it right now,
and it looks good to me.

But, I do not see that commit in the latest linux-next (next-20191120).

Could you really apply it if you have not.

It was applied last Friday and was pushed out there and then.

$ git ls-remote zeniv | grep for-next
022eb8ae8b5ee8c5c813923c69b5ebb1e9612c4c        refs/heads/for-next
$ git lg for-next
022eb8ae8b5e ARM: 8938/1: kernel: initialize broadcast hrtimer based
clock event device
...
fb033c95c94c ARM: 8918/2: only build return_address() if needed

I've no idea why linux-next doesn't have it.

Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
#11 lore raw
Quoted 102 lines · Russell King - ARM Linux admin
Quoted 72 lines · Masahiro Yamada

Hi Russell,

Quoted 67 lines · Russell King - ARM Linux admin
Quoted 54 lines · Masahiro Yamada

Hi Arnd,

Quoted 48 lines · Russell King - ARM Linux admin
Quoted 45 lines · Geert Uytterhoeven

Hi Russell,

Quoted 31 lines · Russell King - ARM Linux admin
Quoted 30 lines · Masahiro Yamada
Quoted 29 lines · Geert Uytterhoeven
Quoted 8 lines · Arnd Bergmann

Without the frame pointer enabled, return_address() is an inline function and does not need to be exported, as shown by this warning:

WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL

Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.

Thanks for your patch!

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 55

Quoted 6 lines
arch/arm/kernel/return_address.c +0 -0
@@ -53,6 +53,7 @@ void *return_address(unsigned int level)
                return NULL;
 }
 

Checkpatch doesn't like the empty line above:

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

Quoted 4 lines
arch/arm/kernel/return_address.c +2 -0
+EXPORT_SYMBOL_GPL(return_address);
+
 #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 58

Quoted 1 line
arch/arm/kernel/return_address.c +0 -1
-EXPORT_SYMBOL_GPL(return_address);

What has happened to this patch?

I still see this warning.

Simple - it got merged, it caused build regressions, it got dropped. A new version is pending me doing another round of patch merging.

I believe that was not Arnd's patch, but Ben Dooks' alternative solution[*]?

Quoted 8 lines
Quoted 1 line

I don't keep track of who did what, sorry.

Arnd,

I believe this patch is the correct fix. Could you please put it into Russell's patch tracker? ([email protected])

Is there something wrong with:

Quoted 7 lines
Quoted 3 lines

fb033c95c94c ARM: 8918/2: only build return_address() if needed

I haven't seen any build issues with that.

Sorry, I had not checked Ben's patch because you said "Simple - it got merged, it caused build regressions, it got dropped."

That was 8918/1. Ben fixed his patch, and submitted an updated version.

Quoted 7 lines

Yup, I've checked it right now,
and it looks good to me.

But, I do not see that commit in the latest linux-next (next-20191120).

Could you really apply it if you have not.

It was applied last Friday and was pushed out there and then.

$ git ls-remote zeniv | grep for-next
022eb8ae8b5ee8c5c813923c69b5ebb1e9612c4c        refs/heads/for-next
$ git lg for-next
022eb8ae8b5e ARM: 8938/1: kernel: initialize broadcast hrtimer based
clock event device
...
fb033c95c94c ARM: 8918/2: only build return_address() if needed
Quoted 1 line

I've no idea why linux-next doesn't have it.

Okay, apparently linux-next _does_ have it:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/arch/arm/kernel/Makefile

so I think you're confused.

Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
#12 lore raw
Quoted 104 lines · Russell King - ARM Linux admin
Quoted 102 lines · Russell King - ARM Linux admin
Quoted 72 lines · Masahiro Yamada

Hi Russell,

Quoted 67 lines · Russell King - ARM Linux admin
Quoted 54 lines · Masahiro Yamada

Hi Arnd,

Quoted 48 lines · Russell King - ARM Linux admin
Quoted 45 lines · Geert Uytterhoeven

Hi Russell,

Quoted 31 lines · Russell King - ARM Linux admin
Quoted 30 lines · Masahiro Yamada
Quoted 29 lines · Geert Uytterhoeven
Quoted 8 lines · Arnd Bergmann

Without the frame pointer enabled, return_address() is an inline function and does not need to be exported, as shown by this warning:

WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL

Move the EXPORT_SYMBOL_GPL() into the #ifdef as well.

Thanks for your patch!

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 55

Quoted 6 lines
arch/arm/kernel/return_address.c +0 -0
@@ -53,6 +53,7 @@ void *return_address(unsigned int level)
                return NULL;
 }
 

Checkpatch doesn't like the empty line above:

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

Quoted 4 lines
arch/arm/kernel/return_address.c +2 -0
+EXPORT_SYMBOL_GPL(return_address);
+
 #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

arch/arm/kernel/return_address.c void *return_address(unsigned int level) · line 58

Quoted 1 line
arch/arm/kernel/return_address.c +0 -1
-EXPORT_SYMBOL_GPL(return_address);

What has happened to this patch?

I still see this warning.

Simple - it got merged, it caused build regressions, it got dropped. A new version is pending me doing another round of patch merging.

I believe that was not Arnd's patch, but Ben Dooks' alternative solution[*]?

Quoted 8 lines
Quoted 1 line

I don't keep track of who did what, sorry.

Arnd,

I believe this patch is the correct fix. Could you please put it into Russell's patch tracker? ([email protected])

Is there something wrong with:

Quoted 7 lines
Quoted 3 lines

fb033c95c94c ARM: 8918/2: only build return_address() if needed

I haven't seen any build issues with that.

Sorry, I had not checked Ben's patch because you said "Simple - it got merged, it caused build regressions, it got dropped."

That was 8918/1. Ben fixed his patch, and submitted an updated version.

Quoted 7 lines

Yup, I've checked it right now,
and it looks good to me.

But, I do not see that commit in the latest linux-next (next-20191120).

Could you really apply it if you have not.

It was applied last Friday and was pushed out there and then.

$ git ls-remote zeniv | grep for-next
022eb8ae8b5ee8c5c813923c69b5ebb1e9612c4c        refs/heads/for-next
$ git lg for-next
022eb8ae8b5e ARM: 8938/1: kernel: initialize broadcast hrtimer based
clock event device
...
fb033c95c94c ARM: 8918/2: only build return_address() if needed
Quoted 7 lines
Quoted 1 line

I've no idea why linux-next doesn't have it.

Okay, apparently linux-next _does_ have it:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/arch/arm/kernel/Makefile

so I think you're confused.

My brain was corrupted.

It was my mis-operation of git. I now see it.

--
Best Regards
Masahiro Yamada