linux-user: drop redundant handling of environment variables
PATCH 1/1 linux-user: drop redundant handling of environment variables
QEMU_STRACE and QEMU_RAND_SEED are handled by the parse_args, no need to do it again in main.
Signed-off-by Max Filippov <[email protected]>
--- linux-user/main.c | 7 ------- 1 file changed, 7 deletions(-)
linux-user/main.c +0 -7
@@ -701,13 +701,6 @@ int main(int argc, char **argv, char **envp) thread_cpu = cpu; -if (getenv ("QEMU_STRACE" )) { - do_strace =1 ; - } - -if (seed_optarg ==NULL ) { - seed_optarg =getenv ("QEMU_RAND_SEED" ); - } {Error *err =NULL ;if (seed_optarg !=NULL ) {
Signature · 1 line
2.11.0
Le 06/09/2019 à 18:57, Max Filippov a écrit :
Quoted 17 lines
QEMU_STRACEandQEMU_RAND_SEEDare handled by theparse_args, no need to do it again in main.Signed-off-by Max Filippov <[email protected]>--- linux-user/main.c | 7 ------- 1 file changed, 7 deletions(-)linux-user/main.c +0
-0@@ -701,13 +701,6 @@ int main(int argc, char **argv, char **envp) thread_cpu = cpu;
linux-user/main.c int main(int argc, char **argv, char **envp) · line 706
Quoted 10 lines
linux-user/main.c +0
-7-if (getenv ("QEMU_STRACE" )) { - do_strace =1 ; - } - -if (seed_optarg ==NULL ) { - seed_optarg =getenv ("QEMU_RAND_SEED" ); - } {Error *err =NULL ;if (seed_optarg !=NULL ) {
Reviewed-by Laurent Vivier <[email protected]>
Laurent Vivier
AppliedLe 06/09/2019 à 18:57, Max Filippov a écrit :
Quoted 17 lines
QEMU_STRACEandQEMU_RAND_SEEDare handled by theparse_args, no need to do it again in main.Signed-off-by Max Filippov <[email protected]>--- linux-user/main.c | 7 ------- 1 file changed, 7 deletions(-)linux-user/main.c +0
-0@@ -701,13 +701,6 @@ int main(int argc, char **argv, char **envp) thread_cpu = cpu;
linux-user/main.c int main(int argc, char **argv, char **envp) · line 706
Quoted 10 lines
linux-user/main.c +0
-7-if (getenv ("QEMU_STRACE" )) { - do_strace =1 ; - } - -if (seed_optarg ==NULL ) { - seed_optarg =getenv ("QEMU_RAND_SEED" ); - } {Error *err =NULL ;if (seed_optarg !=NULL ) {
Applied to my linux-user branch.
Thanks,
Laurent