Skip to contentSkip to conversation

Input - elan_i2c: remove Lenovo Legion Y7000 PnpID

PATCH In review Benjamin Tissoires 2 participants 3 messages Sep 6, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input - elan_i2c: remove Lenovo Legion Y7000 PnpID

Looks like the Bios of the Lenovo Legion Y7000 is using ELAN061B when the actual device is supposed to be used with hid-multitouch.

Remove it from the list of the supported device, hoping that no one will complain about the loss in functionality.

Fixes Fixes: 738c06d0e456 ("Input: elan_i2c - add hardware ID for multiple Lenovo laptops")

---

Note to self: once this gets in, we need to send a similar patch to stable, as there are a few stable branches with this PnpID.

 include/linux/input/elan-i2c-ids.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/input/elan-i2c-ids.h +1 -1
index ceabb01a6a7d..1ecb6b45812c 100644
@@ -48,7 +48,7 @@ static const struct acpi_device_id elan_acpi_id[] = {
 	{ "ELAN0618", 0 },
 	{ "ELAN0619", 0 },
 	{ "ELAN061A", 0 },
-	{ "ELAN061B", 0 },
+/*	{ "ELAN061B", 0 }, not working on the Lenovo Legion Y7000 */
 	{ "ELAN061C", 0 },
 	{ "ELAN061D", 0 },
 	{ "ELAN061E", 0 },
Signature · 1 line
2.21.0
maintainer
#1 lore raw
Quoted 9 lines · Benjamin Tissoires

Looks like the Bios of the Lenovo Legion Y7000 is using ELAN061B when the actual device is supposed to be used with hid-multitouch.

Remove it from the list of the supported device, hoping that no one will complain about the loss in functionality.

Fixes Fixes: 738c06d0e456 ("Input: elan_i2c - add hardware ID for multiple Lenovo laptops")

I suppose this one should go to stable?

Quoted 25 lines

---

Note to self: once this gets in, we need to send a similar patch to stable, as there are a few stable branches with this PnpID.

 include/linux/input/elan-i2c-ids.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/input/elan-i2c-ids.h +1 -1
index ceabb01a6a7d..1ecb6b45812c 100644
@@ -48,7 +48,7 @@ static const struct acpi_device_id elan_acpi_id[] = {
 	{ "ELAN0618", 0 },
 	{ "ELAN0619", 0 },
 	{ "ELAN061A", 0 },
-	{ "ELAN061B", 0 },
+/*	{ "ELAN061B", 0 }, not working on the Lenovo Legion Y7000 */
 	{ "ELAN061C", 0 },
 	{ "ELAN061D", 0 },
 	{ "ELAN061E", 0 },
Signature · 1 line
2.21.0
Signature · 1 line
Dmitry
maintainer
#2 lore raw
Quoted 4 lines · Dmitry Torokhov
Quoted 3 lines · Benjamin Tissoires

Looks like the Bios of the Lenovo Legion Y7000 is using ELAN061B when the actual device is supposed to be used with hid-multitouch.

Quoted 8 lines
Quoted 6 lines

Remove it from the list of the supported device, hoping that no one will complain about the loss in functionality.

Fixes Fixes: 738c06d0e456 ("Input: elan_i2c - add hardware ID for multiple Lenovo laptops")

I suppose this one should go to stable?

Gah, I am not very attentive, as you just said it below. Sorry.

Quoted 29 lines
Quoted 26 lines

---

Note to self: once this gets in, we need to send a similar patch to stable, as there are a few stable branches with this PnpID.

 include/linux/input/elan-i2c-ids.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/input/elan-i2c-ids.h +1 -1
index ceabb01a6a7d..1ecb6b45812c 100644
@@ -48,7 +48,7 @@ static const struct acpi_device_id elan_acpi_id[] = {
 	{ "ELAN0618", 0 },
 	{ "ELAN0619", 0 },
 	{ "ELAN061A", 0 },
-	{ "ELAN061B", 0 },
+/*	{ "ELAN061B", 0 }, not working on the Lenovo Legion Y7000 */
 	{ "ELAN061C", 0 },
 	{ "ELAN061D", 0 },
 	{ "ELAN061E", 0 },
Signature · 1 line
2.21.0
Signature · 1 line
Dmitry
Signature · 1 line
Dmitry