bus: ti-sysc: Remove unpaired sysc_clkdm_deny_idle()
Tony Lindgren
maintainerPATCH 1/1 bus: ti-sysc: Remove unpaired sysc_clkdm_deny_idle()
Commit d098913a10f8 ("bus: ti-sysc: Fix clock handling for no-idle quirks") fixed handling for no-idle quirk modules that are not enabled by the bootloader.
But it also caused unpaired clockdomain calls that won't allow idling the system. That's because clkdm_allow_idle_nolock() and clkdm_deny_idle_nolock() have usage count with clkdm->forcewake_count.
Let's drop the unpaired sysc_clkdm_deny_idle() to fix idling of devices.
--- drivers/bus/ti-sysc.c | 1 - 1 file changed, 1 deletion(-)
drivers/bus/ti-sysc.c +0 -1
@@ -2363,7 +2363,6 @@ static void ti_sysc_idle(struct work_struct *work)*/ if (ddata->cfg.quirks & (SYSC_QUIRK_NO_IDLE |SYSC_QUIRK_NO_IDLE_ON_INIT )) { -sysc_clkdm_deny_idle (ddata);sysc_disable_main_clocks (ddata);sysc_disable_opt_clocks (ddata);sysc_clkdm_allow_idle (ddata);
Signature · 1 line
2.23.0
Quoted 9 lines · Tony Lindgren
Commit
d098913a10f8("bus: ti-sysc: Fix clock handling for no-idle quirks") fixed handling for no-idle quirk modules that are not enabled by the bootloader.But it also caused unpaired clockdomain calls that won't allow idling the system. That's because
clkdm_allow_idle_nolock()andclkdm_deny_idle_nolock()have usage count withclkdm->forcewake_count.Let's drop the unpaired
sysc_clkdm_deny_idle()to fix idling of devices.
I believe still the previous fix [1] for nfs boot is still not on linux-next. Are you planning on more testing or it will be queued as fixes?
[1] https://lkml.org/lkml/2019/9/5/616
- Keerthy
Quoted 21 lines
Fixes d098913a10f8 ("bus: ti-sysc: Fix clock handling for no-idle quirks")Cc Keerthy <[email protected]>Cc Vignesh Raghavendra <[email protected]>Signed-off-by Tony Lindgren <[email protected]>--- drivers/bus/ti-sysc.c | 1 - 1 file changed, 1 deletion(-)drivers/bus/ti-sysc.c +0
-1@@ -2363,7 +2363,6 @@ static void ti_sysc_idle(struct work_struct *work)*/ if (ddata->cfg.quirks & (SYSC_QUIRK_NO_IDLE |SYSC_QUIRK_NO_IDLE_ON_INIT )) { -sysc_clkdm_deny_idle (ddata);sysc_disable_main_clocks (ddata);sysc_disable_opt_clocks (ddata);sysc_clkdm_allow_idle (ddata);
Tony Lindgren
maintainerHi,
Quoted 2 lines · Keerthy
I believe still the previous fix [1] for nfs boot is still not on linux-next. Are you planning on more testing or it will be queued as fixes?
I pushed out the pending fixes on Saturday so they should be in the next version of Linux next.
Regards,
Tony