Status of led-backlight driver

DISCUSSION Pavel Machek 3 participants 4 messages Sep 7, 2019 – Sep 9, 2019

Share & tools

Pavel Machek

author

2019-09-07 10:07 UTC #0 lore raw

Hi!

I don't see the LED-backlight driver in -next. Could it be pushed? It is one of last pieces to get working backlight on Motorola Droid 4...

Best regards,
Pavel

Signature · 2 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Daniel Thompson

2019-09-09 11:14 UTC #1 lore raw

Quoted 4 lines · Pavel Machek

Hi!
I don't see the LED-backlight driver in -next. Could it be pushed? It is one of last pieces to get working backlight on Motorola Droid 4...

Sorry, I dropped the ball on this and was therefore rather late reviewing this patchset.

Assuming I have read the code correctly I think there are some problems with the max_brightness handling in the backlight code.

Daniel.

Jean-Jacques Hiblot

2019-09-09 11:46 UTC #2 lore raw

Hi Daniel,

Quoted 10 lines · Daniel Thompson

Quoted 4 lines · Pavel Machek
Hi!
I don't see the LED-backlight driver in -next. Could it be pushed? It is one of last pieces to get working backlight on Motorola Droid 4...
Sorry, I dropped the ball on this and was therefore rather late reviewing this patchset.
Assuming I have read the code correctly I think there are some problems with the max_brightness handling in the backlight code.

Can you comment this? I'll be happy to fix the problem.

Reading the v4 again, I noticed that that I still had not removed the brightness scaling. Is that the problem ?

Quoted 4 lines

Daniel.

Daniel Thompson

2019-09-09 13:04 UTC #3 lore raw

Quoted 8 lines · Jean-Jacques Hiblot

Hi Daniel,
Quoted 5 lines · Daniel Thompson
Quoted 4 lines · Pavel Machek
Hi!
I don't see the LED-backlight driver in -next. Could it be pushed? It is one of last pieces to get working backlight on Motorola Droid 4...

Quoted 7 lines

Quoted 5 lines
Sorry, I dropped the ball on this and was therefore rather late reviewing this patchset.
Assuming I have read the code correctly I think there are some problems with the max_brightness handling in the backlight code.
Can you comment this? I'll be happy to fix the problem.

I did that before replying to the nudges. See:
https://lore.kernel.org/linux-leds/[email protected]/

Quoted 2 lines

Reading the v4 again, I noticed that that I still had not removed the brightness scaling. Is that the problem ?

Yes (plus a couple of nits).

Daniel.