dt-bindings: memory-controllers: Convert Samsung Exynos SROM bindings to json-schema
Subsystems (3)
Krzysztof Kozlowski
maintainerPATCH 1/1 dt-bindings: memory-controllers: Convert Samsung Exynos SROM bindings to json-schema
Convert Samsung Exynos SROM controller bindings to DT schema format using json-schema.
--- .../memory-controllers/exynos-srom.txt | 79 ---------- .../memory-controllers/exynos-srom.yaml | 136 ++++++++++++++++++ 2 files changed, 136 insertions(+), 79 deletions(-) delete mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt create mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml
Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt deleted +0 -79
@@ -1,79 +0,0 @@ -SAMSUNG Exynos SoCs SROM Controller driver. - -Required properties: -- compatible : Should contain "samsung,exynos4210-srom". - -- reg: offset and length of the register set - -Optional properties: -The SROM controller can be used to attach external peripherals. In this case -extra properties, describing the bus behind it, should be specified as below: - -- #address-cells: Must be set to 2 to allow device address translation. - Address is specified as (bank#, offset). - -- #size-cells: Must be set to 1 to allow device size passing - -- ranges: Must be set up to reflect the memory layout with four integer values - per bank: - <bank-number> 0 <parent address of bank> <size> - -Sub-nodes: -The actual device nodes should be added as subnodes to the SROMc node. These -subnodes, in addition to regular device specification, should contain the following -properties, describing configuration of the relevant SROM bank: - -Required properties: -- reg: bank number, base address (relative to start of the bank) and size of - the memory mapped for the device. Note that base address will be - typically 0 as this is the start of the bank. - -- samsung,srom-timing : array of 6 integers, specifying bank timings in the - following order: Tacp, Tcah, Tcoh, Tacc, Tcos, Tacs. - Each value is specified in cycles and has the following - meaning and valid range: - Tacp : Page mode access cycle at Page mode (0 - 15) - Tcah : Address holding time after CSn (0 - 15) - Tcoh : Chip selection hold on OEn (0 - 15) - Tacc : Access cycle (0 - 31, the actual time is N + 1) - Tcos : Chip selection set-up before OEn (0 - 15) - Tacs : Address set-up before CSn (0 - 15) - -Optional properties: -- reg-io-width : data width in bytes (1 or 2). If omitted, default of 1 is used. - -- samsung,srom-page-mode : if page mode is set, 4 data page mode will be configured, - else normal (1 data) page mode will be set. - -Example: basic definition, no banks are configured - memory-controller@12570000 { - compatible = "samsung,exynos4210-srom"; - reg = <0x12570000 0x14>; - }; - -Example: SROMc with SMSC911x ethernet chip on bank 3 - memory-controller@12570000 { - #address-cells = <2>; - #size-cells = <1>; - ranges = <0 0 0x04000000 0x20000 // Bank0 - 1 0 0x05000000 0x20000 // Bank1 - 2 0 0x06000000 0x20000 // Bank2 - 3 0 0x07000000 0x20000>; // Bank3 - - compatible = "samsung,exynos4210-srom"; - reg = <0x12570000 0x14>; - - ethernet@3,0 { - compatible = "smsc,lan9115"; - reg = <3 0 0x10000>; // Bank 3, offset = 0 - phy-mode = "mii"; - interrupt-parent = <&gpx0>; - interrupts = <5 8>; - reg-io-width = <2>; - smsc,irq-push-pull; - smsc,force-internal-phy; - - samsung,srom-page-mode; - samsung,srom-timing = <9 12 1 9 1 1>; - }; - };
Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml new file +136 -0
136 lines not on this page · raw message
Signature · 1 line
2.17.1
Rob Herring
maintainerQuoted 44 lines · Krzysztof Kozlowski
Convert Samsung Exynos SROM controller bindings to DT schema format using json-schema.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- .../memory-controllers/exynos-srom.txt | 79 ---------- .../memory-controllers/exynos-srom.yaml | 136 ++++++++++++++++++ 2 files changed, 136 insertions(+), 79 deletions(-) delete mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt create mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos-srom.yamlDocumentation/devicetree/bindings/memory-controllers/exynos-srom.yaml new file +26
-0@@ -0,0 +1,136 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/memory-controllers/exynos-srom.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung Exynos SoC SROM Controller driver + +maintainers: + - Krzysztof Kozlowski <[email protected]> + +description: |+ + The SROM controller can be used to attach external peripherals. In this case + extra properties, describing the bus behind it, should be specified. + +properties: + compatible: + items: + - const: samsung,exynos4210-srom + + reg: + maxItems: 1 + + "#address-cells": + const: 2 +
Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml line 36
Quoted 10 lines
Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml new file +10
-0+ "#size-cells": + const: 1 + + ranges: + description: | + Reflects the memory layout with four integer values per bank. Format: + <bank-number> 0 <parent address of bank> <size> + +patternProperties: + "^.*@[0-9]+,[0-9]+$":
How many chip selects? Can be a single digit?
Also, these should be hex values.
Quoted 55 lines
Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml new file +55
-0+ type: object + description: + The actual device nodes should be added as subnodes to the SROMc node. + These subnodes, in addition to regular device specification, should + contain the following properties, describing configuration + of the relevant SROM bank. + + properties: + reg: + description: + Bank number, base address (relative to start of the bank) and size + of the memory mapped for the device. Note that base address will be + typically 0 as this is the start of the bank. + maxItems: 1 + + reg-io-width: + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [1, 2] + description: + Data width in bytes (1 or 2). If omitted, default of 1 is used. + + samsung,srom-page-mode: + description: + If page mode is set, 4 data page mode will be configured, + else normal (1 data) page mode will be set. + type: boolean + + samsung,srom-timing: + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32-array + - items: + minItems: 6 + maxItems: 6 + description: | + Array of 6 integers, specifying bank timings in the following order: + Tacp, Tcah, Tcoh, Tacc, Tcos, Tacs. + Each value is specified in cycles and has the following meaning + and valid range: + Tacp: Page mode access cycle at Page mode (0 - 15) + Tcah: Address holding time after CSn (0 - 15) + Tcoh: Chip selection hold on OEn (0 - 15) + Tacc: Access cycle (0 - 31, the actual time is N + 1) + Tcos: Chip selection set-up before OEn (0 - 15) + Tacs: Address set-up before CSn (0 - 15) + + required: + - reg + - samsung,srom-timing + +required: + - compatible + - reg + +allOf:
Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml line 101
Quoted 10 lines
Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml new file +10
-0+ - if: + anyOf: + - required: [ "#address-cells" ] + - required: [ ranges ] + - required: [ "#size-cells" ] + then: + required: + - "#address-cells" + - ranges + - "#size-cells"
I don't think this is necessary as the core schema should take care of it. This can also be expressed using 'dependencies'.
Rob
Krzysztof Kozlowski
maintainerQuoted 50 lines · Rob Herring
Quoted 48 lines · Krzysztof Kozlowski
Convert Samsung Exynos SROM controller bindings to DT schema format using json-schema.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- .../memory-controllers/exynos-srom.txt | 79 ---------- .../memory-controllers/exynos-srom.yaml | 136 ++++++++++++++++++ 2 files changed, 136 insertions(+), 79 deletions(-) delete mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt create mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos-srom.yamlDocumentation/devicetree/bindings/memory-controllers/exynos-srom.yaml new file +30
-0@@ -0,0 +1,136 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/memory-controllers/exynos-srom.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung Exynos SoC SROM Controller driver + +maintainers: + - Krzysztof Kozlowski <[email protected]> + +description: |+ + The SROM controller can be used to attach external peripherals. In this case + extra properties, describing the bus behind it, should be specified. + +properties: + compatible: + items: + - const: samsung,exynos4210-srom + + reg: + maxItems: 1 + + "#address-cells": + const: 2 + + "#size-cells": + const: 1 + + ranges:
Quoted 8 lines
Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml line 36
Quoted 6 lines
Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml new file +6
-0+ description: | + Reflects the memory layout with four integer values per bank. Format: + <bank-number> 0 <parent address of bank> <size> + +patternProperties: + "^.*@[0-9]+,[0-9]+$":How many chip selects? Can be a single digit?
Currently up to four banks, so I can limit the pattern.
Quoted 2 lines
Also, these should be hex values.
Sure.
Quoted 61 lines
Quoted 61 lines
Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml new file +60
-0+ type: object + description: + The actual device nodes should be added as subnodes to the SROMc node. + These subnodes, in addition to regular device specification, should + contain the following properties, describing configuration + of the relevant SROM bank. + + properties: + reg: + description: + Bank number, base address (relative to start of the bank) and size + of the memory mapped for the device. Note that base address will be + typically 0 as this is the start of the bank. + maxItems: 1 + + reg-io-width: + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [1, 2] + description: + Data width in bytes (1 or 2). If omitted, default of 1 is used. + + samsung,srom-page-mode: + description: + If page mode is set, 4 data page mode will be configured, + else normal (1 data) page mode will be set. + type: boolean + + samsung,srom-timing: + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32-array + - items: + minItems: 6 + maxItems: 6 + description: | + Array of 6 integers, specifying bank timings in the following order: + Tacp, Tcah, Tcoh, Tacc, Tcos, Tacs. + Each value is specified in cycles and has the following meaning + and valid range: + Tacp: Page mode access cycle at Page mode (0 - 15) + Tcah: Address holding time after CSn (0 - 15) + Tcoh: Chip selection hold on OEn (0 - 15) + Tacc: Access cycle (0 - 31, the actual time is N + 1) + Tcos: Chip selection set-up before OEn (0 - 15) + Tacs: Address set-up before CSn (0 - 15) + + required: + - reg + - samsung,srom-timing + +required: + - compatible + - reg + +allOf: + - if: + anyOf: + - required: [ "#address-cells" ] + - required: [ ranges ] + - required: [ "#size-cells" ]
Quoted 8 lines
Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml line 101
Quoted 5 lines
Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml new file +5
-0+ then: + required: + - "#address-cells" + - ranges + - "#size-cells"I don't think this is necessary as the core schema should take care of it. This can also be expressed using 'dependencies'.
I'll skip it then.
Best regards,
Krzysztof