dt-bindings: watchdog: Convert Samsung SoC watchdog bindings to json-schema
Subsystems (2)
PATCH 1/2 dt-bindings: watchdog: Convert Samsung SoC watchdog bindings to json-schema
Convert Samsung S3C/S5P/Exynos watchdog bindings to DT schema format using json-schema.
Signed-off-by Krzysztof Kozlowski <[email protected]>
--- .../bindings/watchdog/samsung-wdt.txt | 35 ---------- .../bindings/watchdog/samsung-wdt.yaml | 69 +++++++++++++++++++ 2 files changed, 69 insertions(+), 35 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
Documentation/devicetree/bindings/watchdog/samsung-wdt.txt deleted +0 -35
@@ -1,35 +0,0 @@ -* Samsung's Watchdog Timer Controller - -The Samsung's Watchdog controller is used for resuming system operation -after a preset amount of time during which the WDT reset event has not -occurred. - -Required properties: -- compatible : should be one among the following - - "samsung,s3c2410-wdt" for S3C2410 - - "samsung,s3c6410-wdt" for S3C6410, S5PV210 and Exynos4 - - "samsung,exynos5250-wdt" for Exynos5250 - - "samsung,exynos5420-wdt" for Exynos5420 - - "samsung,exynos7-wdt" for Exynos7 - -- reg : base physical address of the controller and length of memory mapped - region. -- interrupts : interrupt number to the cpu. -- samsung,syscon-phandle : reference to syscon node (This property required only - in case of compatible being "samsung,exynos5250-wdt" or "samsung,exynos5420-wdt". - In case of Exynos5250 and 5420 this property points to syscon node holding the PMU - base address) - -Optional properties: -- timeout-sec : contains the watchdog timeout in seconds. - -Example: - -watchdog@101d0000 { - compatible = "samsung,exynos5250-wdt"; - reg = <0x101D0000 0x100>; - interrupts = <0 42 0>; - clocks = <&clock 336>; - clock-names = "watchdog"; - samsung,syscon-phandle = <&pmu_syscon>; -};
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml new file +69 -0
69 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH 2/2 dt-bindings: watchdog: Add missing clocks requirement in Samsung SoC watchdog
The Samsung SoC watchdog driver always required providing a clock (either through platform data or from DT). However when bindings were added in commit 9487a9cc7140 ("watchdog: s3c2410: Add support for device tree based probe"), they missed the requirement of clock.
Signed-off-by Krzysztof Kozlowski <[email protected]>
--- .../devicetree/bindings/watchdog/samsung-wdt.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml +7 -0
@@ -26,6 +26,13 @@ properties: reg: maxItems: 1 + clocks: + maxItems: 1 + + clock-names: + items: + - const: watchdog + interrupts: maxItems: 1
Signature · 1 line
2.17.1
Re: [PATCH 2/2] dt-bindings: watchdog: Add missing clocks requirement in Samsung SoC watchdog
Quoted 10 lines · Krzysztof Kozlowski
The Samsung SoC watchdog driver always required providing a clock (either through platform data or from DT). However when bindings were added in commit
9487a9cc7140("watchdog: s3c2410: Add support for device tree based probe"), they missed the requirement of clock.Signed-off-by Krzysztof Kozlowski <[email protected]>--- .../devicetree/bindings/watchdog/samsung-wdt.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
Reviewed-by Rob Herring <[email protected]>
Rob Herring
maintainerQuoted 49 lines · Krzysztof Kozlowski
Convert Samsung S3C/S5P/Exynos watchdog bindings to DT schema format using json-schema.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- .../bindings/watchdog/samsung-wdt.txt | 35 ---------- .../bindings/watchdog/samsung-wdt.yaml | 69 +++++++++++++++++++ 2 files changed, 69 insertions(+), 35 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.yamlDocumentation/devicetree/bindings/watchdog/samsung-wdt.yaml new file +31
-0@@ -0,0 +1,69 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/samsung-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung SoC Watchdog Timer Controller + +maintainers: + - Krzysztof Kozlowski <[email protected]> + +description: |+ + The Samsung's Watchdog controller is used for resuming system operation + after a preset amount of time during which the WDT reset event has not + occurred. + +properties: + compatible: + enum: + - samsung,s3c2410-wdt # for S3C2410 + - samsung,s3c6410-wdt # for S3C6410, S5PV210 and Exynos4 + - samsung,exynos5250-wdt # for Exynos5250 + - samsung,exynos5420-wdt # for Exynos5420 + - samsung,exynos7-wdt # for Exynos7 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 +
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml line 41
Quoted 10 lines
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml new file +10
-0+ samsung,syscon-phandle: + $ref: '/schemas/types.yaml#/definitions/phandle' + description: + Phandle to the PMU system controller node (in case of Exynos5250 + and Exynos5420). + + timeout-sec: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Watchdog timeout in seconds.
We need a common schema for this and the node name.
Also note that anything with a unit suffix already has a type definition, so we don't really need to define it again.
Quoted 31 lines
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml new file +28
-0+ +required: + - compatible + - interrupts + - reg + +allOf: + - if: + properties: + compatible: + contains: + enum: + - samsung,exynos5250-wdt + - samsung,exynos5420-wdt + then: + required: + - samsung,syscon-phandle + +examples: + - | + watchdog@101d0000 { + compatible = "samsung,exynos5250-wdt"; + reg = <0x101D0000 0x100>; + interrupts = <0 42 0>; + clocks = <&clock 336>; + clock-names = "watchdog"; + samsung,syscon-phandle = <&pmu_syscon>; + };Signature · 1 line
2.17.1
Quoted 55 lines · Rob Herring
Quoted 53 lines · Krzysztof Kozlowski
Convert Samsung S3C/S5P/Exynos watchdog bindings to DT schema format using json-schema.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- .../bindings/watchdog/samsung-wdt.txt | 35 ---------- .../bindings/watchdog/samsung-wdt.yaml | 69 +++++++++++++++++++ 2 files changed, 69 insertions(+), 35 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.yamlDocumentation/devicetree/bindings/watchdog/samsung-wdt.yaml new file +35
-0@@ -0,0 +1,69 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/samsung-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung SoC Watchdog Timer Controller + +maintainers: + - Krzysztof Kozlowski <[email protected]> + +description: |+ + The Samsung's Watchdog controller is used for resuming system operation + after a preset amount of time during which the WDT reset event has not + occurred. + +properties: + compatible: + enum: + - samsung,s3c2410-wdt # for S3C2410 + - samsung,s3c6410-wdt # for S3C6410, S5PV210 and Exynos4 + - samsung,exynos5250-wdt # for Exynos5250 + - samsung,exynos5420-wdt # for Exynos5420 + - samsung,exynos7-wdt # for Exynos7 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + samsung,syscon-phandle: + $ref: '/schemas/types.yaml#/definitions/phandle' + description: + Phandle to the PMU system controller node (in case of Exynos5250
Quoted 8 lines
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml line 41
Quoted 6 lines
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml new file +6
-0+ and Exynos5420). + + timeout-sec: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Watchdog timeout in seconds.We need a common schema for this and the node name.
Common schema in dt-schema or in Linux kernel bindings? If the latter, I can add it.
Quoted 2 lines
Also note that anything with a unit suffix already has a type definition, so we don't really need to define it again.
Right.
Best regards,
Krzysztof
Rob Herring
maintainerQuoted 66 lines · Krzysztof Kozlowski
Quoted 55 lines · Rob Herring
Quoted 53 lines · Krzysztof Kozlowski
Convert Samsung S3C/S5P/Exynos watchdog bindings to DT schema format using json-schema.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- .../bindings/watchdog/samsung-wdt.txt | 35 ---------- .../bindings/watchdog/samsung-wdt.yaml | 69 +++++++++++++++++++ 2 files changed, 69 insertions(+), 35 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.yamlDocumentation/devicetree/bindings/watchdog/samsung-wdt.yaml new file +35
-0@@ -0,0 +1,69 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/samsung-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung SoC Watchdog Timer Controller + +maintainers: + - Krzysztof Kozlowski <[email protected]> + +description: |+ + The Samsung's Watchdog controller is used for resuming system operation + after a preset amount of time during which the WDT reset event has not + occurred. + +properties: + compatible: + enum: + - samsung,s3c2410-wdt # for S3C2410 + - samsung,s3c6410-wdt # for S3C6410, S5PV210 and Exynos4 + - samsung,exynos5250-wdt # for Exynos5250 + - samsung,exynos5420-wdt # for Exynos5420 + - samsung,exynos7-wdt # for Exynos7 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + samsung,syscon-phandle: + $ref: '/schemas/types.yaml#/definitions/phandle' + description: + Phandle to the PMU system controller node (in case of Exynos5250Quoted 8 lines
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml line 41
Quoted 6 lines
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml new file +6
-0+ and Exynos5420). + + timeout-sec: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Watchdog timeout in seconds.We need a common schema for this and the node name.
Quoted 2 lines
Common schema in dt-schema or in Linux kernel bindings? If the latter, I can add it.
In the kernel is fine.
Rob
Rob Herring
maintainerQuoted 68 lines · Rob Herring
Quoted 66 lines · Krzysztof Kozlowski
Quoted 63 lines · Rob Herring
Quoted 49 lines · Krzysztof Kozlowski
Convert Samsung S3C/S5P/Exynos watchdog bindings to DT schema format using json-schema.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- .../bindings/watchdog/samsung-wdt.txt | 35 ---------- .../bindings/watchdog/samsung-wdt.yaml | 69 +++++++++++++++++++ 2 files changed, 69 insertions(+), 35 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.yamlDocumentation/devicetree/bindings/watchdog/samsung-wdt.yaml new file +31
-0@@ -0,0 +1,69 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/samsung-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung SoC Watchdog Timer Controller + +maintainers: + - Krzysztof Kozlowski <[email protected]> + +description: |+ + The Samsung's Watchdog controller is used for resuming system operation + after a preset amount of time during which the WDT reset event has not + occurred. + +properties: + compatible: + enum: + - samsung,s3c2410-wdt # for S3C2410 + - samsung,s3c6410-wdt # for S3C6410, S5PV210 and Exynos4 + - samsung,exynos5250-wdt # for Exynos5250 + - samsung,exynos5420-wdt # for Exynos5420 + - samsung,exynos7-wdt # for Exynos7 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 +Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml line 41
Quoted 10 lines
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml new file +10
-0+ samsung,syscon-phandle: + $ref: '/schemas/types.yaml#/definitions/phandle' + description: + Phandle to the PMU system controller node (in case of Exynos5250 + and Exynos5420). + + timeout-sec: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Watchdog timeout in seconds.We need a common schema for this and the node name.
Quoted 4 lines
Quoted 2 lines
Common schema in dt-schema or in Linux kernel bindings? If the latter, I can add it.
In the kernel is fine.
Actually, Maxime has already done one.
Rob
Quoted 69 lines · Rob Herring
Quoted 68 lines · Rob Herring
Quoted 66 lines · Krzysztof Kozlowski
Quoted 63 lines · Rob Herring
Quoted 49 lines · Krzysztof Kozlowski
Convert Samsung S3C/S5P/Exynos watchdog bindings to DT schema format using json-schema.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- .../bindings/watchdog/samsung-wdt.txt | 35 ---------- .../bindings/watchdog/samsung-wdt.yaml | 69 +++++++++++++++++++ 2 files changed, 69 insertions(+), 35 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.yamlDocumentation/devicetree/bindings/watchdog/samsung-wdt.yaml new file +31
-0@@ -0,0 +1,69 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/samsung-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung SoC Watchdog Timer Controller + +maintainers: + - Krzysztof Kozlowski <[email protected]> + +description: |+ + The Samsung's Watchdog controller is used for resuming system operation + after a preset amount of time during which the WDT reset event has not + occurred. + +properties: + compatible: + enum: + - samsung,s3c2410-wdt # for S3C2410 + - samsung,s3c6410-wdt # for S3C6410, S5PV210 and Exynos4 + - samsung,exynos5250-wdt # for Exynos5250 + - samsung,exynos5420-wdt # for Exynos5420 + - samsung,exynos7-wdt # for Exynos7 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 +Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml line 41
Quoted 10 lines
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml new file +10
-0+ samsung,syscon-phandle: + $ref: '/schemas/types.yaml#/definitions/phandle' + description: + Phandle to the PMU system controller node (in case of Exynos5250 + and Exynos5420). + + timeout-sec: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Watchdog timeout in seconds.We need a common schema for this and the node name.
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Common schema in dt-schema or in Linux kernel bindings? If the latter, I can add it.
In the kernel is fine.
Actually, Maxime has already done one.
I see. I'll use them then.
Best regards,
Krzysztof
Quoted 67 lines · Rob Herring
Quoted 66 lines · Krzysztof Kozlowski
Quoted 63 lines · Rob Herring
Quoted 49 lines · Krzysztof Kozlowski
Convert Samsung S3C/S5P/Exynos watchdog bindings to DT schema format using json-schema.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- .../bindings/watchdog/samsung-wdt.txt | 35 ---------- .../bindings/watchdog/samsung-wdt.yaml | 69 +++++++++++++++++++ 2 files changed, 69 insertions(+), 35 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.yamlDocumentation/devicetree/bindings/watchdog/samsung-wdt.yaml new file +31
-0@@ -0,0 +1,69 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/samsung-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung SoC Watchdog Timer Controller + +maintainers: + - Krzysztof Kozlowski <[email protected]> + +description: |+ + The Samsung's Watchdog controller is used for resuming system operation + after a preset amount of time during which the WDT reset event has not + occurred. + +properties: + compatible: + enum: + - samsung,s3c2410-wdt # for S3C2410 + - samsung,s3c6410-wdt # for S3C6410, S5PV210 and Exynos4 + - samsung,exynos5250-wdt # for Exynos5250 + - samsung,exynos5420-wdt # for Exynos5420 + - samsung,exynos7-wdt # for Exynos7 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 +Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml line 41
Quoted 10 lines
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml new file +10
-0+ samsung,syscon-phandle: + $ref: '/schemas/types.yaml#/definitions/phandle' + description: + Phandle to the PMU system controller node (in case of Exynos5250 + and Exynos5420). + + timeout-sec: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Watchdog timeout in seconds.We need a common schema for this and the node name.
Quoted 4 lines
Quoted 2 lines
Common schema in dt-schema or in Linux kernel bindings? If the latter, I can add it.
In the kernel is fine.
I'll add it in next version then.
Best regards,
Krzysztof