x86/boot: Improve code generation from bootsym()
PATCH 1/1 x86/boot: Improve code generation from bootsym()
The code generation for bootsym() is atrocious, and unnecesserily complicated. Given the appropriate physical address, all we need is to construct a virtual address of the appropriate type.
add/remove: 0/0 grow/shrink: 0/9 up/down: 0/-4256 (-4256)
Function old new delta kexec_reserve_area.constprop 165 159 -6 reset_videomode_after_s3 231 70 -161 identify_cpu 1341 1176 -165 parse_acpi_sleep 408 240 -168 early_init_intel 632 440 -192 __cpu_up 1983 1682 -301 do_platform_op 6469 5526 -943 compat_platform_op 6433 5482 -951
__start_xen 12939 11570 -1369
Total: Before=3341298, After=3337042, chg -0.13%
No functional change.
---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>
--- xen/include/asm-x86/config.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
xen/include/asm-x86/config.h +2 -2
@@ -91,8 +91,8 @@ extern unsigned long trampoline_phys;#define bootsym_phys (sym) \ (((unsigned long)&(sym)-(unsigned long)&trampoline_start)+trampoline_phys)#define bootsym (sym) \ - (*RELOC_HIDE((typeof(&(sym)))__va(__pa(&(sym))), \ - trampoline_phys-__pa(trampoline_start))) + (*((typeof(sym) *)__va(bootsym_phys(sym)))) +extern char trampoline_start[], trampoline_end[];extern char trampoline_realmode_entry[];extern unsigned int trampoline_xen_phys_start;
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 14 lines · Andrew Cooper
The code generation for
bootsym()is atrocious, and unnecesserily complicated. Given the appropriate physical address, all we need is to construct a virtual address of the appropriate type.add/remove: 0/0 grow/shrink: 0/9 up/down: 0/-4256 (-4256)
Function old new delta kexec_reserve_area.constprop 165 159 -6 reset_videomode_after_s3 231 70 -161 identify_cpu 1341 1176 -165 parse_acpi_sleep 408 240 -168 early_init_intel 632 440 -192 __cpu_up 1983 1682 -301 do_platform_op 6469 5526 -943 compat_platform_op 6433 5482 -951
Quoted 6 lines
__start_xen12939 11570 -1369
Total: Before=3341298, After=3337042, chg -0.13%No functional change.
Signed-off-by Andrew Cooper <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel