Skip to contentSkip to conversation

reset: reset-scmi: add missing handle initialisation

PATCH In review Sudeep Holla 2 participants 2 messages Sep 9, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reset: reset-scmi: add missing handle initialisation

scmi_reset_data->handle needs to be initialised at probe, so that it can be used to access scmi reset protocol apis using the same later.

Since it was tested with a module that obtained handle elsewhere, it was missed easily. Add the missing scmi_reset_data->handle initialisation to fix the issue.

Fixes c8ae9c2da1cc ("reset: Add support for resets provided by SCMI")
Cc Philipp Zabel <[email protected]>
---
 drivers/reset/reset-scmi.c | 1 +
 1 file changed, 1 insertion(+)

Hi Philipp,

I can either take this via ARM SoC as the driver is getting merged through ARM SoC tree, or you can apply this once it gets landed in mainline. I am fine with whatever you prefer.

Regards,
Sudeep

drivers/reset/reset-scmi.c +1 -0
index c6d3c8427f14..b46df80ec6c3 100644
@@ -102,6 +102,7 @@ static int scmi_reset_probe(struct scmi_device *sdev)
 	data->rcdev.owner = THIS_MODULE;
 	data->rcdev.of_node = np;
 	data->rcdev.nr_resets = handle->reset_ops->num_domains_get(handle);
+	data->handle = handle;
 
 	return devm_reset_controller_register(dev, &data->rcdev);
 }

--
2.17.1

maintainer Acked-by on v1 1/1
#1 lore raw

Hi Sudeep,

Quoted 15 lines · Sudeep Holla

scmi_reset_data->handle needs to be initialised at probe, so that it can be used to access scmi reset protocol apis using the same later.

Since it was tested with a module that obtained handle elsewhere, it was missed easily. Add the missing scmi_reset_data->handle initialisation to fix the issue.

Fixes c8ae9c2da1cc ("reset: Add support for resets provided by SCMI")
Cc Philipp Zabel <[email protected]>
---
 drivers/reset/reset-scmi.c | 1 +
 1 file changed, 1 insertion(+)
Quoted 5 lines

Hi Philipp,

I can either take this via ARM SoC as the driver is getting merged through ARM SoC tree, or you can apply this once it gets landed in mainline. I am fine with whatever you prefer.

Feel free to take this in via ARM SoC directly, I see no need to wait for this to hit mainline.

regards
Philipp