Skip to contentSkip to conversation

bootcount: add support to customize bootcount variable name

RFC PATCH New Philippe Reynes 2 participants 4 messages Sep 9, 2019 – Sep 10, 2019

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 bootcount: add support to customize bootcount variable name

This commit add an option to customize the bootcount variable name in the u-boot environment. To stay compatible with old config, the default name is bootcount.

---
 drivers/bootcount/Kconfig         | 8 ++++++++
 drivers/bootcount/bootcount_env.c | 4 ++--
 2 files changed, 10 insertions(+), 2 deletions(-)
drivers/bootcount/Kconfig +8 -0
index b7c29f2..0088bf8 100644
@@ -161,4 +161,12 @@ config SYS_BOOTCOUNT_MAGIC
 	help
 	  Set the magic value used for the boot counter.
 
+config SYS_BOOTCOUNT_NAME
+	string "Name of the bootcount variable in the env"
+	default "bootcount"
+	depends on BOOTCOUNT_ENV
+	help
+	  Set the name of the variable that count the number of boot.
+	  Usually this variable is named 'bootcount'.
+
 endif
drivers/bootcount/bootcount_env.c +2 -2
index b75c900..d5a38c8 100644
@@ -12,7 +12,7 @@ void bootcount_store(ulong a)
 	int upgrade_available = env_get_ulong("upgrade_available", 10, 0);
 
 	if (upgrade_available) {
-		env_set_ulong("bootcount", a);
+		env_set_ulong(CONFIG_SYS_BOOTCOUNT_NAME, a);
 		env_save();
 	}
 }
@@ -23,7 +23,7 @@ ulong bootcount_load(void)
 	ulong val = 0;
 
 	if (upgrade_available)
-		val = env_get_ulong("bootcount", 10, 0);
+		val = env_get_ulong(CONFIG_SYS_BOOTCOUNT_NAME, 10, 0);
 
 	return val;
 }
Signature · 1 line
2.7.4
#1 lore raw

RFC PATCH 1/1 bootcount: add support to customize bootcount variable name

Dear Philippe,

Quoted 3 lines · In message <[email protected]>…

This commit add an option to customize the bootcount variable name in the u-boot environment. To stay compatible with old config, the default name is bootcount.

Which exact problem are you trying to fix with this commit?

I mean, we have a ton of variable names with fixed meaning, which have been in use for nearly 2 decades - bootcmd, bootargs, bootcount, ...

What is wrong with the "boootcount" name?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In general, if you think something isn't in Perl, try it out, because
it usually is :-) - Larry Wall in <[email protected]>
#2 lore raw

RFC PATCH 1/1 bootcount: add support to customize bootcount variable name

Hi Wolfgang,

Quoted 9 lines

Dear Philippe,

In message <[email protected]>

Quoted 3 lines · you

This commit add an option to customize the bootcount variable name in the u-boot environment. To stay compatible with old config, the default name is bootcount.

Which exact problem are you trying to fix with this commit?

I have severals layers in my boot chain, and I want to use bootcount in severals layers to manage boot issues. If severals layers use the same variable name (bootcount) and a boot issue happen, I can't find the layer that fails.

So I propose to "customize" the bootcount variable name.

Quoted 5 lines

I mean, we have a ton of variable names with fixed meaning, which have been in use for nearly 2 decades - bootcmd, bootargs, bootcount, ...

What is wrong with the "boootcount" name?

As it is "unique", I can't chain severals bootcount.
That's why I propose an option to customize the bootcount name variable.

I know that it's a "corner case" and that you could prefer to avoid adding another option, that's why I've proposed this option as a RFC.

Quoted 3 lines

Best regards,

Wolfgang Denk

Best regards,
Philippe Reynes

#3 lore raw

RFC PATCH 1/1 bootcount: add support to customize bootcount variable name

Dear Philippe,

Quoted 5 lines · In message <[email protected]>…

I have severals layers in my boot chain, and I want to use bootcount in severals layers to manage boot issues. If severals layers use the same variable name (bootcount) and a boot issue happen, I can't find the layer that fails.

I can't understand your problem description, sorry.

Quoted 1 line

So I propose to "customize" the bootcount variable name.

This makes no sense to me.

Quoted 2 lines

As it is "unique", I can't chain severals bootcount.
That's why I propose an option to customize the bootcount name variable.

But that's the actual situation: there is only one boot count. Please keep in mind that this variable holds the number of boot attepmts since the last power-on that failed to successfully reach a specific "confirmation point" in your application (that, which is considered a complete, successfull boot of the whole system).

For this single task there can be only a single counter, or?

Quoted 2 lines

I know that it's a "corner case" and that you could prefer to avoid adding another option, that's why I've proposed this option as a RFC.

I do not see any practical use yet...

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
READ THIS BEFORE OPENING PACKAGE: According to Certain Suggested Ver-
sions of the Grand Unified Theory, the Primary Particles Constituting
this Product May Decay to Nothingness Within the  Next  Four  Hundred
Million Years.