Skip to contentSkip to conversation

package/minimodem: new package

PATCH New Alexander Kurz 2 participants 2 messages Sep 9, 2019 – Sep 11, 2019

lore
Share & tools
lore

Alexander Kurz

author
#0 lore raw

PATCH v2 1/1 package/minimodem: new package

From: Alexander Kurz <[email protected]>

Minimodem is a command-line program which decodes (or generates) audio modem tones at any specified baud rate, using various framing protocols. It acts a general-purpose software FSK modem, and includes support for various standard FSK protocols such as Bell103, Bell202, RTTY, TTY/TDD NOAA SAME, and Caller-ID.

Signed-off-by Alexander Kurz <[email protected]>

---
Changes v1 -> v2:
- add libfftw-single dependency (suggested by Arnout Vandecappelle)
- remove obsolete select BR2_PACKAGE_FFTW
- add pkg-dependency to libsndfile, alsa or pulseaudio, at least one is required to build minimodem
- remove default value of _SOURCE variable fixes check-package warn

Changes v0 -> v1:
- add optinal package dependencies
- add DEVELOPERS entry (suggested by Arnout Vandecappelle)

Signed-off-by Alexander Kurz <[email protected]>
---
 DEVELOPERS                       |  3 +++
 package/Config.in                |  1 +
 package/minimodem/Config.in      | 14 ++++++++++++++
 package/minimodem/minimodem.hash |  2 ++
 package/minimodem/minimodem.mk   | 35 +++++++++++++++++++++++++++++++++++
 5 files changed, 55 insertions(+)
 create mode 100644 package/minimodem/Config.in
 create mode 100644 package/minimodem/minimodem.hash
 create mode 100644 package/minimodem/minimodem.mk
DEVELOPERS +3 -0
index 5784843e33..47a1136f03 100644
@@ -103,6 +103,9 @@ F:	package/fastd/
 F:	package/libuecc/
 F:	package/putty/
 
+N:	Alexander Kurz <[email protected]>
+F:	package/minimodem/
+
 N:	Alexander Lukichev <[email protected]>
 F:	package/openpgm/
package/Config.in +1 -0
index 9336261c5d..7d915ea4d7 100644
@@ -32,6 +32,7 @@ menu "Audio and video applications"
 	source "package/lame/Config.in"
 	source "package/madplay/Config.in"
 	source "package/mimic/Config.in"
+	source "package/minimodem/Config.in"
 	source "package/miraclecast/Config.in"
 	source "package/mjpegtools/Config.in"
 	source "package/modplugtools/Config.in"
package/minimodem/Config.in new file +14 -0
new file mode 100644
index 0000000000..9d2afd6798
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_MINIMODEM
+	select BR2_PACKAGE_FFTW_SINGLE
+	depends on BR2_PACKAGE_LIBSNDFILE || BR2_PACKAGE_ALSA_LIB_PCM || \
+		BR2_PACKAGE_PULSEAUDIO
+	bool "minimodem"
+	help
+	  Minimodem is a command-line program which decodes (or
+	  generates) audio modem tones at any specified baud rate,
+	  using various framing protocols. It acts a general-purpose
+	  software FSK modem, and includes support for various
+	  standard FSK protocols such as Bell103, Bell202, RTTY,
+	  TTY/TDD NOAA SAME, and Caller-ID.
+
+	  http://www.whence.com/minimodem/
package/minimodem/minimodem.hash new file +2 -0
new file mode 100644
index 0000000000..084a5606fb
@@ -0,0 +1,2 @@
+sha256 f8cca4db8e3f284d67f843054d6bb4d88a3db5e77b26192410e41e9a06f4378e  minimodem-0.24.tar.gz
+sha256 c298178753129680ef6d3112f0f8b61acc405c86c1997dfe59735257988f8b33  COPYING
package/minimodem/minimodem.mk new file +35 -0
new file mode 100644
index 0000000000..0ddce41856
@@ -0,0 +1,35 @@
+################################################################################
+#
+# minimodem
+#
+################################################################################
+
+MINIMODEM_VERSION = 0.24
+MINIMODEM_SITE = http://www.whence.com/minimodem
+MINIMODEM_LICENSE = GPL-3.0+
+MINIMODEM_LICENSE_FILES = COPYING
+
+MINIMODEM_DEPENDENCIES += fftw-single
+
+ifeq ($(BR2_PACKAGE_ALSA_LIB_PCM),y)
+MINIMODEM_DEPENDENCIES += alsa-lib
+MINIMODEM_CONF_OPTS += --with-alsa
+else
+MINIMODEM_CONF_OPTS += --without-alsa
+endif
+
+ifeq ($(BR2_PACKAGE_PULSEAUDIO),y)
+MINIMODEM_DEPENDENCIES += pulseaudio
+MINIMODEM_CONF_OPTS += --with-pulseaudio
+else
+MINIMODEM_CONF_OPTS += --without-pulseaudio
+endif
+
+ifeq ($(BR2_PACKAGE_LIBSNDFILE),y)
+MINIMODEM_DEPENDENCIES += libsndfile
+MINIMODEM_CONF_OPTS += --with-sndfile
+else
+MINIMODEM_CONF_OPTS += --without-sndfile
+endif
+
+$(eval $(autotools-package))
Signature · 1 line
2.11.0
#1 lore raw

PATCH v2 1/1 package/minimodem: new package

Hello Alexander,

package/minimodem/Config.in line 4

Quoted 10 lines · On Mon, 9 Sep 2019 18:23:45 +0000 Alexander Kurz <[email protected]> wrote:
package/minimodem/Config.in new file +4 -0
new file mode 100644
index 0000000000..9d2afd6798
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_MINIMODEM
+	select BR2_PACKAGE_FFTW_SINGLE
+	depends on BR2_PACKAGE_LIBSNDFILE || BR2_PACKAGE_ALSA_LIB_PCM || \
+		BR2_PACKAGE_PULSEAUDIO

I changed this to a select, as was initially suggested by Arnout.

package/minimodem/Config.in line 5

Quoted 1 line
package/minimodem/Config.in new file +1 -0
+	bool "minimodem"

The bool statement should be before the select/depends on. This is just a Buildroot rule, so that we do things consistently between packages. I think it is reported by "make check-package".

package/minimodem/Config.in line 6

Quoted 1 line
package/minimodem/Config.in new file +1 -0
+MINIMODEM_DEPENDENCIES += fftw-single

A dependency on host-pkgconf was missing here.

I fixed those different issues, and applied. Thanks a lot for your contribution!

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com