Skip to contentSkip to conversation

drm/i915/tgl: Implement Wa_1409142259

PATCH Applied Radhakrishna Sripada 4 participants 6 messages Sep 9, 2019 – Sep 19, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/i915/tgl: Implement Wa_1409142259

Disable CPS aware color pipe by setting chicken bit.

BSpec: 52890
HSDES: 1409142259

v2: Move WA to ctx WA's(Daniele)

Cc Daniele Ceraolo Spurio <[email protected]>
Cc Stuart Summers <[email protected]>
Cc Matt Roper <[email protected]>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
 drivers/gpu/drm/i915/i915_reg.h             | 1 +
 2 files changed, 4 insertions(+)
drivers/gpu/drm/i915/gt/intel_workarounds.c +3 -0
index 243d3f77be13..95ef2f1dfdbb 100644
@@ -567,6 +567,9 @@ static void icl_ctx_workarounds_init(struct intel_engine_cs *engine,
 static void tgl_ctx_workarounds_init(struct intel_engine_cs *engine,
 				     struct i915_wa_list *wal)
 {
+	/* Wa_1409142259 */
+	WA_SET_BIT_MASKED(GEN11_COMMON_SLICE_CHICKEN3,
+			  GEN12_DISABLE_CPS_AWARE_COLOR_PIPE);
 }
 
 static void
drivers/gpu/drm/i915/i915_reg.h +1 -0
index 006cffd56be2..53e07882efb7 100644
@@ -7668,6 +7668,7 @@ enum {
 
 #define GEN11_COMMON_SLICE_CHICKEN3		_MMIO(0x7304)
   #define GEN11_BLEND_EMB_FIX_DISABLE_IN_RCC	(1 << 11)
+  #define GEN12_DISABLE_CPS_AWARE_COLOR_PIPE	(1 << 9)
 
 #define HIZ_CHICKEN					_MMIO(0x7018)
 # define CHV_HZ_8X8_MODE_IN_1X				(1 << 15)
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for drm/i915/tgl: Implement Wa_1409142259 (rev2)

== Series Details ==

== Series Details ==

Series: drm/i915/tgl: Implement Wa_1409142259 (rev2)
URL : https://patchwork.freedesktop.org/series/66364/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6855 -> Patchwork_14335
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/

Known issues
------------

Here are the changes found in Patchwork_14335 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_fence@nb-await-default:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/fi-icl-u3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/fi-icl-u3/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][3] -> [FAIL][4] ([fdo#108511])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/fi-skl-6770hq/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/fi-skl-6770hq/igt@[email protected]

* igt@i915_selftest@live_execlists:
- fi-skl-gvtdvm: [PASS][5] -> [DMESG-FAIL][6] ([fdo#111108])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html

* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [PASS][7] -> [FAIL][8] ([fdo#109635 ])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/fi-icl-u2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/fi-icl-u2/igt@[email protected]

* igt@kms_chamelium@hdmi-edid-read:
- fi-icl-u2: [PASS][9] -> [FAIL][10] ([fdo#109483])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/fi-icl-u2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/fi-icl-u2/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: [PASS][11] -> [FAIL][12] ([fdo#103167])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/fi-icl-u3/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/fi-icl-u3/igt@[email protected]
- fi-hsw-peppy: [PASS][13] -> [DMESG-WARN][14] ([fdo#102614])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/fi-hsw-peppy/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/fi-hsw-peppy/igt@[email protected]

#### Possible fixes ####

* igt@core_auth@basic-auth:
- fi-icl-u3: [DMESG-WARN][15] ([fdo#107724]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/fi-icl-u3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/fi-icl-u3/igt@[email protected]

* igt@i915_module_load@reload:
- fi-blb-e6850: [INCOMPLETE][17] ([fdo#107718]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/fi-blb-e6850/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/fi-blb-e6850/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [FAIL][19] ([fdo#103167]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/fi-icl-u2/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/fi-icl-u2/igt@[email protected]

[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108

Participating hosts (53 -> 47)
------------------------------

Additional (1): fi-pnv-d510
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_6855 -> Patchwork_14335

CI-20190529: 20190529
CI_DRM_6855: 4cef087ee0994669a097115945717fedb413c368 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5177: 8f351d693352d21c96cef38c3fd77f778c6d7c33 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14335: 714ee1f08b3b506eae04e19f2762bf605d5a3c23 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

714ee1f08b3b drm/i915/tgl: Implement Wa_1409142259

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.IGT: success for drm/i915/tgl: Implement Wa_1409142259 (rev2)

In reply to Radhakrishna Sripada
== Series Details ==

== Series Details ==

Series: drm/i915/tgl: Implement Wa_1409142259 (rev2)
URL : https://patchwork.freedesktop.org/series/66364/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6855_full -> Patchwork_14335_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_14335_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276]) +16 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-iclb4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-iclb6/igt@[email protected]

* igt@gem_exec_schedule@preempt-other-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#111325]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-iclb7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-iclb1/igt@[email protected]

* igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic:
- shard-skl: [PASS][5] -> [DMESG-WARN][6] ([fdo#105541])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-skl2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-skl3/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled:
- shard-skl: [PASS][7] -> [FAIL][8] ([fdo#103184] / [fdo#103232])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-skl5/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-skl8/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][9] -> [FAIL][10] ([fdo#105363])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-skl9/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-skl5/igt@[email protected]

* igt@kms_flip@flip-vs-suspend:
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([fdo#109507])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-skl6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-skl3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render:
- shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103167]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html

* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#103166])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-iclb8/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-iclb5/igt@[email protected]

* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-iclb3/igt@kms_psr@psr2_sprite_render.html

* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +4 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-apl5/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-apl4/igt@[email protected]

* igt@prime_busy@hang-default:
- shard-iclb: [PASS][21] -> [INCOMPLETE][22] ([fdo#107713])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-iclb2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-iclb1/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][23] ([fdo#110841]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-iclb1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-iclb7/igt@[email protected]

* igt@gem_ctx_shared@exec-single-timeline-bsd1:
- shard-iclb: [SKIP][25] ([fdo#109276]) -> [PASS][26] +12 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-iclb6/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@deep-bsd:
- shard-iclb: [SKIP][27] ([fdo#111325]) -> [PASS][28] +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-iclb1/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-iclb5/igt@[email protected]

* igt@gem_tiled_swapping@non-threaded:
- shard-apl: [DMESG-WARN][29] ([fdo#108686]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-apl2/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-apl6/igt@[email protected]
- shard-iclb: [DMESG-WARN][31] ([fdo#108686]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-iclb2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-iclb1/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-atomic:
- shard-hsw: [FAIL][33] ([fdo#103355]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-hsw6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-hsw1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [FAIL][35] ([fdo#103167]) -> [PASS][36] +6 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-iclb2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-iclb1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [DMESG-WARN][37] ([fdo#108566]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-apl5/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-apl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-skl: [INCOMPLETE][39] ([fdo#104108] / [fdo#106978]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-skl2/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-skl9/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][41] ([fdo#108145] / [fdo#110403]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-skl6/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-skl7/igt@[email protected]

* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][43] ([fdo#109441]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-iclb7/igt@kms_psr@psr2_suspend.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-iclb2/igt@kms_psr@psr2_suspend.html

* igt@perf_pmu@rc6:
- shard-kbl: [SKIP][45] ([fdo#109271]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-kbl2/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-kbl7/igt@[email protected]

#### Warnings ####

* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][47] ([fdo#109276]) -> [FAIL][48] ([fdo#111329])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-iclb6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-iclb4/igt@[email protected]

* igt@gem_mocs_settings@mocs-settings-bsd2:
- shard-iclb: [FAIL][49] ([fdo#111330]) -> [SKIP][50] ([fdo#109276])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-iclb1/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-iclb5/igt@[email protected]

* igt@kms_atomic_transition@2x-modeset-transitions-fencing:
- shard-apl: [SKIP][51] ([fdo#109271]) -> [INCOMPLETE][52] ([fdo#103927])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6855/shard-apl1/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/shard-apl5/igt@[email protected]

[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_6855 -> Patchwork_14335

CI-20190529: 20190529
CI_DRM_6855: 4cef087ee0994669a097115945717fedb413c368 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5177: 8f351d693352d21c96cef38c3fd77f778c6d7c33 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14335: 714ee1f08b3b506eae04e19f2762bf605d5a3c23 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14335/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v2 1/1
#3 lore raw
In reply to Radhakrishna Sripada
Quoted 11 lines · Radhakrishna Sripada

Disable CPS aware color pipe by setting chicken bit.

BSpec: 52890
HSDES: 1409142259

v2: Move WA to ctx WA's(Daniele)

Cc Daniele Ceraolo Spurio <[email protected]>
Cc Stuart Summers <[email protected]>
Cc Matt Roper <[email protected]>

Daniele

Quoted 25 lines
---
  drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
  drivers/gpu/drm/i915/i915_reg.h             | 1 +
  2 files changed, 4 insertions(+)
drivers/gpu/drm/i915/gt/intel_workarounds.c +3 -0
index 243d3f77be13..95ef2f1dfdbb 100644
@@ -567,6 +567,9 @@ static void icl_ctx_workarounds_init(struct intel_engine_cs *engine,
  static void tgl_ctx_workarounds_init(struct intel_engine_cs *engine,
  				     struct i915_wa_list *wal)
  {
+	/* Wa_1409142259 */
+	WA_SET_BIT_MASKED(GEN11_COMMON_SLICE_CHICKEN3,
+			  GEN12_DISABLE_CPS_AWARE_COLOR_PIPE);
  }
 
  static void
drivers/gpu/drm/i915/i915_reg.h +0 -0
index 006cffd56be2..53e07882efb7 100644

drivers/gpu/drm/i915/i915_reg.h enum { · line 7674

Quoted 7 lines
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -7668,6 +7668,7 @@ enum {
 
  #define GEN11_COMMON_SLICE_CHICKEN3		_MMIO(0x7304)
    #define GEN11_BLEND_EMB_FIX_DISABLE_IN_RCC	(1 << 11)
+  #define GEN12_DISABLE_CPS_AWARE_COLOR_PIPE	(1 << 9)
 
  #define HIZ_CHICKEN					_MMIO(0x7018)
  # define CHV_HZ_8X8_MODE_IN_1X				(1 << 15)

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Hi Daniele,

Thanks for the review. Can you help me merge this pathc?

Thanks,
Radhakrishna(RK) Sripada

Quoted 58 lines

-----Original Message-----
From: Ceraolo Spurio, Daniele
Sent: Wednesday, September 11, 2019 11:12 AM
To: Sripada, Radhakrishna <[email protected]>; intel- [email protected]
Cc: Summers, Stuart <[email protected]>; Roper, Matthew D <[email protected]>
Subject: Re: [PATCH v2] drm/i915/tgl: Implement Wa_1409142259

Quoted 11 lines · Radhakrishna Sripada

Disable CPS aware color pipe by setting chicken bit.

BSpec: 52890
HSDES: 1409142259

v2: Move WA to ctx WA's(Daniele)

Cc Daniele Ceraolo Spurio <[email protected]>
Cc Stuart Summers <[email protected]>
Cc Matt Roper <[email protected]>

Daniele

drivers/gpu/drm/i915/gt/intel_workarounds.c static void icl_ctx_workarounds_init(struct

Quoted 11 lines
---
  drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
  drivers/gpu/drm/i915/i915_reg.h             | 1 +
  2 files changed, 4 insertions(+)
drivers/gpu/drm/i915/gt/intel_workarounds.c +0 -0
index 243d3f77be13..95ef2f1dfdbb 100644
@@ -567,6 +567,9 @@ static void icl_ctx_workarounds_init(struct

intel_engine_cs *engine,

Quoted 15 lines
drivers/gpu/drm/i915/gt/intel_workarounds.c +3 -0
  static void tgl_ctx_workarounds_init(struct intel_engine_cs *engine,
  				     struct i915_wa_list *wal)
  {
+	/* Wa_1409142259 */
+	WA_SET_BIT_MASKED(GEN11_COMMON_SLICE_CHICKEN3,
+			  GEN12_DISABLE_CPS_AWARE_COLOR_PIPE);
  }
 
  static void
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/i915_reg.h index 006cffd56be2..53e07882efb7 100644

drivers/gpu/drm/i915/i915_reg.h enum { · line 7669

Quoted 2 lines
drivers/gpu/drm/i915/i915_reg.h +0 -0
@@ -7668,6 +7668,7 @@ enum {
 
  #define GEN11_COMMON_SLICE_CHICKEN3
	_MMIO(0x7304)
Quoted 8 lines

drivers/gpu/drm/i915/i915_reg.h enum {

Quoted 4 lines
drivers/gpu/drm/i915/i915_reg.h +1 -0
    #define GEN11_BLEND_EMB_FIX_DISABLE_IN_RCC	(1 << 11)
+  #define GEN12_DISABLE_CPS_AWARE_COLOR_PIPE	(1 << 9)
 
  #define HIZ_CHICKEN
	_MMIO(0x7018)

drivers/gpu/drm/i915/i915_reg.h enum { · line 7674

Quoted 1 line
drivers/gpu/drm/i915/i915_reg.h +0 -0
  # define CHV_HZ_8X8_MODE_IN_1X				(1 <<

15)

Quoted 1 line

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Applied
#5 lore raw
Quoted 6 lines · Radhakrishna

Hi Daniele,

Thanks for the review. Can you help me merge this pathc?

Thanks,
Radhakrishna(RK) Sripada

Applied to dinq. Thanks for the patch and review.

Matt

Quoted 67 lines
Quoted 67 lines

-----Original Message-----
From: Ceraolo Spurio, Daniele
Sent: Wednesday, September 11, 2019 11:12 AM
To: Sripada, Radhakrishna <[email protected]>; intel- [email protected]
Cc: Summers, Stuart <[email protected]>; Roper, Matthew D <[email protected]>
Subject: Re: [PATCH v2] drm/i915/tgl: Implement Wa_1409142259

Quoted 11 lines · Radhakrishna Sripada

Disable CPS aware color pipe by setting chicken bit.

BSpec: 52890
HSDES: 1409142259

v2: Move WA to ctx WA's(Daniele)

Cc Daniele Ceraolo Spurio <[email protected]>
Cc Stuart Summers <[email protected]>
Cc Matt Roper <[email protected]>

Daniele

drivers/gpu/drm/i915/gt/intel_workarounds.c static void icl_ctx_workarounds_init(struct

Quoted 11 lines
---
  drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
  drivers/gpu/drm/i915/i915_reg.h             | 1 +
  2 files changed, 4 insertions(+)
drivers/gpu/drm/i915/gt/intel_workarounds.c +0 -0
index 243d3f77be13..95ef2f1dfdbb 100644
@@ -567,6 +567,9 @@ static void icl_ctx_workarounds_init(struct

intel_engine_cs *engine,

Quoted 15 lines
drivers/gpu/drm/i915/gt/intel_workarounds.c +3 -0
  static void tgl_ctx_workarounds_init(struct intel_engine_cs *engine,
  				     struct i915_wa_list *wal)
  {
+	/* Wa_1409142259 */
+	WA_SET_BIT_MASKED(GEN11_COMMON_SLICE_CHICKEN3,
+			  GEN12_DISABLE_CPS_AWARE_COLOR_PIPE);
  }
 
  static void
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/i915_reg.h index 006cffd56be2..53e07882efb7 100644

drivers/gpu/drm/i915/i915_reg.h enum { · line 7669

Quoted 2 lines
drivers/gpu/drm/i915/i915_reg.h +0 -0
@@ -7668,6 +7668,7 @@ enum {
 
  #define GEN11_COMMON_SLICE_CHICKEN3
	_MMIO(0x7304)

drivers/gpu/drm/i915/i915_reg.h enum {

Quoted 4 lines
drivers/gpu/drm/i915/i915_reg.h +1 -0
    #define GEN11_BLEND_EMB_FIX_DISABLE_IN_RCC	(1 << 11)
+  #define GEN12_DISABLE_CPS_AWARE_COLOR_PIPE	(1 << 9)
 
  #define HIZ_CHICKEN
	_MMIO(0x7018)

drivers/gpu/drm/i915/i915_reg.h enum { · line 7674

Quoted 1 line
drivers/gpu/drm/i915/i915_reg.h +0 -0
  # define CHV_HZ_8X8_MODE_IN_1X				(1 <<

15)

Quoted 1 line
Signature · 9 lines
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx