Skip to contentSkip to conversation

smack: include linux/watch_queue.h

PATCH In review Arnd Bergmann 3 participants 5 messages Sep 9, 2019 – Sep 24, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 smack: include linux/watch_queue.h

In some randconfig builds, the lack of an explicit #include in smack_lsm.c causes a build failure:

security/smack/smack_lsm.c:4384:7: error: incomplete definition of type 'struct watch_notification'

        if (n->type == WATCH_TYPE_META)
            ~^
include/linux/device.h:46:8: note: forward declaration of 'struct watch_notification'
struct watch_notification;
       ^
security/smack/smack_lsm.c:4384:17: error: use of undeclared identifier 'WATCH_TYPE_META'
        if (n->type == WATCH_TYPE_META)
Fixes 5301fef8ca60 ("smack: Implement the watch_key and post_notification hooks [untested]")
---
 security/smack/smack_lsm.c | 1 +
 1 file changed, 1 insertion(+)
security/smack/smack_lsm.c +1 -0
index a15e76489683..5120dd9c6335 100644
@@ -42,6 +42,7 @@
 #include <linux/parser.h>
 #include <linux/fs_context.h>
 #include <linux/fs_parser.h>
+#include <linux/watch_queue.h>
 #include "smack.h"
 
 #define TRANS_TRUE	"TRUE"
Signature · 1 line
2.20.0
#1 lore raw
I love your patch! Yet something to improve:

Hi Arnd,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc8 next-20190904]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/smack-include-linux-watch_queue-h/20190910-095704
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=ia64

If you fix the issue, kindly add following tag

All errors (new ones prefixed by >>):

>> security/smack/smack_lsm.c:45:10: fatal error: linux/watch_queue.h: No such file or directory
    #include <linux/watch_queue.h>
             ^~~~~~~~~~~~~~~~~~~~~

compilation terminated.

vim +45 security/smack/smack_lsm.c

  > 45	#include <linux/watch_queue.h>
    46	#include "smack.h"
    47	

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

#2 lore raw
In reply to Arnd Bergmann
I love your patch! Yet something to improve:

Hi Arnd,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc8 next-20190904]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/smack-include-linux-watch_queue-h/20190910-095704
reproduce:

        # apt-get install sparse
        # sparse version: 
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag

All errors (new ones prefixed by >>):

>> security/smack/smack_lsm.c:45:11: sparse: error: unable to open 'linux/watch_queue.h'

vim +45 security/smack/smack_lsm.c

  > 45	#include <linux/watch_queue.h>
    46	#include "smack.h"
    47	

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

maintainer
#3 lore raw
In reply to Arnd Bergmann
Quoted 2 lines · Arnd Bergmann

In some randconfig builds, the lack of an explicit #include in smack_lsm.c causes a build failure:

What tree/branch are you working with? I don't see this.

Quoted 28 lines

security/smack/smack_lsm.c:4384:7: error: incomplete definition of type 'struct watch_notification'

        if (n->type == WATCH_TYPE_META)
            ~^
include/linux/device.h:46:8: note: forward declaration of 'struct watch_notification'
struct watch_notification;
       ^
security/smack/smack_lsm.c:4384:17: error: use of undeclared identifier 'WATCH_TYPE_META'
        if (n->type == WATCH_TYPE_META)
Fixes 5301fef8ca60 ("smack: Implement the watch_key and post_notification hooks [untested]")
---
 security/smack/smack_lsm.c | 1 +
 1 file changed, 1 insertion(+)
security/smack/smack_lsm.c +1 -0
index a15e76489683..5120dd9c6335 100644
@@ -42,6 +42,7 @@
 #include <linux/parser.h>
 #include <linux/fs_context.h>
 #include <linux/fs_parser.h>
+#include <linux/watch_queue.h>
 #include "smack.h"
 
 #define TRANS_TRUE	"TRUE"
#4 lore raw
Quoted 6 lines · Casey Schaufler
Quoted 2 lines · Arnd Bergmann

In some randconfig builds, the lack of an explicit #include in smack_lsm.c causes a build failure:

What tree/branch are you working with? I don't see this.

It was in the latest linux-next at the time I posted the patch. It's possible that
the patch causing the problem got removed in the meantime.

Arnd