ath9k_htc: release allocated buffer if timed out
Subsystems (3)
PATCH 1/1 ath9k_htc: release allocated buffer if timed out
In htc_config_pipe_credits, htc_setup_complete, and htc_connect_service if time out happens, the allocated buffer needs to be released. Otherwise there will be memory leak.
Signed-off-by Navid Emamdoost <[email protected]>
--- drivers/net/wireless/ath/ath9k/htc_hst.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/wireless/ath/ath9k/htc_hst.c +3 -0
@@ -170,6 +170,7 @@ static int htc_config_pipe_credits(struct htc_target *target) time_left =wait_for_completion_timeout (&target->cmd_wait,HZ );if (!time_left) {dev_err (target->dev,"HTC credit config timeout\n" ); +kfree_skb (skb);return -ETIMEDOUT ; }
@@ -205,6 +206,7 @@ static int htc_setup_complete(struct htc_target *target) time_left =wait_for_completion_timeout (&target->cmd_wait,HZ );if (!time_left) {dev_err (target->dev,"HTC start timeout\n" ); +kfree_skb (skb);return -ETIMEDOUT ; }
@@ -277,6 +279,7 @@ int htc_connect_service(struct htc_target *target,if (!time_left) {dev_err (target->dev,"Service connection timeout for: %d\n" , service_connreq->service_id); +kfree_skb (skb);return -ETIMEDOUT ; }
Signature · 1 line
2.17.1
Quoted 6 lines · Navid Emamdoost
In
htc_config_pipe_credits,htc_setup_complete, andhtc_connect_serviceif time out happens, the allocated buffer needs to be released. Otherwise there will be memory leak.Signed-off-by Navid Emamdoost <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
853acf7caf10 ath9k_htc: release allocated buffer if timed out
Signature · 3 lines
https://patchwork.kernel.org/patch/11135781/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches