tools/ocaml: Fix build error with CentOS 7
PATCH 1/1 tools/ocaml: Fix build error with CentOS 7
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) complains:
xenctrl_stubs.c: In function 'stub_xc_domain_create':
xenctrl_stubs.c:216:28: error: 'val' may be used uninitialized
in this function [-Werror=maybe-uninitialized]
cfg.arch.emulation_flags = ocaml_list_to_c_bitmap
^
xenctrl_stubs.c:198:12: error: 'val' may be used uninitialized
in this function [-Werror=maybe-uninitialized]
cfg.flags = ocaml_list_to_c_bitmap
^
cc1: all warnings being treated as errors
GCC doesn't point at the correct piece of code, but the diagnostic text is correct, and can occur when the list is empty. Initialise val to 0.
---
CC: Ian Jackson <[email protected]>
CC: Wei Liu <[email protected]>
CC: Christian Lindig <[email protected]>
--- tools/ocaml/libs/xc/xenctrl_stubs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/ocaml/libs/xc/xenctrl_stubs.c +1 -1
@@ -160,7 +160,7 @@ static unsigned int ocaml_list_to_c_bitmap(value l)* for xenctrl_abi_check. The parsing there is ad-hoc. */ { -unsigned int val; +unsigned int val =0 ;for ( ; l != Val_none; l =Field (l,1 ) ) val |=1u <<Int_val (Field (l,0 ));
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel