tools/ocaml: abi check: #include on x86 only
PATCH 1/1 tools/ocaml: abi check: #include on x86 only
Reported-by Andrew Cooper <[email protected]>
Signed-off-by Ian Jackson <[email protected]>
--- tools/ocaml/libs/xc/xenctrl_stubs.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
tools/ocaml/libs/xc/xenctrl_stubs.c +13 -0
@@ -135,7 +135,20 @@ static value c_bitmap_to_ocaml_listCAMLparam0 ();CAMLlocal2 (list, tmp); +#if defined(__i386__) || defined(__x86_64__) +/* +* This check file contains a mixture of stuff, because it is +* generated from the whole of this xenctrl_stubs.c file (without +* regard to arch ifdefs) and the whole of xenctrl.ml (which does not +* have any arch ifdeffery). Currently, there is only x86 and +* arch-independent stuff, and there is no facility in the abi-check +* script for arch conditionals. So for now we make the checks +* effective on x86 only; this will suffice to defend even ARM +* because breaking changes to common code will break the build +* on x86 and not make it to master. This is a bit of a bodge. +*/ #include "xenctrl_abi_check.h" +#endif list = tmp = Val_emptylist;
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
On 10/09/2019 16:17, Ian Jackson wrote:
Subject +=
Spotted by Gitlab CI.
Quoted 2 lines
Reported-by Andrew Cooper <[email protected]>Signed-off-by Ian Jackson <[email protected]>
Acked-by Andrew Cooper <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel