package/nfs-utils: enable IPv6 if libtirpc is selected
PATCH v4 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected
From: Carlos Santos <[email protected]>
IPv6 support requires libtirpc, so enable it if libtirpc is selected.
In practice this always enables IPv6, since nfs-utils needs rpcbind, which in its turn selects libtirpc.
---
CC: nathan.renniewaldock at gmail.com
CC: Peter Seiderer <[email protected]>
CC: Arnout Vandecappelle <[email protected]>
CC: Thomas Petazzoni <[email protected]> --
Changes v1->v2
- Select LIBTIRPC unconditionally.
Changes v2->v3
- Do not select libtirpc inconditionally Changes v3->v4
- Restore v1 commit message
- Add comment about selecting libtirpc to Config.in
So we're back to v1 with a lot of discussion in between. I want the bike shed purple.
--- package/nfs-utils/Config.in | 3 +++ package/nfs-utils/nfs-utils.mk | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-)
package/nfs-utils/Config.in +3 -0
@@ -6,11 +6,14 @@ config BR2_PACKAGE_NFS_UTILS bool "nfs-utils" depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc, rpcbind depends on BR2_USE_MMU # fork() + # Just in case, since rpcbind already selects libtirpc select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC select BR2_PACKAGE_RPCBIND # runtime help The NFS Linux kernel server. + For IPv6 support, ensure that libtirpc is selected too. + http://linux-nfs.org/ if BR2_PACKAGE_NFS_UTILS
package/nfs-utils/nfs-utils.mk +3 -3
@@ -19,7 +19,6 @@ NFS_UTILS_CONF_OPTS = \ --disable-nfsv41 \ --disable-gss \ --disable-uuid \ - --disable-ipv6 \ --without-tcp-wrappers \ --with-statedir=/run/nfs \ --with-rpcgen=internal
@@ -51,11 +50,12 @@ else NFS_UTILS_CONF_OPTS += --disable-caps endif +# IPv6 requires libtirpc ifeq ($(BR2_PACKAGE_LIBTIRPC),y) -NFS_UTILS_CONF_OPTS += --enable-tirpc +NFS_UTILS_CONF_OPTS += --enable-tirpc --enable-ipv6 NFS_UTILS_DEPENDENCIES += libtirpc else -NFS_UTILS_CONF_OPTS += --disable-tirpc +NFS_UTILS_CONF_OPTS += --disable-tirpc --disable-ipv6 endif define NFS_UTILS_INSTALL_FIXUP
Signature · 1 line
2.18.1
PATCH v4 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected
Oh dear, we're running in circles here...
Quoted 6 lines · unixmania at gmail.com
From: Carlos Santos <[email protected]>
IPv6 support requires libtirpc, so enable it if libtirpc is selected.
In practice this always enables IPv6, since nfs-utils needs rpcbind, which in its turn selects libtirpc.
So somehow, Thomas and I completely missed this bit...
Quoted 30 lines
Signed-off-by Carlos Santos <[email protected]>---
CC: nathan.renniewaldock at gmail.com
CC: Peter Seiderer <[email protected]>
CC: Arnout Vandecappelle <[email protected]>
CC: Thomas Petazzoni <[email protected]> --
Changesv1->v2
- Select LIBTIRPC unconditionally.
Changesv2->v3
- Do not select libtirpc inconditionally Changesv3->v4
- Restore v1 commit message
- Add comment about selecting libtirpc to Config.inSo we're back to v1 with a lot of discussion in between. I want the bike shed purple.
--- package/nfs-utils/Config.in | 3 +++ package/nfs-utils/nfs-utils.mk | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-)package/nfs-utils/Config.in +0
-0
package/nfs-utils/Config.in config BR2_PACKAGE_NFS_UTILS · line 10
Quoted 5 lines
package/nfs-utils/Config.in +1
-0@@ -6,11 +6,14 @@ config BR2_PACKAGE_NFS_UTILS bool "nfs-utils" depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc, rpcbind depends on BR2_USE_MMU # fork() + # Just in case, since rpcbind already selects libtirpc select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
But this doesn't really make sense then... We can just put
select BR2_PACKAGE_LIBTIRPC
Even the comment above is not really needed - we can get that from the git log.
Quoted 22 lines
package/nfs-utils/Config.in +2
-0select BR2_PACKAGE_RPCBIND # runtime help The NFS Linux kernel server. + For IPv6 support, ensure that libtirpc is selected too. + http://linux-nfs.org/ if BR2_PACKAGE_NFS_UTILSpackage/nfs-utils/nfs-utils.mk +0
-1@@ -19,7 +19,6 @@ NFS_UTILS_CONF_OPTS = \ --disable-nfsv41 \ --disable-gss \ --disable-uuid \ - --disable-ipv6 \ --without-tcp-wrappers \ --with-statedir=/run/nfs \ --with-rpcgen=internal
package/nfs-utils/nfs-utils.mk else · line 56
Quoted 8 lines
package/nfs-utils/nfs-utils.mk +2
-1@@ -51,11 +50,12 @@ else NFS_UTILS_CONF_OPTS += --disable-caps endif +# IPv6 requires libtirpc ifeq ($(BR2_PACKAGE_LIBTIRPC),y) -NFS_UTILS_CONF_OPTS += --enable-tirpc +NFS_UTILS_CONF_OPTS += --enable-tirpc --enable-ipv6 NFS_UTILS_DEPENDENCIES += libtirpc
Due to the select, all of this becomes unconditional.
In other words, we should:
- select libtirpc unconditionally;
- add libtirpc to _DEPENDENCIES unconditionally;
- add --enable-tirpc --enable-ipv6 to CONF_OPTS unconditionally;
- leave the help text unchanged since libtirpc is anyway selected;
- make it clear in the commit message that libtirpc is anyway selected by rpcbind, so we can just as well select it unconditionally in nfs-utils.
Again, I'm very sorry that it takes us five iterations and several months to
come to this conclusion...
Regards,
Arnout
Quoted 7 lines
package/nfs-utils/nfs-utils.mk +1
-1else -NFS_UTILS_CONF_OPTS += --disable-tirpc +NFS_UTILS_CONF_OPTS += --disable-tirpc --disable-ipv6 endif define NFS_UTILS_INSTALL_FIXUP
PATCH v4 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected
Answering from my phone and too tired to fight. ?
Carlos Santos <[email protected]>
Em 10 de set de 2019, ?(s) 09:23, Arnout Vandecappelle <[email protected]> escreveu:
Quoted 111 lines
Oh dear, we're running in circles here...
Quoted 7 lines · unixmania at gmail.com
From: Carlos Santos <[email protected]>
IPv6 support requires libtirpc, so enable it if libtirpc is selected.
In practice this always enables IPv6, since nfs-utils needs rpcbind, which in its turn selects libtirpc.
So somehow, Thomas and I completely missed this bit...
Quoted 30 lines
Signed-off-by Carlos Santos <[email protected]>---
CC: nathan.renniewaldock at gmail.com
CC: Peter Seiderer <[email protected]>
CC: Arnout Vandecappelle <[email protected]>
CC: Thomas Petazzoni <[email protected]> --
Changesv1->v2
- Select LIBTIRPC unconditionally.
Changesv2->v3
- Do not select libtirpc inconditionally Changesv3->v4
- Restore v1 commit message
- Add comment about selecting libtirpc to Config.inSo we're back to v1 with a lot of discussion in between. I want the bike shed purple.
---
package/nfs-utils/Config.in | 3 +++package/nfs-utils/nfs-utils.mk| 6 +++---2 files changed, 6 insertions(+), 3 deletions(-)package/nfs-utils/Config.in +0
-0package/nfs-utils/Config.in config BR2_PACKAGE_NFS_UTILS · line 10
Quoted 5 lines
package/nfs-utils/Config.in +1
-0@@ -6,11 +6,14 @@ config BR2_PACKAGE_NFS_UTILS bool "nfs-utils" depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc, rpcbind depends on BR2_USE_MMU # fork() + # Just in case, since rpcbind already selects libtirpc select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPCBut this doesn't really make sense then... We can just put
select
BR2_PACKAGE_LIBTIRPCEven the comment above is not really needed - we can get that from the git log.
Quoted 29 lines
package/nfs-utils/Config.in +2
-0select BR2_PACKAGE_RPCBIND # runtime help The NFS Linux kernel server. + For IPv6 support, ensure that libtirpc is selected too. + http://linux-nfs.org/if
BR2_PACKAGE_NFS_UTILSpackage/nfs-utils/nfs-utils.mk +0
-1@@ -19,7 +19,6 @@ NFS_UTILS_CONF_OPTS = \ --disable-nfsv41 \ --disable-gss \ --disable-uuid \ - --disable-ipv6 \ --without-tcp-wrappers \ --with-statedir=/run/nfs \ --with-rpcgen=internal@@ -51,11 +50,12 @@ else
NFS_UTILS_CONF_OPTS+= --disable-caps
endif+# IPv6 requires libtirpc
ifeq ($(BR2_PACKAGE_LIBTIRPC),y)package/nfs-utils/nfs-utils.mk +1
-1-NFS_UTILS_CONF_OPTS += --enable-tirpc +NFS_UTILS_CONF_OPTS += --enable-tirpc --enable-ipv6Quoted 1 line
NFS_UTILS_DEPENDENCIES+= libtirpcDue to the select, all of this becomes unconditional.
In other words, we should:
- select libtirpc unconditionally;
- add libtirpc to_DEPENDENCIESunconditionally;
- add --enable-tirpc --enable-ipv6 toCONF_OPTSunconditionally;
- leave the help text unchanged since libtirpc is anyway selected;
- make it clear in the commit message that libtirpc is anyway selected by rpcbind, so we can just as well select it unconditionally in nfs-utils.Again, I'm very sorry that it takes us five iterations and several months to come to this conclusion...
Regards,
ArnoutQuoted 7 lines
else
package/nfs-utils/nfs-utils.mk +1
-1-NFS_UTILS_CONF_OPTS += --disable-tirpc +NFS_UTILS_CONF_OPTS += --disable-tirpc --disable-ipv6endif
define
NFS_UTILS_INSTALL_FIXUP
PATCH v4 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected
Hello Carlos,
Quoted 3 lines · On Tue, 10 Sep 2019 10:07:53 -0300 Carlos Santos <[email protected]> wrote:
Answering from my phone and too tired to fight. ?
Carlos Santos <[email protected]>
Unless I missed it, I don't see any specific answer from you on this e-mail. Was there an issue answering from your phone ?
Also, I don't think there's any need to "fight", we're simply trying to find what is the best solution in Buildroot, and sometimes it takes a while. Your contribution and persistence is very appreciated.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v4 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected
Quoted 17 lines · Thomas Petazzoni
Hello Carlos,
Quoted 3 lines · On Tue, 10 Sep 2019 10:07:53 -0300 Carlos Santos <[email protected]> wrote:
Answering from my phone and too tired to fight.
Carlos Santos <[email protected]>
Unless I missed it, I don't see any specific answer from you on this e-mail. Was there an issue answering from your phone ?
Also, I don't think there's any need to "fight", we're simply trying to find what is the best solution in Buildroot, and sometimes it takes a while. Your contribution and persistence is very appreciated.
Quoted 7 lines
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
s/fight/talk about/
Just apply v2, fixing the "inconditionally" typo. I can't waste more time on this, sorry.
Signature · 1 line
Carlos Santos <[email protected]>
PATCH v4 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected
In reply to Arnout VandecappelleQuoted 1 line · On Tue, 10 Sep 2019 14:23:15 +0200 Arnout Vandecappelle <[email protected]> wrote:
Oh dear, we're running in circles here...
Absolutely.
Quoted 10 lines
Due to the select, all of this becomes unconditional.
In other words, we should:
- select libtirpc unconditionally;
- add libtirpc to_DEPENDENCIESunconditionally;
- add --enable-tirpc --enable-ipv6 toCONF_OPTSunconditionally;
- leave the help text unchanged since libtirpc is anyway selected;
- make it clear in the commit message that libtirpc is anyway selected by rpcbind, so we can just as well select it unconditionally in nfs-utils.
Fully agreed.
Quoted 2 lines
Again, I'm very sorry that it takes us five iterations and several months to
come to this conclusion...
Yes, indeed. But sometimes that what it takes to finally understand each other and find what the good solution is.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com