package: qemu: Make dependency to nettle explicit
PATCH 1/1 package: qemu: Make dependency to nettle explicit
For the fli4l router distribution we had problems building 'qemu', some builds failed complaining when checking dynamic linking of the package:
Quoted 1 line
Quoted 1 line
Quoted 1 line
qemu 2.12.1 Error: Library libnettle.so.6 referenced by
usr/libexec/qemu-bridge-helperbelongs to package nettle which is not a dependency of qemu
https://web.nettworks.org/ci/job/fli4l/job/buildroot/job/4.0/job/trunk-x86_64/495/console
Making the dependency explicit, by calling ./configure with --enable-nettle or --disable-nettle depending on the activation status of package nettle, solves the issue.
For fli4l the fix is still based on buildroot 2018.02.x, but the problem is the same in recent version of buildroot, and the fix works for master as well.
--- package/qemu/qemu.mk | 7 +++++++ 1 file changed, 7 insertions(+)
package/qemu/qemu.mk +7 -0
@@ -97,6 +97,13 @@ else QEMU_OPTS += --disable-libssh2 endif +ifeq ($(BR2_PACKAGE_NETTLE),y) +QEMU_OPTS += --enable-nettle +QEMU_DEPENDENCIES += nettle +else +QEMU_OPTS += --disable-nettle +endif + # Override CPP, as it expects to be able to call it like it'd # call the compiler. define QEMU_CONFIGURE_CMDS
Signature · 1 line
2.11.0
PATCH 1/1 package: qemu: Make dependency to nettle explicit
Hello Alexander,
Quoted 11 lines · On Wed, 11 Sep 2019 10:40:39 +0200 Alexander Dahl <[email protected]> wrote:
For the fli4l router distribution we had problems building 'qemu', some builds failed complaining when checking dynamic linking of the package:
Quoted 1 line
Quoted 1 line
Quoted 1 line
qemu 2.12.1 Error: Library libnettle.so.6 referenced by
usr/libexec/qemu-bridge-helperbelongs to package nettle which is not a dependency of qemuhttps://web.nettworks.org/ci/job/fli4l/job/buildroot/job/4.0/job/trunk-x86_64/495/console
Making the dependency explicit, by calling ./configure with --enable-nettle or --disable-nettle depending on the activation status of package nettle, solves the issue.
Quoted 6 lines
For fli4l the fix is still based on buildroot 2018.02.x, but the problem is the same in recent version of buildroot, and the fix works for master as well.
Cc Florian Wolters <[email protected]>Signed-off-by Alexander Dahl <[email protected]>
Thanks for the patch, which looks good. I have one question though:
what prints the message "Error: Library libnettle.so.6 referenced by usr/libexec/qemu-bridge-helper belongs to package nettle which is not a dependency of qemu". It seems like a check from Buildroot, but I can't find it in our tree, and I don't remember we had such a check. Maybe it's just because it's early and my eyes are not well opened and I'm missing something obvious.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package: qemu: Make dependency to nettle explicit
Hello Thomas,
Quoted 21 lines · Thomas Petazzoni
Quoted 11 lines · On Wed, 11 Sep 2019 10:40:39 +0200 Alexander Dahl <[email protected]> wrote:
For the fli4l router distribution we had problems building 'qemu', some builds failed complaining when checking dynamic linking of the package:
Quoted 1 line
Quoted 1 line
Quoted 1 line
qemu 2.12.1 Error: Library libnettle.so.6 referenced by
usr/libexec/qemu-bridge-helperbelongs to package nettle which is not a dependency of qemuhttps://web.nettworks.org/ci/job/fli4l/job/buildroot/job/4.0/job/trunk-x86_64/495/console
Making the dependency explicit, by calling ./configure with --enable-nettle or --disable-nettle depending on the activation status of package nettle, solves the issue.
Quoted 6 lines
For fli4l the fix is still based on buildroot 2018.02.x, but the problem is the same in recent version of buildroot, and the fix works for master as well.
Cc Florian Wolters <[email protected]>Signed-off-by Alexander Dahl <[email protected]>
Quoted 7 lines
Thanks for the patch, which looks good. I have one question though:
what prints the message "Error: Library libnettle.so.6 referenced byusr/libexec/qemu-bridge-helperbelongs to package nettle which is not a dependency of qemu". It seems like a check from Buildroot, but I can't find it in our tree, and I don't remember we had such a check. Maybe it's just because it's early and my eyes are not well opened and I'm missing something obvious.
I'm afraid this is a change in the fli4l project on top of buildroot, which is not upstream.
I'm not familiar with all the changes and extensions Christoph made, but the message comes from the file 'package/pkg-utils.mk' which is part of the modified buildroot embedded in fli4l (currently 2018.2.x). Maybe he wants to explain more? I set him in Cc.
Our repo browser is currently offline, so I can not point you to the source. Sorry. You may checkout that stuff directly from Subversion if you want to have a look, but as I said, it's modified:
https://repo.nettworks.org/svn/fli4l/branches/4.0/trunk/src/packages/src/src/fbr/buildroot/
Greets
Alex
Signature · 11 lines
/"\ ASCII RIBBON | ?With the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.? / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie) -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190912/52c18db5/attachment.asc>
PATCH 1/1 package: qemu: Make dependency to nettle explicit
In reply to Alexander DahlHello Alexander,
Quoted 15 lines · On Wed, 11 Sep 2019 10:40:39 +0200 Alexander Dahl <[email protected]> wrote:
For the fli4l router distribution we had problems building 'qemu', some builds failed complaining when checking dynamic linking of the package:
Quoted 1 line
Quoted 1 line
Quoted 1 line
qemu 2.12.1 Error: Library libnettle.so.6 referenced by
usr/libexec/qemu-bridge-helperbelongs to package nettle which is not a dependency of qemuhttps://web.nettworks.org/ci/job/fli4l/job/buildroot/job/4.0/job/trunk-x86_64/495/console
Making the dependency explicit, by calling ./configure with --enable-nettle or --disable-nettle depending on the activation status of package nettle, solves the issue.
For fli4l the fix is still based on buildroot 2018.02.x, but the problem is the same in recent version of buildroot, and the fix works for master as well.
Quoted 5 lines
Cc Florian Wolters <[email protected]>Signed-off-by Alexander Dahl <[email protected]>--- package/qemu/qemu.mk | 7 +++++++ 1 file changed, 7 insertions(+)
I have reworked the commit log, because it didn't make much sense in the context of upstream Buildroot. Indeed, in upstream Buildroot, missing such optional dependencies does not cause any build error.
BTW, thanks for pointing me to the additional tooling that the fli4l project has added. In the context of upstream Buildroot, I think our goal is rather to move towards per-package target/host folders, which make sure only the explicitly listed dependencies are visible by each package.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com