Skip to contentSkip to conversation

Skip the test if "htop" is used.

PATCH New SiliangYu 2 participants 2 messages Sep 10, 2019 – Sep 11, 2019

lore
Share & tools
lore

SiliangYu

author
#0 lore raw

PATCH v4 1/1 Skip the test if "htop" is used.

From: "Yu,Siliang" <[email protected]>

In clear linux os, "htop" is used instead "top", which doesn't support '-b'. Skip the test on clear linux.

---
 .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh     | 4 ++++
 1 file changed, 4 insertions(+)
testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh +4 -0
index 18a11197e..74a3dd2b1 100755
@@ -49,6 +49,10 @@ done
 
 LOOP_COUNT=1
 
+if top -v | grep -q htop; then
+	tst_brkm TCONF "htop is used instead of top, Skip the test(workaround: alias top='/path/to/real/top')"
+fi
+
 if [ $(get_present_cpus_num) -lt 2 ]; then
 	tst_brkm TCONF "system doesn't have required CPU hotplug support"
 fi
Signature · 1 line
2.23.0
#1 lore raw

PATCH v4 1/1 Skip the test if "htop" is used.

Hi Yu,

Quoted 14 lines

From: "Yu,Siliang" <[email protected]>

In clear linux os, "htop" is used instead "top", which doesn't support '-b'. Skip the test on clear linux.

---
 .../kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh     | 4 ++++
 1 file changed, 4 insertions(+)
testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh +0 -0
index 18a11197e..74a3dd2b1 100755

testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh done · line 54

Quoted 6 lines
testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug06.sh +3 -0
@@ -49,6 +49,10 @@ done
 
 LOOP_COUNT=1
 
+if top -v | grep -q htop; then
+	tst_brkm TCONF "htop is used instead of top, Skip the test(workaround: alias top='/path/to/real/top')"
+fi

Merged, with slightly adjusted commit message.

Kind regards,
Petr