Staging: exfat: Avoid use of strcpy
PATCH v3 1/1 Staging: exfat: Avoid use of strcpy
Use strscpy instead of strcpy in exfat_core.c, and add a check for length that will return already known FFS_INVALIDPATH.
Suggested-by Rasmus Villemoes <[email protected]>
Signed-off-by Sandro Volery <[email protected]>
---
v3: Fixed replacing mistake
v2: Introduced length check
v1: Original patch
drivers/staging/exfat/exfat_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/exfat/exfat_core.c +2 -1
@@ -2964,7 +2964,8 @@ s32 resolve_path(struct inode *inode, char *path, struct chain_t *p_dir,if (strlen (path) >= (MAX_NAME_LENGTH *MAX_CHARSET_SIZE ))return FFS_INVALIDPATH ; -strcpy (name_buf, path); +if (strscpy (name_buf, path,sizeof (name_buf)) <0 ) +return FFS_INVALIDPATH ;nls_cstring_to_uniname (sb, p_uniname, name_buf, &lossy);if (lossy)
Signature · 1 line
2.23.0
Quoted 17 lines · Sandro Volery
Use strscpy instead of strcpy in
exfat_core.c, and add a check for length that will return already knownFFS_INVALIDPATH.Suggested-by Rasmus Villemoes <[email protected]>Signed-off-by Sandro Volery <[email protected]>---
v3: Fixed replacing mistake
v2: Introduced length check
v1: Original patchdrivers/staging/exfat/exfat_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/exfat/exfat_core.c +0
-0
drivers/staging/exfat/exfat_core.c s32 resolve_path(struct inode *inode, char *path, struct chain_t *p_dir, · line 2964
Quoted 1 line
drivers/staging/exfat/exfat_core.c +0
-0@@ -2964,7 +2964,8 @@ s32 resolve_path(struct inode *inode, char *path, struct chain_t *p_dir,if (strlen (path) >= (MAX_NAME_LENGTH *MAX_CHARSET_SIZE ))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Get rid of this.
drivers/staging/exfat/exfat_core.c s32 resolve_path(struct inode *inode, char *path, struct chain_t *p_dir, · line 2968
Quoted 5 lines
drivers/staging/exfat/exfat_core.c +2
-1return FFS_INVALIDPATH ; -strcpy (name_buf, path); +if (strscpy (name_buf, path,sizeof (name_buf)) <0 ) +return FFS_INVALIDPATH ;
regards,
dan carpenter