Patch "ALSA: pcm: Return 0 when size < start_threshold in capture" has been added to the 4.19-stable tree

DISCUSSION Ricardo Biehl Pasquali 2 participants 3 messages Sep 11, 2019 1 message not in the archive Stable branch

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Ricardo Biehl Pasquali

author

2019-09-11 14:14 UTC #1 lore raw

Quoted 7 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled
ALSA: pcm: Return 0 when size < start_threshold in capture
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
alsa-pcm-return-0-when-size-start_threshold-in-captu.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Hi Sasha.

This patch was reverted by the commit 932a81519572156a88db ("ALSA: pcm: Comment why read blocks when PCM is not running"):

This avoids bringing back the problem introduced by 62ba568f7aef ("ALSA: pcm: Return 0 when size < start_threshold in capture") and fixed in 00a399cad1a0 ("ALSA: pcm: Revert capture stream behavior change in blocking mode"), which prevented the user from starting capture from another thread.

Should this be queued anyway? If yes, I think it should also be queued the fix and the commit above.

pasquali

Ricardo Biehl Pasquali

author

2019-09-11 14:20 UTC #2 lore raw

Quoted 3 lines · Ricardo Biehl Pasquali

This patch was reverted by the commit 932a81519572156a88db ("ALSA: pcm: Comment why read blocks when PCM is not running"):

Sorry. It was reverted by 00a399cad1a0 ("ALSA: pcm: Revert capture stream behavior change in blocking mode"). The commit I mentioned just add a comment as described below:

Quoted 7 lines

This avoids bringing back the problem introduced by 62ba568f7aef ("ALSA: pcm: Return 0 when size < start_threshold in capture") and fixed in 00a399cad1a0 ("ALSA: pcm: Revert capture stream behavior change in blocking mode"), which prevented the user from starting capture from another thread.

Sasha Levin

maintainer

2019-09-11 16:49 UTC #3 lore raw

In reply to Ricardo Biehl Pasquali

Quoted 28 lines · Ricardo Biehl Pasquali

Quoted 7 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
ALSA: pcm: Return 0 when size < start_threshold in capture
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
Quoted 6 lines
The filename of the patch is:
alsa-pcm-return-0-when-size-start_threshold-in-captu.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Hi Sasha.
This patch was reverted by the commit 932a81519572156a88db ("ALSA: pcm: Comment why read blocks when PCM is not running"):
This avoids bringing back the problem introduced by 62ba568f7aef ("ALSA: pcm: Return 0 when size < start_threshold in capture") and fixed in 00a399cad1a0 ("ALSA: pcm: Revert capture stream behavior change in blocking mode"), which prevented the user from starting capture from another thread.

Quoted 2 lines

Should this be queued anyway? If yes, I think it should also be queued the fix and the commit above.

Nope, I'll drop it. Thank you.

--
Thanks,
Sasha