package/kompexsqlite: fixup the 'v' prefix in the version
PATCH 1/1 package/kompexsqlite: fixup the 'v' prefix in the version
In order for the kompexsqlite version to match what is given by release-monitoring.org, the 'v' prefix should be encoded in KOMPEXSQLITE_SOURCE and not KOMPEXSQLITE_VERSION.
--- package/kompexsqlite/kompexsqlite.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
package/kompexsqlite/kompexsqlite.mk +2 -2
@@ -4,8 +4,8 @@ # ################################################################################ -KOMPEXSQLITE_VERSION = v1.10.12-1 -KOMPEXSQLITE_SOURCE = $(KOMPEXSQLITE_VERSION).tar.gz +KOMPEXSQLITE_VERSION = 1.10.12-1 +KOMPEXSQLITE_SOURCE = v$(KOMPEXSQLITE_VERSION).tar.gz KOMPEXSQLITE_SITE = https://github.com/Aethelflaed/kompex-sqlite-wrapper/archive KOMPEXSQLITE_INSTALL_STAGING = YES KOMPEXSQLITE_LICENSE = LGPL-3.0+ (wrapper), Public Domain (bundled sqlite)
Signature · 1 line
2.23.0.rc1
PATCH 1/1 package/kompexsqlite: fixup the 'v' prefix in the version
Hello Fabrice,
Quoted 5 lines · On Wed, 11 Sep 2019 19:22:56 +0200 Fabrice Fontaine…
In order for the kompexsqlite version to match what is given by release-monitoring.org, the 'v' prefix should be encoded in
KOMPEXSQLITE_SOURCEand notKOMPEXSQLITE_VERSION.Signed-off-by Fabrice Fontaine <[email protected]>
I've applied to master, but I have a comment, see below.
package/kompexsqlite/kompexsqlite.mk line 9
Quoted 5 lines
package/kompexsqlite/kompexsqlite.mk +2
-2-KOMPEXSQLITE_VERSION = v1.10.12-1 -KOMPEXSQLITE_SOURCE = $(KOMPEXSQLITE_VERSION).tar.gz +KOMPEXSQLITE_VERSION = 1.10.12-1 +KOMPEXSQLITE_SOURCE = v$(KOMPEXSQLITE_VERSION).tar.gz KOMPEXSQLITE_SITE = https://github.com/Aethelflaed/kompex-sqlite-wrapper/archive
When I look at
https://github.com/Aethelflaed/kompex-sqlite-wrapper/releases, to me it seems like only the automatically generated tarballs are there. In such cases, we should use the github macro instead.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com