Skip to contentSkip to conversation

gpu: no need to compile drm/ if CONFIG_DRM=n

RFC PATCH In review Qian Cai 3 participants 4 messages Sep 11, 2019 – Sep 12, 2019

Subsystems (2)
lore
Share & tools
lore

Qian Cai

author
#0 lore raw

RFC PATCH 1/1 gpu: no need to compile drm/ if CONFIG_DRM=n

The commit c0e09200dc08 ("drm: reorganise drm tree to be more future proof.") changed the behavior from only compiling drm/ if CONFIG_DRM=y to always compiling drm/. This restores the behavior, so people don't need to waste time compiling stuff they don't need.

Fixes c0e09200dc08 ("drm: reorganise drm tree to be more future proof.")
---
 drivers/gpu/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/Makefile +2 -1
index f17d01f076c7..a793b9ace34b 100644
@@ -3,5 +3,6 @@
 # taken to initialize them in the correct order. Link order is the only way
 # to ensure this currently.
 obj-$(CONFIG_TEGRA_HOST1X)	+= host1x/
-obj-y			+= drm/ vga/
+obj-$(CONFIG_DRM)		+= drm/
+obj-y				+= vga/
 obj-$(CONFIG_IMX_IPUV3_CORE)	+= ipu-v3/
Signature · 1 line
2.20.1 (Apple Git-117)
#1 lore raw

Hi,

Quoted 6 lines · Qian Cai

The commit c0e09200dc08 ("drm: reorganise drm tree to be more future proof.") changed the behavior from only compiling drm/ if CONFIG_DRM=y to always compiling drm/. This restores the behavior, so people don't need to waste time compiling stuff they don't need.

Fixes c0e09200dc08 ("drm: reorganise drm tree to be more future proof.")

You are missing your signed-off-by

Thanks,
Maxime

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author
#2 lore raw
Quoted 12 lines · Maxime Ripard

Hi,

Le mer. 11 sept. 2019 à 19:35, Qian Cai <[email protected]> a écrit :
The commit c0e09200dc08 ("drm: reorganise drm tree to be more future proof.") changed the behavior from only compiling drm/ if CONFIG_DRM=y to always compiling drm/. This restores the behavior, so people don't need to waste time compiling stuff they don't need.

Quoted 3 lines
Fixes c0e09200dc08 ("drm: reorganise drm tree to be more future proof.")

You are missing your signed-off-by

That is intentional because this is a RFC patch to gather the feedback as I am no expert in DRM and may miss something important.

Once people are happy with it, I plan to send a formal patch with Signed-off-by.

#3 lore raw
Quoted 13 lines · Qian Cai
Quoted 13 lines · Maxime Ripard

Hi,

Le mer. 11 sept. 2019 à 19:35, Qian Cai <[email protected]> a écrit :
The commit c0e09200dc08 ("drm: reorganise drm tree to be more future proof.") changed the behavior from only compiling drm/ if CONFIG_DRM=y to always compiling drm/. This restores the behavior, so people don't need to waste time compiling stuff they don't need.

Quoted 9 lines
Quoted 3 lines
Fixes c0e09200dc08 ("drm: reorganise drm tree to be more future proof.")

You are missing your signed-off-by

That is intentional because this is a RFC patch to gather the feedback as I am no expert in DRM and may miss something important.

Once people are happy with it, I plan to send a formal patch with Signed-off-by.

CONFIG_DRM is tristate.

Your patch requires everything under drivers/gpu/drm/ modular when CONFIG_DRM=m.

At least, drivers/gpu/drm/drm_mipi_dsi.c is built-in only.

I guess that is the reason why they use 'obj-y += drm/'.

In other words, if you are able to make all the drm code modular, your patch is applicable.

Signature · 2 lines
Best Regards
Masahiro Yamada