Skip to contentSkip to conversation

package/sslh: fixup the 'v' prefix in the version

PATCH New Fabrice Fontaine 3 participants 5 messages Sep 11, 2019 – Sep 15, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/sslh: fixup the 'v' prefix in the version

In order for the sslh version to match what is given by release-monitoring.org, the 'v' prefix should be encoded in SSLH_SOURCE and not SSLH_VERSION.

---
 package/sslh/sslh.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/sslh/sslh.mk +2 -1
index 6e29a99189..ba91f8c4d6 100644
@@ -4,7 +4,8 @@
 #
 ################################################################################
 
-SSLH_VERSION = v1.20
+SSLH_VERSION = 1.20
+SSLH_SOURCE = sslh-v$(SSLH_VERSION).tar.gz
 SSLH_SITE = http://www.rutschle.net/tech/sslh
 SSLH_LICENSE = GPL-2.0+
 SSLH_LICENSE_FILES = COPYING
Signature · 1 line
2.23.0.rc1
#1 lore raw

PATCH 1/1 package/sslh: fixup the 'v' prefix in the version

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

In order for the sslh version to match what is given by release-monitoring.org, the 'v' prefix should be encoded in SSLH_SOURCE and not SSLH_VERSION.

---
 package/sslh/sslh.mk | 3 ++-

You don't seem to change sslh.hash?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/sslh: fixup the 'v' prefix in the version

Quoted 11 lines · On Sun, 15 Sep 2019 09:17:57 +0200 Peter Korsgaard <[email protected]> wrote:
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

In order for the sslh version to match what is given by release-monitoring.org, the 'v' prefix should be encoded in SSLH_SOURCE and not SSLH_VERSION.

---
 package/sslh/sslh.mk | 3 ++-  

You don't seem to change sslh.hash?

The tarball name doesn't change:

-SSLH_VERSION = v1.20
+SSLH_VERSION = 1.20
+SSLH_SOURCE = sslh-v$(SSLH_VERSION).tar.gz

This package is not fetched from Github, so it's not us who control the tarball name. Here the tarball name is the one from upstream, and it doesn't change, so the .hash file doesn't change.

After applying this patch:

sslh-v1.20.tar.gz: OK (sha256: a7f49b0a1cfcb7bb9d97f5ffa932bff11c5f65d9a9bd8fe1812481dee5855116)

Quoted 1 line
Quoted 1 line
Quoted 1 line

sslh 1.20 Extracting

gzip -d -c /home/thomas/dl/sslh/sslh-v1.20.tar.gz | tar --strip-components=1 -C /home/thomas/projets/buildroot/output/build/sslh-1.20 -xf -

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/sslh: fixup the 'v' prefix in the version

Quoted 27 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Quoted 11 lines · On Sun, 15 Sep 2019 09:17:57 +0200 Peter Korsgaard <[email protected]> wrote:
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

In order for the sslh version to match what is given by release-monitoring.org, the 'v' prefix should be encoded in SSLH_SOURCE and not SSLH_VERSION.

---
 package/sslh/sslh.mk | 3 ++-  

You don't seem to change sslh.hash?

The tarball name doesn't change:

package/sslh/sslh.mk +2 -1
-SSLH_VERSION = v1.20
+SSLH_VERSION = 1.20
+SSLH_SOURCE = sslh-v$(SSLH_VERSION).tar.gz

This package is not fetched from Github, so it's not us who control the tarball name. Here the tarball name is the one from upstream, and it doesn't change, so the .hash file doesn't change.

Quoted 5 lines

After applying this patch:

sslh-v1.20.tar.gz: OK (sha256: a7f49b0a1cfcb7bb9d97f5ffa932bff11c5f65d9a9bd8fe1812481dee5855116)

Quoted 1 line
Quoted 1 line
Quoted 1 line

sslh 1.20 Extracting

gzip -d -c /home/thomas/dl/sslh/sslh-v1.20.tar.gz | tar --strip-components=1 -C /home/thomas/projets/buildroot/output/build/sslh-1.20 -xf -

Ahh yes, indeed - Sorry for the noise.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 package/sslh: fixup the 'v' prefix in the version

In reply to Fabrice Fontaine
Quoted 8 lines · On Wed, 11 Sep 2019 19:46:30 +0200 Fabrice Fontaine…

In order for the sslh version to match what is given by release-monitoring.org, the 'v' prefix should be encoded in SSLH_SOURCE and not SSLH_VERSION.

---
 package/sslh/sslh.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com