Skip to contentSkip to conversation

breakpad: Update dont-clobber-rsp patch to latest

PATCH New Khem Raj 1 participant 2 messages Sep 11, 2019

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/2 breakpad: Update dont-clobber-rsp patch to latest

This is based on upstream submission

---
 .../breakpad/breakpad/dont-clobber-rsp.patch  | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
meta-oe/recipes-devtools/breakpad/breakpad/dont-clobber-rsp.patch +46 -0
index b1c37fc8e9..edf903552d 100644
@@ -1,3 +1,8 @@
+From d1d7b616219fd47736c804ff4c2f393d7184a75b Mon Sep 17 00:00:00 2001
+From: Khem Raj <[email protected]>
+Date: Sun, 23 Dec 2018 16:58:04 -0800
+Subject: [PATCH] chromium: stack pointer clobber
+
 Do not add stack pointer to clobber list
 
 it was being ignored until gcc 9.0 became capable
@@ -7,9 +12,23 @@ of flagging this silent ignoring via [1]
 
 Upstream-Status: Submitted [https://chromium-review.googlesource.com/c/linux-syscall-support/+/1390160]
 Signed-off-by: Khem Raj <[email protected]>
+---
+ src/third_party/lss/linux_syscall_support.h | 10 +++++-----
+ 1 file changed, 5 insertions(+), 5 deletions(-)
 
+Index: b/src/third_party/lss/linux_syscall_support.h
+===================================================================
 --- a/src/third_party/lss/linux_syscall_support.h
 +++ b/src/third_party/lss/linux_syscall_support.h
+@@ -1957,7 +1957,7 @@ struct kernel_statfs {
+                            LSS_ENTRYPOINT                                     \
+                            "pop %%ebx"                                        \
+                            args                                               \
+-                           : "esp", "memory");                                \
++                           : "memory");                                       \
+       LSS_RETURN(type,__res)
+     #undef  _syscall0
+     #define _syscall0(type,name)                                              \
 @@ -1966,7 +1966,7 @@ struct kernel_statfs {
          __asm__ volatile(LSS_ENTRYPOINT                                       \
                           : "=a" (__res)                                       \
@@ -19,6 +38,33 @@ Signed-off-by: Khem Raj <[email protected]>
          LSS_RETURN(type,__res);                                               \
        }
      #undef  _syscall1
+@@ -2014,7 +2014,7 @@ struct kernel_statfs {
+                              : "i" (__NR_##name), "ri" ((long)(arg1)),        \
+                                "c" ((long)(arg2)), "d" ((long)(arg3)),        \
+                                "S" ((long)(arg4)), "D" ((long)(arg5))         \
+-                             : "esp", "memory");                              \
++                             : "memory");                                     \
+         LSS_RETURN(type,__res);                                               \
+       }
+     #undef  _syscall6
+@@ -2036,7 +2036,7 @@ struct kernel_statfs {
+                              : "i" (__NR_##name),  "0" ((long)(&__s)),        \
+                                "c" ((long)(arg2)), "d" ((long)(arg3)),        \
+                                "S" ((long)(arg4)), "D" ((long)(arg5))         \
+-                             : "esp", "memory");                              \
++                             : "memory");                                     \
+         LSS_RETURN(type,__res);                                               \
+       }
+     LSS_INLINE int LSS_NAME(clone)(int (*fn)(void *), void *child_stack,
+@@ -2122,7 +2122,7 @@ struct kernel_statfs {
+                            : "0"(-EINVAL), "i"(__NR_clone),
+                              "m"(fn), "m"(child_stack), "m"(flags), "m"(arg),
+                              "m"(parent_tidptr), "m"(newtls), "m"(child_tidptr)
+-                           : "esp", "memory", "ecx", "edx", "esi", "edi");
++                           : "memory", "ecx", "edx", "esi", "edi");
+       LSS_RETURN(int, __res);
+     }
+ 
 @@ -2407,7 +2407,7 @@ struct kernel_statfs {
                                 "d"(LSS_SYSCALL_ARG(parent_tidptr)),
                                 "r"(LSS_SYSCALL_ARG(newtls)),
Signature · 1 line
2.23.0
author
#1 lore raw

PATCH 2/2 gparted: add to deps instead of overwriting

Thsi recipe inherits gtk-icon-cache which adds hicolor-icon-theme to dependencies conditionally, this however gets lost if the DEPENDS is using = instead of +=

Fixes

ERROR: QA Issue: gparted rdepends on hicolor-icon-theme, but it isn't a build dependency, missing hicolor-icon-theme in DEPENDS or PACKAGECONFIG? [build-deps]

---
 meta-gnome/recipes-extended/gparted/gparted_0.33.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-gnome/recipes-extended/gparted/gparted_0.33.0.bb +1 -1
index a9f6993fbc..de143b9c87 100644
@@ -15,7 +15,7 @@ SRC_URI = " \
 SRC_URI[md5sum] = "2f481ad34decb7021ca04ca305e79e7d"
 SRC_URI[sha256sum] = "5023b8c983f88a22e65bf6f09a12ea09369defc008981b52ee8b96a3879f81d6"
 
-DEPENDS = "glib-2.0 glib-2.0-native gtkmm parted gnome-doc-utils intltool-native"
+DEPENDS += "glib-2.0 glib-2.0-native gtkmm parted gnome-doc-utils intltool-native"
 
 do_install_append() {
     # Add a script which checks if polkit is installed.
Signature · 1 line
2.23.0