KVM: s390: Remove unused parameter from __inject_sigp_restart()
PATCH 1/1 KVM: s390: Remove unused parameter from __inject_sigp_restart()
It's not required, so drop it to make it clear that this interrupt does not have any extra parameters.
Signed-off-by Thomas Huth <[email protected]>
--- arch/s390/kvm/interrupt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
arch/s390/kvm/interrupt.c +2 -3
@@ -1477,8 +1477,7 @@ static int __inject_sigp_stop(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq)return 0 ; } -static int __inject_sigp_restart (struct kvm_vcpu *vcpu, -struct kvm_s390_irq *irq) +static int __inject_sigp_restart (struct kvm_vcpu *vcpu) {struct kvm_s390_local_interrupt *li = &vcpu->arch.local_int;
@@ -1997,7 +1996,7 @@ static int do_inject_vcpu(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq) rc =__inject_sigp_stop (vcpu, irq);break ;case KVM_S390_RESTART : - rc =__inject_sigp_restart (vcpu, irq); + rc =__inject_sigp_restart (vcpu);break ;case KVM_S390_INT_CLOCK_COMP : rc =__inject_ckc (vcpu);
Signature · 1 line
2.18.1
Quoted 4 lines · Thomas Huth
It's not required, so drop it to make it clear that this interrupt does not have any extra parameters.
Signed-off-by Thomas Huth <[email protected]>
Well there's no real use for any other parameter than the target cpu, so:
Reviewed-by Janosch Frank <[email protected]>
Quoted 28 lines
--- arch/s390/kvm/interrupt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)arch/s390/kvm/interrupt.c +2
-3@@ -1477,8 +1477,7 @@ static int __inject_sigp_stop(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq)return 0 ; } -static int __inject_sigp_restart (struct kvm_vcpu *vcpu, -struct kvm_s390_irq *irq) +static int __inject_sigp_restart (struct kvm_vcpu *vcpu) {struct kvm_s390_local_interrupt *li = &vcpu->arch.local_int;@@ -1997,7 +1996,7 @@ static int do_inject_vcpu(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq) rc =__inject_sigp_stop (vcpu, irq);break ;case KVM_S390_RESTART : - rc =__inject_sigp_restart (vcpu, irq); + rc =__inject_sigp_restart (vcpu);break ;case KVM_S390_INT_CLOCK_COMP : rc =__inject_ckc (vcpu);
Quoted 24 lines · Thomas Huth
It's not required, so drop it to make it clear that this interrupt does not have any extra parameters.
Signed-off-by Thomas Huth <[email protected]>--- arch/s390/kvm/interrupt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)arch/s390/kvm/interrupt.c +1
-2@@ -1477,8 +1477,7 @@ static int __inject_sigp_stop(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq)return 0 ; } -static int __inject_sigp_restart (struct kvm_vcpu *vcpu, -struct kvm_s390_irq *irq) +static int __inject_sigp_restart (struct kvm_vcpu *vcpu) {struct kvm_s390_local_interrupt *li = &vcpu->arch.local_int;
arch/s390/kvm/interrupt.c static int do_inject_vcpu(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq) · line 2002
Quoted 8 lines
arch/s390/kvm/interrupt.c +1
-1@@ -1997,7 +1996,7 @@ static int do_inject_vcpu(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq) rc =__inject_sigp_stop (vcpu, irq);break ;case KVM_S390_RESTART : - rc =__inject_sigp_restart (vcpu, irq); + rc =__inject_sigp_restart (vcpu);break ;case KVM_S390_INT_CLOCK_COMP : rc =__inject_ckc (vcpu);
Yeah, why not
Reviewed-by David Hildenbrand <[email protected]>
Signature · 3 lines
Thanks, David / dhildenb
Quoted 4 lines · Thomas Huth
It's not required, so drop it to make it clear that this interrupt does not have any extra parameters.
Signed-off-by Thomas Huth <[email protected]>
makes sense. Thanks applied.
Quoted 28 lines
--- arch/s390/kvm/interrupt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)arch/s390/kvm/interrupt.c +2
-3@@ -1477,8 +1477,7 @@ static int __inject_sigp_stop(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq)return 0 ; } -static int __inject_sigp_restart (struct kvm_vcpu *vcpu, -struct kvm_s390_irq *irq) +static int __inject_sigp_restart (struct kvm_vcpu *vcpu) {struct kvm_s390_local_interrupt *li = &vcpu->arch.local_int;@@ -1997,7 +1996,7 @@ static int do_inject_vcpu(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq) rc =__inject_sigp_stop (vcpu, irq);break ;case KVM_S390_RESTART : - rc =__inject_sigp_restart (vcpu, irq); + rc =__inject_sigp_restart (vcpu);break ;case KVM_S390_INT_CLOCK_COMP : rc =__inject_ckc (vcpu);