Skip to contentSkip to conversation

hw/net/vmxnet3: Fix leftover unregister_savevm

PATCH In review Dr. David Alan Gilbert (git) 2 participants 3 messages Aug 22, 2019 – Sep 12, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/net/vmxnet3: Fix leftover unregister_savevm

From: "Dr. David Alan Gilbert" <[email protected]>

Commit 78dd48df3 reworked vmxnet3's live migration but left a straggling unregister_savevm call. Remove it, although it doesn't seem to have any bad effect.

---
 hw/net/vmxnet3.c | 3 ---
 1 file changed, 3 deletions(-)
hw/net/vmxnet3.c +0 -3
index b07adeed9c..39ff6624c5 100644
@@ -2242,13 +2242,10 @@ static void vmxnet3_instance_init(Object *obj)
 
 static void vmxnet3_pci_uninit(PCIDevice *pci_dev)
 {
-    DeviceState *dev = DEVICE(pci_dev);
     VMXNET3State *s = VMXNET3(pci_dev);
 
     VMW_CBPRN("Starting uninit...");
 
-    unregister_savevm(dev, "vmxnet3-msix", s);
-
     vmxnet3_net_uninit(s);
 
     vmxnet3_cleanup_msix(s);
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Dr. David Alan Gilbert (git)

From: "Dr. David Alan Gilbert" <[email protected]>

Commit 78dd48df3 reworked vmxnet3's live migration but left a straggling unregister_savevm call. Remove it, although it doesn't seem to have any bad effect.

Quoted 26 lines

---
hw/net/vmxnet3.c | 3 ---

1 file changed, 3 deletions(-)
hw/net/vmxnet3.c +0 -3
index b07adeed9c..39ff6624c5 100644
@@ -2242,13 +2242,10 @@ static void vmxnet3_instance_init(Object *obj)
 
 static void vmxnet3_pci_uninit(PCIDevice *pci_dev)
 {
-    DeviceState *dev = DEVICE(pci_dev);
    VMXNET3State *s = VMXNET3(pci_dev);
 
    VMW_CBPRN("Starting uninit...");
 
-    unregister_savevm(dev, "vmxnet3-msix", s);
-
    vmxnet3_net_uninit(s);
 
    vmxnet3_cleanup_msix(s);
Signature · 1 line
2.21.0
#2 lore raw
In reply to Dr. David Alan Gilbert (git)
Quoted 7 lines · * Dr. David Alan Gilbert (git) ([email protected]) wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

Commit 78dd48df3 reworked vmxnet3's live migration but left a straggling unregister_savevm call. Remove it, although it doesn't seem to have any bad effect.

Queued

Quoted 26 lines
---
 hw/net/vmxnet3.c | 3 ---
 1 file changed, 3 deletions(-)
hw/net/vmxnet3.c +0 -3
index b07adeed9c..39ff6624c5 100644
@@ -2242,13 +2242,10 @@ static void vmxnet3_instance_init(Object *obj)
 
 static void vmxnet3_pci_uninit(PCIDevice *pci_dev)
 {
-    DeviceState *dev = DEVICE(pci_dev);
     VMXNET3State *s = VMXNET3(pci_dev);
 
     VMW_CBPRN("Starting uninit...");
 
-    unregister_savevm(dev, "vmxnet3-msix", s);
-
     vmxnet3_net_uninit(s);
 
     vmxnet3_cleanup_msix(s);
Signature · 1 line
2.21.0

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK