Skip to contentSkip to conversation

mycroft: Make rdep on alsa-oss conditional on glibc

PATCH In review Khem Raj 2 participants 3 messages Sep 12, 2019 – Sep 13, 2019

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 mycroft: Make rdep on alsa-oss conditional on glibc

alsa-oss does not build for musl so its marked incompatible for musl

---
 meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.3.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.3.bb +2 -1
index becd0bf790..8d1c9179be 100644
@@ -64,7 +64,8 @@ RDEPENDS_${PN} += "python3-pip \
                  "
 
 # Mycroft uses Alsa, PulseAudio and Flac
-RDEPENDS_${PN} += "alsa-oss alsa-utils alsa-plugins alsa-tools"
+RDEPENDS_${PN} += "alsa-utils alsa-plugins alsa-tools"
+RDEPENDS_${PN}_append_libc-glibc = " alsa-oss"
 RDEPENDS_${PN} += "pulseaudio pulseaudio-misc pulseaudio-server"
 RDEPENDS_${PN} += "flac"
 
Signature · 1 line
2.23.0
#1 lore raw

meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.3.bb RDEPENDS_${PN} += "python3-pip \ · line 68

Quoted 7 lines · Khem Raj

alsa-oss does not build for musl so its marked incompatible for musl
...
# Mycroft uses Alsa, PulseAudio and Flac

meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.3.bb +2 -1
-RDEPENDS_${PN} += "alsa-oss alsa-utils alsa-plugins alsa-tools"
+RDEPENDS_${PN} += "alsa-utils alsa-plugins alsa-tools"
+RDEPENDS_${PN}_append_libc-glibc = " alsa-oss"
...

This looks wrong - either it needs also-oss or it does not need it.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#2 lore raw
Quoted 11 lines · Adrian Bunk

meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.3.bb RDEPENDS_${PN} += "python3-pip \ · line 68

Quoted 7 lines · Khem Raj

alsa-oss does not build for musl so its marked incompatible for musl
...
# Mycroft uses Alsa, PulseAudio and Flac

meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.3.bb +2 -1
-RDEPENDS_${PN} += "alsa-oss alsa-utils alsa-plugins alsa-tools"
+RDEPENDS_${PN} += "alsa-utils alsa-plugins alsa-tools"
+RDEPENDS_${PN}_append_libc-glibc = " alsa-oss"
...

This looks wrong - either it needs also-oss or it does not need it.

actually I do not see is needing alsa-oss, it seems to be ok with pulseadio-alsa plugins
but since I have only tried with musl I tried to keep it unmodified for glibc but I guess we
should just remove it.

Quoted 11 lines

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed