backlight_lm3630a: add enable_gpios property
Subsystems (4)
v4 cover backlight_lm3630a: add enable_gpios property
To be able to handle the HWEN pin of the lm3630a, add an enable gpio to the driver and a property.
Tested on Kobo Clara HD.
Changes in v2:
simplification and reordering
Changes in v3:
added acked-by
removed legacy include
Changes in v4:
added reviewed-by
moved gpio to the right position in the bindings example
Andreas Kemnade (2):
dt-bindings: backlight: lm3630a: add enable_gpios
backlight: lm3630a: add an enable gpio for the HWEN pin
.../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ drivers/video/backlight/lm3630a_bl.c | 9 +++++++++ 2 files changed, 14 insertions(+)
Signature · 1 line
2.20.1
PATCH v4 1/2 dt-bindings: backlight: lm3630a: add enable_gpios
add enable-gpios to describe HWEN pin
---
changes in v2: added example
changes in v3: added Acked-by
changes in v4: moved enable-gpios to the right position
in the example
.../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml +5 -0
@@ -29,6 +29,10 @@ properties: '#size-cells': const: 0 + enable-gpios: + description: GPIO to use to enable/disable the backlight (HWEN pin). + maxItems: 1 + required: - compatible - reg
@@ -96,6 +100,7 @@ examples: led-controller@38 { compatible = "ti,lm3630a"; reg = <0x38>; + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; #address-cells = <1>; #size-cells = <0>;
Signature · 1 line
2.20.1
Re: [PATCH v4 1/2] dt-bindings: backlight: lm3630a: add enable_gpios
Andreas
Quoted 4 lines · Andreas Kemnade
add enable-gpios to describe HWEN pin
Signed-off-by Andreas Kemnade <[email protected]>Acked-by Daniel Thompson <[email protected]>
Quoted 31 lines
---
changes in v2: added example
changes in v3: added Acked-by
changes in v4: moved enable-gpios to the right position
in the example.../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml +5
-0@@ -29,6 +29,10 @@ properties: '#size-cells': const: 0 + enable-gpios: + description: GPIO to use to enable/disable the backlight (HWEN pin). + maxItems: 1 + required: - compatible - reg@@ -96,6 +100,7 @@ examples: led-controller@38 { compatible = "ti,lm3630a"; reg = <0x38>; + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; #address-cells = <1>; #size-cells = <0>;
Re: [PATCH v4 1/2] dt-bindings: backlight: lm3630a: add enable_gpios
In reply to Andreas KemnadeQuoted 4 lines · Andreas Kemnade
add enable-gpios to describe HWEN pin
Signed-off-by Andreas Kemnade <[email protected]>Acked-by Daniel Thompson <[email protected]>
Quoted 8 lines
---
changes in v2: added example
changes in v3: added Acked-by
changes in v4: moved enable-gpios to the right position
in the example.../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Lee Jones
AppliedRe: [PATCH v4 1/2] dt-bindings: backlight: lm3630a: Add enable-gpios to describe HWEN pin
In reply to Andreas KemnadeQuoted 6 lines · Andreas Kemnade
Provide DT documentation for enable-gpios.
Signed-off-by Andreas Kemnade <[email protected]>Acked-by Daniel Thompson <[email protected]>Reviewed-by Rob Herring <[email protected]>Reviewed-by Dan Murphy <[email protected]>
Quoted 7 lines
---
changes in v2: added example
changes in v3: added Acked-by
changes in v4: moved enable-gpios to the right position
in the example.../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Applied, thanks.
Signature · 8 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v4 1/2] dt-bindings: backlight: lm3630a: add enable_gpios
In reply to Andreas KemnadeQuoted 5 lines · Andreas Kemnade
add enable-gpios to describe HWEN pin
Signed-off-by Andreas Kemnade <[email protected]>Acked-by Daniel Thompson <[email protected]>
This breaking linux-next now...
Quoted 24 lines
---
changes in v2: added example
changes in v3: added Acked-by
changes in v4: moved enable-gpios to the right position
in the example.../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml +4
-0@@ -29,6 +29,10 @@ properties: '#size-cells': const: 0 + enable-gpios: + description: GPIO to use to enable/disable the backlight (HWEN pin). + maxItems: 1 + required: - compatible - reg
Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml examples: · line 103
Quoted 4 lines
Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml +1
-0@@ -96,6 +100,7 @@ examples: led-controller@38 { compatible = "ti,lm3630a"; reg = <0x38>; + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>;
Error: Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dts:24.46-47 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml] Error 1scripts/Makefile.lib:314: recipe for target 'Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml' failed
You need the include for the define.
Rob
Re: [PATCH v4 1/2] dt-bindings: backlight: lm3630a: add enable_gpios
Hi,
Quoted 9 lines · On Mon, 28 Oct 2019 18:25:56 -0500 Rob Herring <[email protected]> wrote:
Quoted 5 lines · Andreas Kemnade
add enable-gpios to describe HWEN pin
Signed-off-by Andreas Kemnade <[email protected]>Acked-by Daniel Thompson <[email protected]>This breaking linux-next now...
oops, sorry.
Quoted 38 lines
Quoted 24 lines
---
changes in v2: added example
changes in v3: added Acked-by
changes in v4: moved enable-gpios to the right position
in the example.../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml +4
-0@@ -29,6 +29,10 @@ properties: '#size-cells': const: 0 + enable-gpios: + description: GPIO to use to enable/disable the backlight (HWEN pin). + maxItems: 1 + required: - compatible - regDocumentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml examples: · line 103
Quoted 4 lines
Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml +1
-0@@ -96,6 +100,7 @@ examples: led-controller@38 { compatible = "ti,lm3630a"; reg = <0x38>; + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>;Error: Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dts:24.46-47 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml] Error 1scripts/Makefile.lib:314: recipe for target 'Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml' failed
Quoted 1 line
You need the include for the define.
gpio/gpio.h is missing.
Yes, was not aware of that these things will be compiled and the automatic check did not work on my system at all. So I decided not to fix that for just this simple thing which was a not so good idea.
Will send a fixup.
Regards,
Andreas
PATCH v4 2/2 backlight: lm3630a: add an enable gpio for the HWEN pin
In reply to Andreas KemnadeFor now just enable it in the probe function to allow i2c access. Disabling also means resetting the register values to default and according to the datasheet does not give power savings.
Tested on Kobo Clara HD.
---
changes in v2:
- simplification
- correct gpio direction initialisation
changes in v3:
- removed legacy include
drivers/video/backlight/lm3630a_bl.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/video/backlight/lm3630a_bl.c +9 -0
@@ -12,6 +12,7 @@#include <linux/uaccess.h> #include <linux/interrupt.h> #include <linux/regmap.h> +#include <linux/gpio/consumer.h> #include <linux/pwm.h> #include <linux/platform_data/lm3630a_bl.h>
@@ -48,6 +49,7 @@ struct lm3630a_chip {struct lm3630a_platform_data *pdata;struct backlight_device *bleda;struct backlight_device *bledb; +struct gpio_desc *enable_gpio;struct regmap *regmap;struct pwm_device *pwmd; };
@@ -535,6 +537,13 @@ static int lm3630a_probe(struct i2c_client *client, } pchip->pdata = pdata; + pchip->enable_gpio =devm_gpiod_get_optional (&client->dev,"enable" , +GPIOD_OUT_HIGH ); +if (IS_ERR (pchip->enable_gpio)) { + rval =PTR_ERR (pchip->enable_gpio); +return rval; + } +/* chip initialize */ rval =lm3630a_chip_init (pchip);if (rval <0 ) {
Signature · 1 line
2.20.1
Lee Jones
AppliedRe: [PATCH v4 2/2] backlight: lm3630a: Add an enable gpio for the HWEN pin
Quoted 15 lines · Andreas Kemnade
For now just enable it in the probe function to allow I2C access. Disabling also means resetting the register values to default and according to the datasheet does not give power savings.
Tested on Kobo Clara HD.
Signed-off-by Andreas Kemnade <[email protected]>Reviewed-by Dan Murphy <[email protected]>Reviewed-by Daniel Thompson <[email protected]>---
changes in v2:
- simplification
- correct gpio direction initialisation
Quoted 5 lines
changes in v3:
- removed legacy includedrivers/video/backlight/lm3630a_bl.c | 9 +++++++++ 1 file changed, 9 insertions(+)
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog