net: dsa: b53: Add support for port_egress_floods callback
PATCH 1/1 net: dsa: b53: Add support for port_egress_floods callback
Add support for configuring the per-port egress flooding control for both Unicast and Multicast traffic.
---
Beneditk,
Do you mind re-testing, or confirming that this patch that I sent much earlier does work correctly for you? Thanks!
drivers/net/dsa/b53/b53_common.c | 33 ++++++++++++++++++++++++++++++++ drivers/net/dsa/b53/b53_priv.h | 2 ++ 2 files changed, 35 insertions(+)
drivers/net/dsa/b53/b53_common.c +33 -0
@@ -342,6 +342,13 @@ static void b53_set_forwarding(struct b53_device *dev, int enable)b53_read8 (dev,B53_CTRL_PAGE ,B53_SWITCH_CTRL , &mgmt); mgmt |=B53_MII_DUMB_FWDG_EN ;b53_write8 (dev,B53_CTRL_PAGE ,B53_SWITCH_CTRL , mgmt); + +/* Look at B53_UC_FWD_EN and B53_MC_FWD_EN to decide whether +* frames should be flooed or not. +*/ +b53_read8 (dev,B53_CTRL_PAGE ,B53_IP_MULTICAST_CTRL , &mgmt); + mgmt |=B53_UC_FWD_EN |B53_MC_FWD_EN ; +b53_write8 (dev,B53_CTRL_PAGE ,B53_IP_MULTICAST_CTRL , mgmt); } static void b53_enable_vlan(struct b53_device *dev, bool enable,
@@ -1753,6 +1760,31 @@ void b53_br_fast_age(struct dsa_switch *ds, int port) }EXPORT_SYMBOL (b53_br_fast_age); +int b53_br_egress_floods (struct dsa_switch *ds,int port, +bool unicast,bool multicast) +{ +struct b53_device *dev = ds->priv; +u16 uc, mc; + +b53_read16 (dev,B53_CTRL_PAGE ,B53_UC_FWD_EN , &uc); +if (unicast) + uc |=BIT (port); +else + uc &= ~BIT (port); +b53_write16 (dev,B53_CTRL_PAGE ,B53_UC_FWD_EN , uc); + +b53_read16 (dev,B53_CTRL_PAGE ,B53_MC_FWD_EN , &mc); +if (multicast) + mc |=BIT (port); +else + mc &= ~BIT (port); +b53_write16 (dev,B53_CTRL_PAGE ,B53_MC_FWD_EN , mc); + +return 0 ; + +} +EXPORT_SYMBOL (b53_br_egress_floods); +static bool b53_possible_cpu_port (struct dsa_switch *ds,int port) {/* Broadcom switches will accept enabling Broadcom tags on the
@@ -1953,6 +1985,7 @@ static const struct dsa_switch_ops b53_switch_ops = { .port_bridge_leave = b53_br_leave, .port_stp_state_set = b53_br_set_stp_state, .port_fast_age = b53_br_fast_age, + .port_egress_floods = b53_br_egress_floods, .port_vlan_filtering = b53_vlan_filtering, .port_vlan_prepare = b53_vlan_prepare, .port_vlan_add = b53_vlan_add,
drivers/net/dsa/b53/b53_priv.h +2 -0
@@ -319,6 +319,8 @@ int b53_br_join(struct dsa_switch *ds, int port, struct net_device *bridge);void b53_br_leave (struct dsa_switch *ds,int port,struct net_device *bridge);void b53_br_set_stp_state (struct dsa_switch *ds,int port,u8 state);void b53_br_fast_age (struct dsa_switch *ds,int port); +int b53_br_egress_floods (struct dsa_switch *ds,int port, +bool unicast,bool multicast);void b53_port_event (struct dsa_switch *ds,int port); void b53_phylink_validate(struct dsa_switch *ds, int port, unsigned long *supported,
Signature · 1 line
2.17.1
Quoted 19 lines · Florian Fainelli
Add support for configuring the per-port egress flooding control for both Unicast and Multicast traffic.
Signed-off-by Florian Fainelli <[email protected]>---
Beneditk,Do you mind re-testing, or confirming that this patch that I sent much earlier does work correctly for you? Thanks!
drivers/net/dsa/b53/b53_common.c | 33 ++++++++++++++++++++++++++++++++ drivers/net/dsa/b53/b53_priv.h | 2 ++ 2 files changed, 35 insertions(+)drivers/net/dsa/b53/b53_common.c +0
-0
drivers/net/dsa/b53/b53_common.c static void b53_set_forwarding(struct b53_device *dev, int enable) · line 347
Quoted 6 lines
drivers/net/dsa/b53/b53_common.c +3
-0@@ -342,6 +342,13 @@ static void b53_set_forwarding(struct b53_device *dev, int enable)b53_read8 (dev,B53_CTRL_PAGE ,B53_SWITCH_CTRL , &mgmt); mgmt |=B53_MII_DUMB_FWDG_EN ;b53_write8 (dev,B53_CTRL_PAGE ,B53_SWITCH_CTRL , mgmt); + +/* Look at B53_UC_FWD_EN and B53_MC_FWD_EN to decide whether +* frames should be flooed or not.
Hi Florian
s/flooed/flooded
Andrew
David Miller
maintainerFrom: Florian Fainelli <[email protected]>
Date: Thu, 12 Sep 2019 20:28:39 -0700
Quoted 4 lines
Add support for configuring the per-port egress flooding control for both Unicast and Multicast traffic.
Signed-off-by Florian Fainelli <[email protected]>
Applied with comment typo fixed.