Skip to contentSkip to conversation

xen: fix arm build with debugtrace configured

PATCH In review Juergen Gross 3 participants 3 messages Sep 13, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen: fix arm build with debugtrace configured

Add missing #includes.

---
 xen/common/debugtrace.c | 2 ++
 1 file changed, 2 insertions(+)
xen/common/debugtrace.c +2 -0
index 5d22d431ad..7313e89389 100644
@@ -11,7 +11,9 @@
 #include <xen/keyhandler.h>
 #include <xen/lib.h>
 #include <xen/mm.h>
+#include <xen/percpu.h>
 #include <xen/serial.h>
+#include <xen/smp.h>
 #include <xen/spinlock.h>
 #include <xen/watchdog.h>
 
Signature · 7 lines
2.16.4


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Juergen Gross

Add missing #includes.

Albeit for the future it would be nice if the connection to the actual breakage was established in the description, by mentioning the offending commit and/or by naming the specific build problem.

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#2 lore raw

Hi Jan,

Quoted 10 lines · Jan Beulich
Quoted 3 lines · Juergen Gross

Add missing #includes.

Albeit for the future it would be nice if the connection to the actual breakage was established in the description, by mentioning the offending commit and/or by naming the specific build problem.

It would have been nice you the commit message was at least updated before committing. With the current one it is unclear why it is necessary so it feels quite random.

Cheers,

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel