Skip to contentSkip to conversation

x86/mm: Enable 5-level paging support by default

PATCH Applied Kirill A. Shutemov 4 participants 4 messages Sep 13, 2019 – Sep 16, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/mm: Enable 5-level paging support by default

Support of boot-time switching between 4- and 5-level paging mode is upstream since 4.17.

We run internal testing with 5-level paging support enabled for a while and it doesn't not cause any functional or performance regression on 4-level paging hardware.

The only 5-level paging related regressions I saw were in early boot code that runs independently from CONFIG_X86_5LEVEL.

The next major release of distributions expected to have CONFIG_X86_5LEVEL=y.

Enable the option by default. It may help to catch obscure bugs early.

---
 arch/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/x86/Kconfig +1 -0
index 222855cc0158..2f7cb91d850e 100644
@@ -1483,6 +1483,7 @@ config X86_PAE
 
 config X86_5LEVEL
 	bool "Enable 5-level page tables support"
+	default y
 	select DYNAMIC_MEMORY_LAYOUT
 	select SPARSEMEM_VMEMMAP
 	depends on X86_64
Signature · 1 line
2.21.0
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Kirill A. Shutemov

The next major release of distributions expected to have CONFIG_X86_5LEVEL=y.

It's probably worth noting that this exposes to two kinds of possible performance issues:

First is the overhead of having the 5-level code on 4-level hardware. We haven't seen any regressions there in quite a while. Kirill talked about this in the changelog.

Second is the overhead of having 5-level paging active on 5-level hardware versus using 4-level paging on hardware *capable* of 5-level. That is, of course, much harder to measure since 5-level hardware is not publicly available. But, we've tested this quite a bit and we're pretty confident that it will not cause regressions, especially on systems where apps don't opt in to the larger address space.

I do think endeavoring to have mainline's defaults match the most common distro configs is a good idea, and now is as good of a time as any.

#2 lore raw
Quoted 18 lines · Dave Hansen
Quoted 2 lines · Kirill A. Shutemov

The next major release of distributions expected to have CONFIG_X86_5LEVEL=y.

It's probably worth noting that this exposes to two kinds of possible performance issues:

First is the overhead of having the 5-level code on 4-level hardware. We haven't seen any regressions there in quite a while. Kirill talked about this in the changelog.

Second is the overhead of having 5-level paging active on 5-level hardware versus using 4-level paging on hardware *capable* of 5-level. That is, of course, much harder to measure since 5-level hardware is not publicly available. But, we've tested this quite a bit and we're pretty confident that it will not cause regressions, especially on systems where apps don't opt in to the larger address space.

Quoted 4 lines

I do think endeavoring to have mainline's defaults match the most common distro configs is a good idea, and now is as good of a time as any.

Ok - in terms of timing it's obviously *way* too late for v5.4, so I've queued it up for the v5.5 merge window in tip:x86/mm. This should give it 2-3 months of additional testing to shake out any weird interactions and quirks.

Thanks,

Ingo

#3 lore raw
In reply to Kirill A. Shutemov
The following commit has been merged into the x86/mm branch of tip:

The following commit has been merged into the x86/mm branch of tip:

Commit-ID:     18ec1eaf58fbf2d9009a752a102a3d8e0d905a0f
Gitweb:        https://git.kernel.org/tip/18ec1eaf58fbf2d9009a752a102a3d8e0d905a0f
Author:        Kirill A. Shutemov <[email protected]>
AuthorDate:    Fri, 13 Sep 2019 12:54:52 +03:00
Committer:     Ingo Molnar <[email protected]>
CommitterDate: Mon, 16 Sep 2019 16:51:20 +02:00

x86/mm: Enable 5-level paging support by default

Support of boot-time switching between 4- and 5-level paging mode is upstream since 4.17.

We run internal testing with 5-level paging support enabled for a while and it doesn't not cause any functional or performance regression on 4-level paging hardware.

The only 5-level paging related regressions I saw were in early boot code that runs independently from CONFIG_X86_5LEVEL.

The next major release of distributions expected to have CONFIG_X86_5LEVEL=y.

Enable the option by default. It may help to catch obscure bugs early.

---
 arch/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/x86/Kconfig +1 -0
index 58eae28..d4bbebe 100644
@@ -1483,6 +1483,7 @@ config X86_PAE
 
 config X86_5LEVEL
 	bool "Enable 5-level page tables support"
+	default y
 	select DYNAMIC_MEMORY_LAYOUT
 	select SPARSEMEM_VMEMMAP
 	depends on X86_64