Skip to contentSkip to conversation

selftest/trustedkeys: TPM 1.2 trusted keys test

PATCH In review Mimi Zohar 4 participants 20 messages Sep 10, 2019 – Oct 22, 2019

Subsystems (3)
lore
Share & tools
lore

Mimi Zohar

author maintainer
#0 lore raw

PATCH 1/1 selftest/trustedkeys: TPM 1.2 trusted keys test

Create, save and load trusted keys test

---
 tools/testing/selftests/tpm2/Makefile            |  2 +-
 tools/testing/selftests/tpm2/test_trustedkeys.sh | 99 ++++++++++++++++++++++++
 2 files changed, 100 insertions(+), 1 deletion(-)
 create mode 100755 tools/testing/selftests/tpm2/test_trustedkeys.sh
tools/testing/selftests/tpm2/Makefile +1 -1
index 9dd848427a7b..6c76495c9a69 100644
@@ -1,4 +1,4 @@
 # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
 include ../lib.mk
 
-TEST_PROGS := test_smoke.sh test_space.sh
+TEST_PROGS := test_smoke.sh test_space.sh test_trustedkey.sh
tools/testing/selftests/tpm2/test_trustedkeys.sh new file +99 -0

99 lines not on this page · raw message

Signature · 1 line
2.7.5
author maintainer
#1 lore raw
Quoted 1 line · Mimi Zohar

Create, save and load trusted keys test

Creating trusted keys is failing with the following messages. Any idea why?

[  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
[  147.014678] trusted_key: srkseal failed (-1)
[  147.014687] trusted_key: key_seal failed (-1)

Mimi

author maintainer
#2 lore raw
Quoted 8 lines · Mimi Zohar
Quoted 1 line · Mimi Zohar

Create, save and load trusted keys test

Creating trusted keys is failing with the following messages. Any idea why?

[  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
[  147.014678] trusted_key: srkseal failed (-1)
[  147.014687] trusted_key: key_seal failed (-1)

This is a regression, that needs to be resolved.  The test works on kernels prior to 5.1.

Mimi

#3 lore raw
Quoted 4 lines · Mimi Zohar
Quoted 3 lines · Mimi Zohar
Quoted 1 line · Mimi Zohar

Create, save and load trusted keys test

Quoted 8 lines
Quoted 5 lines

Creating trusted keys is failing with the following messages. Any idea why?

[  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
[  147.014678] trusted_key: srkseal failed (-1)
[  147.014687] trusted_key: key_seal failed (-1)

This is a regression, that needs to be resolved.  The test works on kernels prior to 5.1.

It breaks on 5.2?

Can you bisect the failing commit?

/Jarkko

author maintainer
#4 lore raw
Quoted 7 lines · Jarkko Sakkinen
Quoted 6 lines · Mimi Zohar
Quoted 5 lines · Mimi Zohar
Quoted 1 line · Mimi Zohar

Create, save and load trusted keys test

Creating trusted keys is failing with the following messages. Any idea why?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
[  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
[  147.014678] trusted_key: srkseal failed (-1)
[  147.014687] trusted_key: key_seal failed (-1)

This is a regression, that needs to be resolved.  The test works on kernels prior to 5.1.

It breaks on 5.2?

No, the regression is in 5.1.

Quoted 2 lines

Can you bisect the failing commit?

git bisect start -- drivers/char/tpm/
git bisect bad
git bisect good v5.0

# first bad commit: [412eb585587a1dc43c9622db79de9663b6c4c238] tpm:
use tpm_buf in tpm_transmit_cmd() as the IO parameter

Mimi

author maintainer
#5 lore raw
Quoted 20 lines · Mimi Zohar
Quoted 7 lines · Jarkko Sakkinen
Quoted 6 lines · Mimi Zohar
Quoted 5 lines · Mimi Zohar
Quoted 1 line · Mimi Zohar

Create, save and load trusted keys test

Creating trusted keys is failing with the following messages. Any idea why?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
[  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
[  147.014678] trusted_key: srkseal failed (-1)
[  147.014687] trusted_key: key_seal failed (-1)

This is a regression, that needs to be resolved.  The test works on kernels prior to 5.1.

It breaks on 5.2?

No, the regression is in 5.1.

Quoted 1 line
Quoted 8 lines
Quoted 1 line

Can you bisect the failing commit?

git bisect start -- drivers/char/tpm/
git bisect bad
git bisect good v5.0

# first bad commit: [412eb585587a1dc43c9622db79de9663b6c4c238] tpm:
use tpm_buf in tpm_transmit_cmd() as the IO parameter

In tpm_send(), setting buf.data directly to cmd, instead of calling tpm_buf_init() fixes the problem.

Mimi

#6 lore raw
Quoted 27 lines · Mimi Zohar
Quoted 26 lines · Mimi Zohar
Quoted 7 lines · Jarkko Sakkinen
Quoted 6 lines · Mimi Zohar
Quoted 5 lines · Mimi Zohar
Quoted 1 line · Mimi Zohar

Create, save and load trusted keys test

Creating trusted keys is failing with the following messages. Any idea why?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
[  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
[  147.014678] trusted_key: srkseal failed (-1)
[  147.014687] trusted_key: key_seal failed (-1)

This is a regression, that needs to be resolved.  The test works on kernels prior to 5.1.

It breaks on 5.2?

No, the regression is in 5.1.

Quoted 2 lines

Can you bisect the failing commit?

git bisect start -- drivers/char/tpm/
git bisect bad
git bisect good v5.0

Quoted 5 lines
Quoted 2 lines
# first bad commit: [412eb585587a1dc43c9622db79de9663b6c4c238] tpm:
use tpm_buf in tpm_transmit_cmd() as the IO parameter

In tpm_send(), setting buf.data directly to cmd, instead of calling tpm_buf_init() fixes the problem.

I see. Obviously memcpy() does not tpm_buf length. The implementation is kind of clunky but the point is to move building the tpm_buf to the caller (which is soon possible thanks to Sumit's patches).

I sent a fix candidate.

/Jarkko

#7 lore raw
Quoted 31 lines · Jarkko Sakkinen
Quoted 30 lines · Mimi Zohar
Quoted 28 lines · Mimi Zohar
Quoted 7 lines · Jarkko Sakkinen
Quoted 6 lines · Mimi Zohar
Quoted 5 lines · Mimi Zohar
Quoted 1 line · Mimi Zohar

Create, save and load trusted keys test

Creating trusted keys is failing with the following messages. Any idea why?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
[  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
[  147.014678] trusted_key: srkseal failed (-1)
[  147.014687] trusted_key: key_seal failed (-1)

This is a regression, that needs to be resolved.  The test works on kernels prior to 5.1.

It breaks on 5.2?

No, the regression is in 5.1.

Quoted 2 lines

Can you bisect the failing commit?

git bisect start -- drivers/char/tpm/
git bisect bad
git bisect good v5.0

# first bad commit: [412eb585587a1dc43c9622db79de9663b6c4c238] tpm:
use tpm_buf in tpm_transmit_cmd() as the IO parameter
Quoted 8 lines
Quoted 2 lines

In tpm_send(), setting buf.data directly to cmd, instead of calling tpm_buf_init() fixes the problem.

I see. Obviously memcpy() does not tpm_buf length. The implementation is kind of clunky but the point is to move building the tpm_buf to the caller (which is soon possible thanks to Sumit's patches).

I sent a fix candidate.

Ugh. Sorry about the "fix candidate". Your fix is the way it should be done. I'll put background to it once I've slept a bit.

/Jarkko

author maintainer
#8 lore raw
Quoted 35 lines · Jarkko Sakkinen
Quoted 34 lines · Jarkko Sakkinen
Quoted 32 lines · Mimi Zohar
Quoted 20 lines · Mimi Zohar
Quoted 7 lines · Jarkko Sakkinen
Quoted 6 lines · Mimi Zohar
Quoted 5 lines · Mimi Zohar
Quoted 1 line · Mimi Zohar

Create, save and load trusted keys test

Creating trusted keys is failing with the following messages. Any idea why?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
[  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
[  147.014678] trusted_key: srkseal failed (-1)
[  147.014687] trusted_key: key_seal failed (-1)

This is a regression, that needs to be resolved.  The test works on kernels prior to 5.1.

It breaks on 5.2?

No, the regression is in 5.1.

Quoted 1 line
Quoted 8 lines
Quoted 1 line

Can you bisect the failing commit?

git bisect start -- drivers/char/tpm/
git bisect bad
git bisect good v5.0

# first bad commit: [412eb585587a1dc43c9622db79de9663b6c4c238] tpm:
use tpm_buf in tpm_transmit_cmd() as the IO parameter

In tpm_send(), setting buf.data directly to cmd, instead of calling tpm_buf_init() fixes the problem.

Quoted 8 lines
Quoted 5 lines

I see. Obviously memcpy() does not tpm_buf length. The implementation is kind of clunky but the point is to move building the tpm_buf to the caller (which is soon possible thanks to Sumit's patches).

I sent a fix candidate.

Ugh. Sorry about the "fix candidate". Your fix is the way it should be done. I'll put background to it once I've slept a bit.

After trying different approaches that didn't work, I was about to give up .  It was late, but at the last second, I tried this.  Glad it works.

thanks,

Mimi

#9 lore raw
In reply to Mimi Zohar
Quoted 27 lines · Mimi Zohar
Quoted 26 lines · Mimi Zohar
Quoted 7 lines · Jarkko Sakkinen
Quoted 6 lines · Mimi Zohar
Quoted 5 lines · Mimi Zohar
Quoted 1 line · Mimi Zohar

Create, save and load trusted keys test

Creating trusted keys is failing with the following messages. Any idea why?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
[  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
[  147.014678] trusted_key: srkseal failed (-1)
[  147.014687] trusted_key: key_seal failed (-1)

This is a regression, that needs to be resolved.  The test works on kernels prior to 5.1.

It breaks on 5.2?

No, the regression is in 5.1.

Quoted 2 lines

Can you bisect the failing commit?

git bisect start -- drivers/char/tpm/
git bisect bad
git bisect good v5.0

Quoted 9 lines
Quoted 2 lines
# first bad commit: [412eb585587a1dc43c9622db79de9663b6c4c238] tpm:
use tpm_buf in tpm_transmit_cmd() as the IO parameter

In tpm_send(), setting buf.data directly to cmd, instead of calling tpm_buf_init() fixes the problem.

Mimi

The problem is that the command buffer is copied into the tpm_buf with the memcpy, but after the tpm_transmit_cmd, nothing gets copied back to be used by the code path that called tpm_send. There is code that looks at that buffer after trusted_tpm_send returns. Both security/keys/trusted.c and crypto/asymmetric_keys/asym_tpm.c run into this.

While playing around with it, adding a memcpy() after the transmit call worked for me as well as setting buf.data directly instead of the tpm_buf_init/memcpy/tpm_buf_destroy calls.

I'm wondering if it would be worthwhile to convert the security/keys/trusted.c and crypto/asymmertic_keys/aym_tpm.c code to use the same tpm_buf and tpm_buf manipulation code as gets used in drivers/char/tpm.

#10 lore raw
Quoted 46 lines · Jerry Snitselaar
Quoted 27 lines · Mimi Zohar
Quoted 26 lines · Mimi Zohar
Quoted 7 lines · Jarkko Sakkinen
Quoted 6 lines · Mimi Zohar
Quoted 5 lines · Mimi Zohar
Quoted 1 line · Mimi Zohar

Create, save and load trusted keys test

Creating trusted keys is failing with the following messages. Any idea why?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
[  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
[  147.014678] trusted_key: srkseal failed (-1)
[  147.014687] trusted_key: key_seal failed (-1)

This is a regression, that needs to be resolved. The test works on kernels prior to 5.1.

It breaks on 5.2?

No, the regression is in 5.1.

Quoted 2 lines

Can you bisect the failing commit?

git bisect start -- drivers/char/tpm/
git bisect bad
git bisect good v5.0

Quoted 9 lines
Quoted 2 lines
# first bad commit: [412eb585587a1dc43c9622db79de9663b6c4c238] tpm:
use tpm_buf in tpm_transmit_cmd() as the IO parameter

In tpm_send(), setting buf.data directly to cmd, instead of calling tpm_buf_init() fixes the problem.

Mimi

The problem is that the command buffer is copied into the tpm_buf with the memcpy, but after the tpm_transmit_cmd, nothing gets copied back to be used by the code path that called tpm_send. There is code that looks at that buffer after trusted_tpm_send returns. Both security/keys/trusted.c and crypto/asymmetric_keys/asym_tpm.c run into this.

Quoted 8 lines

While playing around with it, adding a memcpy() after the transmit call worked for me as well as setting buf.data directly instead of the tpm_buf_init/memcpy/tpm_buf_destroy calls.

I'm wondering if it would be worthwhile to convert the security/keys/trusted.c and crypto/asymmertic_keys/aym_tpm.c code to use the same tpm_buf and tpm_buf manipulation code as gets used in drivers/char/tpm.

This is exactly what patch #2 in this patch-set [1] tries to achieve.

[1] https://lkml.org/lkml/2019/9/16/196

-Sumit

#11 lore raw
Quoted 56 lines · Sumit Garg
Quoted 46 lines · Jerry Snitselaar
Quoted 27 lines · Mimi Zohar
Quoted 26 lines · Mimi Zohar
Quoted 7 lines · Jarkko Sakkinen
Quoted 6 lines · Mimi Zohar
Quoted 5 lines · Mimi Zohar
Quoted 1 line · Mimi Zohar

Create, save and load trusted keys test

Creating trusted keys is failing with the following messages. Any idea why?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
[  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
[  147.014678] trusted_key: srkseal failed (-1)
[  147.014687] trusted_key: key_seal failed (-1)

This is a regression, that needs to be resolved. The test works on kernels prior to 5.1.

It breaks on 5.2?

No, the regression is in 5.1.

Quoted 2 lines

Can you bisect the failing commit?

git bisect start -- drivers/char/tpm/
git bisect bad
git bisect good v5.0

Quoted 9 lines
Quoted 2 lines
# first bad commit: [412eb585587a1dc43c9622db79de9663b6c4c238] tpm:
use tpm_buf in tpm_transmit_cmd() as the IO parameter

In tpm_send(), setting buf.data directly to cmd, instead of calling tpm_buf_init() fixes the problem.

Mimi

The problem is that the command buffer is copied into the tpm_buf with the memcpy, but after the tpm_transmit_cmd, nothing gets copied back to be used by the code path that called tpm_send. There is code that looks at that buffer after trusted_tpm_send returns. Both security/keys/trusted.c and crypto/asymmetric_keys/asym_tpm.c run into this.

Quoted 8 lines

While playing around with it, adding a memcpy() after the transmit call worked for me as well as setting buf.data directly instead of the tpm_buf_init/memcpy/tpm_buf_destroy calls.

I'm wondering if it would be worthwhile to convert the security/keys/trusted.c and crypto/asymmertic_keys/aym_tpm.c code to use the same tpm_buf and tpm_buf manipulation code as gets used in drivers/char/tpm.

Quoted 5 lines

This is exactly what patch #2 in this patch-set [1] tries to achieve.

[1] https://lkml.org/lkml/2019/9/16/196

-Sumit

I'll take a look at the patchset today.

Regards,
Jerry

author maintainer
#12 lore raw
In reply to Jerry Snitselaar
Quoted 45 lines · Jerry Snitselaar
Quoted 27 lines · Mimi Zohar
Quoted 26 lines · Mimi Zohar
Quoted 7 lines · Jarkko Sakkinen
Quoted 6 lines · Mimi Zohar
Quoted 5 lines · Mimi Zohar
Quoted 1 line · Mimi Zohar

Create, save and load trusted keys test

Creating trusted keys is failing with the following messages. Any idea why?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
[  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
[  147.014678] trusted_key: srkseal failed (-1)
[  147.014687] trusted_key: key_seal failed (-1)

This is a regression, that needs to be resolved.  The test works on kernels prior to 5.1.

It breaks on 5.2?

No, the regression is in 5.1.

Quoted 2 lines

Can you bisect the failing commit?

git bisect start -- drivers/char/tpm/
git bisect bad
git bisect good v5.0

Quoted 9 lines
Quoted 2 lines
# first bad commit: [412eb585587a1dc43c9622db79de9663b6c4c238] tpm:
use tpm_buf in tpm_transmit_cmd() as the IO parameter

In tpm_send(), setting buf.data directly to cmd, instead of calling tpm_buf_init() fixes the problem.

Mimi

The problem is that the command buffer is copied into the tpm_buf with the memcpy, but after the tpm_transmit_cmd, nothing gets copied back to be used by the code path that called tpm_send. There is code that looks at that buffer after trusted_tpm_send returns. Both security/keys/trusted.c and crypto/asymmetric_keys/asym_tpm.c run into this.

Quoted 3 lines

While playing around with it, adding a memcpy() after the transmit call worked for me as well as setting buf.data directly instead of the tpm_buf_init/memcpy/tpm_buf_destroy calls.

Thanks!  I really appreciate your looking at the problem.  I haven't yet tried the fix with a TPM 2.0.

Quoted 5 lines

I'm wondering if it would be worthwhile to convert the security/keys/trusted.c and crypto/asymmertic_keys/aym_tpm.c code to use the same tpm_buf and tpm_buf manipulation code as gets used in drivers/char/tpm.

For now, let's keep the regression fix, that is backported, simple and straight forward.

Trusted keys is evolving to be more than just TPM based keys.  I'm sure there will be more changes coming.  At least, now, there is a TPM 1.2 regression test.

thanks,

Mimi

#13 lore raw
Quoted 46 lines · Mimi Zohar
Quoted 45 lines · Jerry Snitselaar
Quoted 27 lines · Mimi Zohar
Quoted 26 lines · Mimi Zohar
Quoted 7 lines · Jarkko Sakkinen
Quoted 6 lines · Mimi Zohar
Quoted 5 lines · Mimi Zohar
Quoted 1 line · Mimi Zohar

Create, save and load trusted keys test

Creating trusted keys is failing with the following messages. Any idea why?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
[  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
[  147.014678] trusted_key: srkseal failed (-1)
[  147.014687] trusted_key: key_seal failed (-1)

This is a regression, that needs to be resolved.  The test works on kernels prior to 5.1.

It breaks on 5.2?

No, the regression is in 5.1.

Quoted 2 lines

Can you bisect the failing commit?

git bisect start -- drivers/char/tpm/
git bisect bad
git bisect good v5.0

Quoted 9 lines
Quoted 2 lines
# first bad commit: [412eb585587a1dc43c9622db79de9663b6c4c238] tpm:
use tpm_buf in tpm_transmit_cmd() as the IO parameter

In tpm_send(), setting buf.data directly to cmd, instead of calling tpm_buf_init() fixes the problem.

Mimi

The problem is that the command buffer is copied into the tpm_buf with the memcpy, but after the tpm_transmit_cmd, nothing gets copied back to be used by the code path that called tpm_send. There is code that looks at that buffer after trusted_tpm_send returns. Both security/keys/trusted.c and crypto/asymmetric_keys/asym_tpm.c run into this.

Quoted 7 lines
Quoted 3 lines

While playing around with it, adding a memcpy() after the transmit call worked for me as well as setting buf.data directly instead of the tpm_buf_init/memcpy/tpm_buf_destroy calls.

Thanks!  I really appreciate your looking at the problem.  I haven't yet tried the fix with a TPM 2.0.

Quoted 1 line

I don't know the security/keys/trusted.c code well at all, but it looks like parts of it are wired up to differentiate between tpm1.2 and tpm2.0, and others are not. There is a tpm_seal_trusted and tpm_unseal_trusted that gets used for tpm2, and are called in trusted_instantiate, which does a tpm_is_tpm2 check, but trusted_update just calls the tpm1.2 code and has no tpm2 checks from what I can tell.

Quoted 8 lines
Quoted 4 lines

I'm wondering if it would be worthwhile to convert the security/keys/trusted.c and crypto/asymmertic_keys/aym_tpm.c code to use the same tpm_buf and tpm_buf manipulation code as gets used in drivers/char/tpm.

For now, let's keep the regression fix, that is backported, simple and straight forward.

Agreed, I was just talking about in general. but it looks like Sumit has already taken that task on.

Quoted 8 lines

Trusted keys is evolving to be more than just TPM based keys.  I'm sure there will be more changes coming.  At least, now, there is a TPM 1.2 regression test.

thanks,

Mimi

#14 lore raw
In reply to Mimi Zohar
Quoted 20 lines · Mimi Zohar
Quoted 7 lines · Jarkko Sakkinen
Quoted 6 lines · Mimi Zohar
Quoted 5 lines · Mimi Zohar
Quoted 1 line · Mimi Zohar

Create, save and load trusted keys test

Creating trusted keys is failing with the following messages. Any idea why?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
[  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
[  147.014678] trusted_key: srkseal failed (-1)
[  147.014687] trusted_key: key_seal failed (-1)

This is a regression, that needs to be resolved.  The test works on kernels prior to 5.1.

It breaks on 5.2?

No, the regression is in 5.1.

Quoted 1 line
Quoted 8 lines
Quoted 1 line

Can you bisect the failing commit?

git bisect start -- drivers/char/tpm/
git bisect bad
git bisect good v5.0

# first bad commit: [412eb585587a1dc43c9622db79de9663b6c4c238] tpm:
use tpm_buf in tpm_transmit_cmd() as the IO parameter

Thank you. As I said I'll add your test to the tests that I regulary run so that this cannot happen again.

/Jarkko

#16 lore raw
In reply to Mimi Zohar
Quoted 3 lines · Mimi Zohar

Create, save and load trusted keys test

Also can be used to test Sumit's patches i.e. there is an immediate application for this one. I'll use this check TPM 1.x and TPM 2.0 trusted keys code.

You could sanity check your script for sending with my master, which already has those patches.

/Jarkko

author maintainer
#17 lore raw
Quoted 11 lines · Jarkko Sakkinen
Quoted 3 lines · Mimi Zohar

Create, save and load trusted keys test

Also can be used to test Sumit's patches i.e. there is an immediate application for this one. I'll use this check TPM 1.x and TPM 2.0 trusted keys code.

You could sanity check your script for sending with my master, which already has those patches.

Sure, but due to the holidays that won't happen until the middle of next week.

Mimi

#18 lore raw
Quoted 10 lines · Mimi Zohar
Quoted 9 lines · Jarkko Sakkinen
Quoted 3 lines · Mimi Zohar

Create, save and load trusted keys test

Also can be used to test Sumit's patches i.e. there is an immediate application for this one. I'll use this check TPM 1.x and TPM 2.0 trusted keys code.

Quoted 5 lines
Quoted 2 lines

You could sanity check your script for sending with my master, which already has those patches.

Sure, but due to the holidays that won't happen until the middle of next week.

There is no immediate rush, or more like, this should not be rushed.

I'm also waiting v8 now because of sparse issues.

/Jarkko

#19 lore raw
Quoted 14 lines · Jarkko Sakkinen
Quoted 13 lines · Mimi Zohar
Quoted 11 lines · Jarkko Sakkinen
Quoted 3 lines · Mimi Zohar

Create, save and load trusted keys test

Also can be used to test Sumit's patches i.e. there is an immediate application for this one. I'll use this check TPM 1.x and TPM 2.0 trusted keys code.

You could sanity check your script for sending with my master, which already has those patches.

Quoted 6 lines
Quoted 2 lines

Sure, but due to the holidays that won't happen until the middle of next week.

There is no immediate rush, or more like, this should not be rushed.

I'm also waiting v8 now because of sparse issues.

OK, so you must get rid of TrouSerS dependency. Otherwise this is unsuitable for kernel selftests. Please do TPM 1.x with the raw TPM device.

A legit selftest should be implemented only with POSIX assets.

/Jarkko