Skip to contentSkip to conversation

MAINTAINERS: Add a git and a maintainer entry to keyring subsystems

PATCH In review Jarkko Sakkinen 3 participants 7 messages Sep 10, 2019 – Sep 16, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Add a git and a maintainer entry to keyring subsystems

Add Jarkko Sakkinen as co-maintainer of KEYS/KEYRINGS and add
git://git.infradead.org/users/jjs/linux-tpmdd.git as the GIT repository for KEYS-TRUSTED.

Cc David Howells <[email protected]>
Cc Mimi Zohar <[email protected]>
Cc James Bottomley <[email protected]>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index 108ea925a5d9..aa7cedd671d4 100644
@@ -8937,6 +8937,7 @@ M:	Jarkko Sakkinen <[email protected]>
 M:	Mimi Zohar <[email protected]>
 L:	[email protected]
 L:	[email protected]
+T:	git git://git.infradead.org/users/jjs/linux-tpmdd.git
 S:	Supported
 F:	Documentation/security/keys/trusted-encrypted.rst
 F:	include/keys/trusted-type.h
@@ -8945,6 +8946,7 @@ F:	security/keys/trusted.h
 
 KEYS/KEYRINGS:
 M:	David Howells <[email protected]>
+M:	Jarkko Sakkinen <[email protected]>
 L:	[email protected]
 S:	Maintained
 F:	Documentation/security/keys/core.rst
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 1 line · Jarkko Sakkinen

Subject: [PATCH] MAINTAINERS: Add a git and a maintainer entry to keyring subsystems

I would recommend splitting the patch in two and putting something like:

keys: Add Jarkko Sakkinen as co-maintainer

as the subject of the keyrings maintainership one.

Thanks,
David

#2 lore raw
Quoted 9 lines · David Howells
Quoted 1 line · Jarkko Sakkinen

Subject: [PATCH] MAINTAINERS: Add a git and a maintainer entry to keyring subsystems

I would recommend splitting the patch in two and putting something like:

keys: Add Jarkko Sakkinen as co-maintainer

as the subject of the keyrings maintainership one.

Why is there utility in micro splitting such a trivial patch?

#3 lore raw
Quoted 5 lines · Joe Perches
Quoted 4 lines · David Howells
Quoted 1 line · Jarkko Sakkinen

Subject: [PATCH] MAINTAINERS: Add a git and a maintainer entry to keyring subsystems

Quoted 7 lines
Quoted 5 lines

I would recommend splitting the patch in two and putting something like:

keys: Add Jarkko Sakkinen as co-maintainer

as the subject of the keyrings maintainership one.

Why is there utility in micro splitting such a trivial patch?

I kind of get this for the MAINTAINERS file so that the changes can be agreed/disagreed separately.

/Jarkko

maintainer
#4 lore raw
In reply to Joe Perches
Quoted 7 lines · Joe Perches
Quoted 5 lines

I would recommend splitting the patch in two and putting something like:

keys: Add Jarkko Sakkinen as co-maintainer

as the subject of the keyrings maintainership one.

Why is there utility in micro splitting such a trivial patch?

Because the keyrings maintainership piece is addressing a major procedural concern on Linus's part - and I think it needs to go in its own patch with the subject I suggested.

David

#5 lore raw
Quoted 6 lines · David Howells
Quoted 4 lines · Joe Perches
Quoted 4 lines

I would recommend splitting the patch in two and putting something like:

keys: Add Jarkko Sakkinen as co-maintainer

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

as the subject of the keyrings maintainership one.

Why is there utility in micro splitting such a trivial patch?

Because the keyrings maintainership piece is addressing a major procedural concern on Linus's part - and I think it needs to go in its own patch with the subject I suggested.

I'll send separate patches tomorrow.

/Jarkko

#6 lore raw
In reply to David Howells
Quoted 9 lines · David Howells
Quoted 1 line · Jarkko Sakkinen

Subject: [PATCH] MAINTAINERS: Add a git and a maintainer entry to keyring subsystems

I would recommend splitting the patch in two and putting something like:

keys: Add Jarkko Sakkinen as co-maintainer

as the subject of the keyrings maintainership one.

Thanks, I'll refine accordingly.

/Jarkko