Skip to contentSkip to conversation

configure: Add xkbcommon configure options

PATCH Applied James Le Cuirot 4 participants 7 messages Sep 14, 2019 – Sep 19, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: Add xkbcommon configure options

This dependency is currently "automagic", which is bad for distributions.

---
 configure | 5 +++++
 1 file changed, 5 insertions(+)
configure +5 -0
index 30aad233d1..30544f52e6 100755
@@ -1521,6 +1521,10 @@ for opt do
   ;;
   --disable-libpmem) libpmem=no
   ;;
+  --enable-xkbcommon) xkbcommon=yes
+  ;;
+  --disable-xkbcommon) xkbcommon=no
+  ;;
   *)
       echo "ERROR: unknown option $opt"
       echo "Try '$0 --help' for more information"
@@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
   capstone        capstone disassembler support
   debug-mutex     mutex debugging support
   libpmem         libpmem support
+  xkbcommon       xkbcommon support
 
 NOTE: The object files are built at the place where configure is launched
 EOF
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw

Le 14/09/2019 à 16:51, James Le Cuirot a écrit :

Quoted 24 lines

This dependency is currently "automagic", which is bad for distributions.

---
 configure | 5 +++++
 1 file changed, 5 insertions(+)
configure +4 -0
index 30aad233d1..30544f52e6 100755
@@ -1521,6 +1521,10 @@ for opt do
   ;;
   --disable-libpmem) libpmem=no
   ;;
+  --enable-xkbcommon) xkbcommon=yes
+  ;;
+  --disable-xkbcommon) xkbcommon=no
+  ;;
   *)
       echo "ERROR: unknown option $opt"
       echo "Try '$0 --help' for more information"

configure disabled with --disable-FEATURE, default is enabled if available: · line 1814

Quoted 7 lines
configure +1 -0
@@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
   capstone        capstone disassembler support
   debug-mutex     mutex debugging support
   libpmem         libpmem support
+  xkbcommon       xkbcommon support
 
 NOTE: The object files are built at the place where configure is launched
 EOF
cc Gerd Hoffmann <[email protected]>
Reviewed-by
#2 lore raw
Quoted 29 lines · Laurent Vivier

Le 14/09/2019 à 16:51, James Le Cuirot a écrit :

Quoted 28 lines

This dependency is currently "automagic", which is bad for distributions.

---
 configure | 5 +++++
 1 file changed, 5 insertions(+)
configure +5 -0
index 30aad233d1..30544f52e6 100755
@@ -1521,6 +1521,10 @@ for opt do
   ;;
   --disable-libpmem) libpmem=no
   ;;
+  --enable-xkbcommon) xkbcommon=yes
+  ;;
+  --disable-xkbcommon) xkbcommon=no
+  ;;
   *)
       echo "ERROR: unknown option $opt"
       echo "Try '$0 --help' for more information"
@@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
   capstone        capstone disassembler support
   debug-mutex     mutex debugging support
   libpmem         libpmem support
+  xkbcommon       xkbcommon support
 
Quoted 7 lines

configure disabled with --disable-FEATURE, default is enabled if available: · line 1814

Quoted 3 lines
configure +0 -0
 NOTE: The object files are built at the place where configure is launched
 EOF
cc Gerd Hoffmann <[email protected]>
#3 lore raw

Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit :

Quoted 36 lines · Laurent Vivier
Quoted 35 lines

Le 14/09/2019 à 16:51, James Le Cuirot a écrit :

Quoted 24 lines

This dependency is currently "automagic", which is bad for distributions.

---
 configure | 5 +++++
 1 file changed, 5 insertions(+)
configure +4 -0
index 30aad233d1..30544f52e6 100755
@@ -1521,6 +1521,10 @@ for opt do
   ;;
   --disable-libpmem) libpmem=no
   ;;
+  --enable-xkbcommon) xkbcommon=yes
+  ;;
+  --disable-xkbcommon) xkbcommon=no
+  ;;
   *)
       echo "ERROR: unknown option $opt"
       echo "Try '$0 --help' for more information"

configure disabled with --disable-FEATURE, default is enabled if available: · line 1814

Quoted 7 lines
configure +1 -0
@@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
   capstone        capstone disassembler support
   debug-mutex     mutex debugging support
   libpmem         libpmem support
+  xkbcommon       xkbcommon support
 
 NOTE: The object files are built at the place where configure is launched
 EOF
Quoted 4 lines
Quoted 1 line
cc Gerd Hoffmann <[email protected]>

Gerd,

do you take this through your ui branch or should I take through the trivial patches branch?

Thanks,
Laurent

#4 lore raw
Quoted 39 lines · Laurent Vivier

Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit :

Quoted 38 lines · Laurent Vivier
Quoted 36 lines

Le 14/09/2019 à 16:51, James Le Cuirot a écrit :

Quoted 24 lines

This dependency is currently "automagic", which is bad for distributions.

---
 configure | 5 +++++
 1 file changed, 5 insertions(+)
configure +4 -0
index 30aad233d1..30544f52e6 100755
@@ -1521,6 +1521,10 @@ for opt do
   ;;
   --disable-libpmem) libpmem=no
   ;;
+  --enable-xkbcommon) xkbcommon=yes
+  ;;
+  --disable-xkbcommon) xkbcommon=no
+  ;;
   *)
       echo "ERROR: unknown option $opt"
       echo "Try '$0 --help' for more information"

configure disabled with --disable-FEATURE, default is enabled if available: · line 1814

Quoted 7 lines
configure +1 -0
@@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
   capstone        capstone disassembler support
   debug-mutex     mutex debugging support
   libpmem         libpmem support
+  xkbcommon       xkbcommon support
 
 NOTE: The object files are built at the place where configure is launched
 EOF
cc Gerd Hoffmann <[email protected]>
Quoted 7 lines
Quoted 2 lines

Gerd,

do you take this through your ui branch or should I take through the trivial patches branch?

Trivial branch is fine (have not picked this up b/c I saw qemu-trivial on cc).

cheers,
Gerd

Quoted 3 lines

Thanks,
Laurent

#5 lore raw

Le 19/09/2019 à 13:01, Gerd Hoffmann a écrit :

Quoted 43 lines · Laurent Vivier
Quoted 42 lines

Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit :

Quoted 40 lines · Laurent Vivier
Quoted 29 lines

Le 14/09/2019 à 16:51, James Le Cuirot a écrit :

Quoted 28 lines

This dependency is currently "automagic", which is bad for distributions.

---
 configure | 5 +++++
 1 file changed, 5 insertions(+)
configure +5 -0
index 30aad233d1..30544f52e6 100755
@@ -1521,6 +1521,10 @@ for opt do
   ;;
   --disable-libpmem) libpmem=no
   ;;
+  --enable-xkbcommon) xkbcommon=yes
+  ;;
+  --disable-xkbcommon) xkbcommon=no
+  ;;
   *)
       echo "ERROR: unknown option $opt"
       echo "Try '$0 --help' for more information"
@@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
   capstone        capstone disassembler support
   debug-mutex     mutex debugging support
   libpmem         libpmem support
+  xkbcommon       xkbcommon support
 
Quoted 7 lines

configure disabled with --disable-FEATURE, default is enabled if available: · line 1814

Quoted 3 lines
configure +0 -0
 NOTE: The object files are built at the place where configure is launched
 EOF
cc Gerd Hoffmann <[email protected]>
Quoted 7 lines
Quoted 4 lines

Gerd,

do you take this through your ui branch or should I take through the trivial patches branch?

Trivial branch is fine (have not picked this up b/c I saw qemu-trivial on cc).

Applied to my trivial-patches branch.

Thanks,
Laurent

Reviewed-by on v1 1/1
#6 lore raw
In reply to James Le Cuirot
Quoted 2 lines · James Le Cuirot

This dependency is currently "automagic", which is bad for distributions.

Quoted 29 lines
---
 configure | 5 +++++
 1 file changed, 5 insertions(+)
configure +5 -0
index 30aad233d1..30544f52e6 100755
@@ -1521,6 +1521,10 @@ for opt do
   ;;
   --disable-libpmem) libpmem=no
   ;;
+  --enable-xkbcommon) xkbcommon=yes
+  ;;
+  --disable-xkbcommon) xkbcommon=no
+  ;;
   *)
       echo "ERROR: unknown option $opt"
       echo "Try '$0 --help' for more information"
@@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
   capstone        capstone disassembler support
   debug-mutex     mutex debugging support
   libpmem         libpmem support
+  xkbcommon       xkbcommon support
 
 NOTE: The object files are built at the place where configure is launched
 EOF